abinoda / label-when-approved-action Goto Github PK

We're looking forward to be able to change this value.
When do you support GitHub Enterprise?
Or how can I handle this on my own?
https://github.com/abinoda/label-when-approved-action/blob/master/entrypoint.sh#L30

Every time a PR is approved it takes around 1 minute to build the docker image and then it runs the script. I was wondering if it makes sense to publish a prebuilt docker image to docker hub so that it doesn't need to be built it every time.

Same issue as this one.
#63

Oddly enough, I was able to get the value without any problems when I verified jq in another workflow.

However, I get a jq error when I run label-when-approved-action@master.

It also works fine in some repositories.
Does this result depend on the repository settings?

jj

I have an idea for further improving this action. I've been searching for an workflow that automatically labels on approval and this fits the bill nicely.
Frustratingly however the labeller will add the label on any approved PR, and I want it to be conditional perhaps based on a config file or on other labels applied to the PR.

For example I want to add a QA required label automatically, however there are some circumstances where this label is not the best label to add to an approved PR (e.g. dependency bump PRs get treated differently), so I want to be able to control when the auto action is triggered.

Could include issue #10 in this and add optional condition that approval required from all who review?

On our project, when an author creates a PR, they choose how many people to review their PR. It's usually 2 people, but sometimes 1, sometimes up to 6.

Rather than labelling when a fixed number have approved (eg. APPROVALS: "2"), would it be possible to label once all the current PR's reviewers have reviewed?

For example:

• if a PR has 2 reviewers, label when both have reviewed
• if a PR has 4 reviewers, label when all 4 have reviewed
• if a PR has 8 reviewers, label when all 8 have reviewed

Perhaps allow something like APPROVALS: "all" in the workflow .yml, and then something like this (pseudocode):

if [[ "$APPROVALS" == "all" ]]; then
    $APPROVALS = length($reviews)
fi

and do it somewhere before this:

https://github.com/pullreminders/label-when-approved-action/blob/d8e895923241c6399899471c5eb91fc3cc717776/entrypoint.sh#L53-L55

Thank you!

Cannot index string with string "state"

I am getting the following error even i added the token to my repository secret.

Error message - /entrypoint.sh: line 47: ADD_LABEL: unbound variable
Example log of an action here

This is related to #3

on: pull_request_review
name: Label approved pull requests
jobs:
labelWhenApproved:
name: Label when approved
runs-on: ubuntu-latest
steps:
- name: Label when approved
uses: pullreminders/label-when-approved-action@master
env:
APPROVALS: "2"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ADD_LABEL: "approved"
REMOVE_LABEL: "awaiting%20review"

Hi!

Thanks for a great action! Today we have noticed the action cannot be located, have you seen this or do you have any suggestions? It was working great until today.

Error: Unable to resolve actions. Repository not found : pullreminders/label-when-approved-action.

Thanks

Is there any way to add two more labels when PR approved ?

Does this not work with pull requests from forks? I'm getting the following error:

{
  "message": "Resource not accessible by integration",
  "documentation_url": "https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue"
}
{
  "message": "Resource not accessible by integration",
  "documentation_url": "https://developer.github.com/v3/issues/labels/#remove-a-label-from-an-issue"
}

Make it cross platform. Thanks.

Would it be possible to optionally remove a label when a PR is approved?

We want the ability to change the required number of reviews based on some existing labels.

Our usecase is like this:
We require at least 2 reviewers on each PR, but some parts of the repo are more sensitive and we want 3 reviewers on those PRs and label them with 3-reviewers, so that even though github enables merging after 2, by convention we don't merge them unless they get 3 reviews. So basically we want to be able to define different steps based on the presence of a particular label.

Would it be possible to express this in this action?