GithubHelp home page GithubHelp logo

Comments (4)

ablanco avatar ablanco commented on July 22, 2024

I made a new release with a small change so the verdict and score get passed to the event handler.
https://github.com/ablanco/jquery.pwstrength.bootstrap/releases/tag/1.1.3

I hope that helps.

Regards.

from jquery.pwstrength.bootstrap.

daveshapiro avatar daveshapiro commented on July 22, 2024

I appreciate your time on this, but I'm not sure that passing score and verdictText is optimal. Score seems to be more of an arbitrary number (can be negative or positive and the min/max of score depends on the registered rules) which means we would need to call into your library in order to extract useful information from the score (ie: verdict level). Verdict text is ok, but also not great since it requires string comparisons which are best to avoid (especially in localized software). The best approach would be to return the verdict level (0-4) which can be treated as an enum (ie: verdict.weak, verdict.average, etc) in our own code.

Thanks

from jquery.pwstrength.bootstrap.

ablanco avatar ablanco commented on July 22, 2024

Now the level is passed to the event handler:
https://github.com/ablanco/jquery.pwstrength.bootstrap/releases/tag/1.1.5

from jquery.pwstrength.bootstrap.

daveshapiro avatar daveshapiro commented on July 22, 2024

Awesome! Thank you so much!

from jquery.pwstrength.bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.