abogushov / django-admin-json-editor

Adds json-editor for JSONField in Django Administration

• 👋 Hi, I’m @abogushov
• 👀 I’m interested in ...
• 🌱 I’m currently learning ...
• 💞️ I’m looking to collaborate on ...
• 📫 How to reach me ...

django-admin-json-editor's Issues

Unknown theme

When using default theme 'bootstrap3' I have an error in console
"Unknown theme bootstrap3"

how can I make the field optional not always required

as described in the documentation, i used a form for one of my fields

class ProductAdminForm(forms.ModelForm):
    class Meta:
        model = User
        fields = '__all__'
        widgets = {
            'editorial_data': JSONEditorWidget(DATA_SCHEMA, collapsed=False),
        }

but it seems that now I cannot save unless I provide that field. How can I make it optionaly

How this widget is shown?

Well, I realized that making a test and reading the example. So, I just add the example image into readme file. This more explicit presentation could helps interested users. Pull request: #20

List dependency on pathlib.

Hey there,

pip install django-admin-json-editor failed on my machine because I was missing pathlib. Maybe you could list that as a dependency in your install instructions?

Thanks!

Edit: I see this package is only meant for python 3. I'll close this.

trying to use json widget

Hello thanks for the great work
i am trying to update the widget to show json editor in the admin https://github.com/abogushov/django-admin-json-editor
but so far couldn't get this done
is there any example where i can follow or documentation to make this work

Thanks!

Set and render new DATA_SCHEMA

Is there a way to set and render new data_schema on the page? The problem is to set json schema value on another field change event.

fontawesome4 not loaded

Since you auto set the iconlib to fontawesome4, can you also add the django-fontawesome (or django-font-awesome?) dependency to the plugin ? Icons aren't showing to the user if he doesn't have the font installed on his system.

how to set required fields ?

It looks like json-editor allows setting a required option to define what fields should be required or not.

I tried a schema like this:

HOST_ROLES_SCHEMA = {
    'type': 'array',
    'title': 'roles',
    'format': 'table',
    'items': {
        'type': 'object',
        'required': [
            'name',
            'tag',
        ],
        'properties': {
            'name': {
                'title': 'Name',
                'type': 'string',
                'format': 'text',
            },
            'tag': {
                'title': 'Tag',
                'type': 'string',
                'format': 'text',
            }
         }
    }
}

I also tried this version:
I tried a schema like this:

HOST_ROLES_SCHEMA = {
    'type': 'array',
    'title': 'roles',
    'format': 'table',
    'items': {
        'type': 'object',
        'properties': {
            'name': {
                'title': 'Name',
                'type': 'string',
                'format': 'text',
                'required': True,
            },
            'tag': {
                'title': 'Tag',
                'type': 'string',
                'format': 'text',
                'required': True,
            }
         }
    }
}

But I can keep saving the model with empty fields in django admin. Is this property not supported ? Do I need to add some custom code to handle it myself ? Not seeing any required html attribute or class name in the generated html output, I'm not sure where to go from there.

Use other widgets within json editor

Is it possible to use other widgets, let's say an ImageField on one of the json schema properties ie a string format url ?

Doesn't close the properties modal when pressing outside of it

You need to press on Properties again to close the modal

Do not save JSON if there are validation errors

Dark mode issue

Django 3.2.12
django-admin-json-editor 0.2.3

cache issue in django admin json editor

Hi,

I am using this extension(0.2.3) with Django 3.1.3
Added 1 entry via this form, when adding second entry with new data, sometimes it adds entry with first entry's data, it looks like it caching form data somewhere.

Please check the code below and help.

Thanks.

POLICY_FORM = {
  "title": "Policy",
  "type": "object",
  "required": [
    "Clicks",
    "Rate"
  ],
  "properties": {
    "Clicks": {
      "type": "number",
      "default": 0,
      "minimum": 0,
      # "maximum": 9900
    },
    "Rate": {
      "type": "number",
      "default": 0,
      "minimum": 0,
      # "maximum": 9900
    }
  }
 }

JSON_OPTION = {
    "theme": "html", 
    "disable_collapse": True,
    "disable_edit_json": True,
    "disable_properties": True,
  }
class PolicyForm(forms.ModelForm):
     policy = forms.JSONField(widget = JSONEditorWidget(POLICY_FORM, collapsed=False, editor_options=JSON_OPTION))

jdorn/json-editor is deprecated

Just realized when clicking on your readme link that the underlying jdorn/json-editor repository has been deprecated, and updates are now done on json-editor/json-editor.

Have you updated the static files with those from that new repo ?
Also, wouldn't it be simpler to use their cdn instead of copying the file ?

<script src="https://cdn.jsdelivr.net/npm/@json-editor/json-editor/dist/jsoneditor.min.js"></script>

Is this package dead?

Add grappelli support

No sceditor

Sceditor is not working properly

style display is strange

hello, I run a new porject like example, but the style display is strange. Is it a bug? How i can do?

environment:

• Winodws 10
• Python36
• Django2.2+

Integrate josdejong/jsoneditor into widget

https://github.com/josdejong/jsoneditor

It looks quite strange in Django admin.. How can I make it follow admin system styling?

json data is null？

i just saved some data in mysql database,when i edit it,it always return null for me.

Missing source map

You guys distribute a minified jsoneditor.min.js - could you please include the source map? Thanks

Json editor in StackedInline

Hello! Thanks for the work in this repository, it works great!

I had a problem and I did not know how to fix it:

I tried to place the form in an admin.StackedInline, then add it to an admin.ModelAdmin

the template worked correctly with the schema, however, sending the form caused error because the field was in None.

class AnotherModelAdminForm(ModelForm):
    class Meta:
        model = AnotherModel
        fields = '__all__'
        widgets = {
            'json_field': JSONEditorWidget(SCHEMA, collapsed=False),
        }
class AnotherModelAdmin(admin.StackedInline):
    model = AnotherModel
    form = AnotherModelAdminForm

@admin.register(MyModel)
class MyModelAdmin(admin.ModelAdmin):
    inlines = [
        AnotherModelAdmin,
    ]

Can you think of a solution?

Thanks in advance

Documentation and examples

This lib looks great when you look at the options in the source code.

But it really lacks intuitive use case examples.

For instance:

• Different types (even a link to the official doc would be useful) like https://github.com/jdorn/json-editor#format
• How to perform validation using the same schema on the model
• How to use regex for validation
• How to use default value
• Nested objects example
• How to display source code using sceditor=True
• List of editor_options
• How to use plugins https://github.com/jdorn/json-editor#specialized-string-editors
• How to have a HTML/Markdown editor through plugins
• Etc.

Populate enum values

Hi, I'm having another issue regarding populating an enum field from db values.

Here's an example:

class HostAdminForm(forms.ModelForm):
    class Meta:
        model = Host
        fields = '__all__'
        HOST_ROLES_SCHEMA['items']['properties']['categoryId'] = {
            'title': 'category',
            'type': 'string',
            'enum': [1, 2, 3, 4, 5],   #  ← We want to get the list of category ids from the db here
        }
        widgets = {
            'details': JSONEditorWidget(HOST_DETAILS_SCHEMA, collapsed=True),
        }

Any idea how we could proceed to do this ? Until now, we've asked our users to figure out what the id was and paste it in a text input :/

Widget render problem

Hi,
I had a problem with rendering the widget with any dict schema passed.
My project uses py2.7 and django 1.11.10

It seems that when pure dict is passed to the context it doesn't turn into a json string that schema attribute for the JS part likes to render.
it turns into a string that contains {u'title': 'sometitle'}

I've added json.dumps to assure json string is sent to the context and now widget renders the schema properly, and made a pull request #13

Doesn't validate the value with the JSONSchema.

import jsonschema

def clean(self):
        try:
            jsonschema.validate(data, SETTINGS_SCHEMA)
        except jsonschema.exceptions.ValidationError as e:
            raise forms.ValidationError(str(e))

DATA_SCHEMA specification

Hello!
Is there any specs available for DATA_SCHEMA?

Do not save last entered value when pressing enter

It seems that the JSON is not updated when pression enter from the field

Issue with python 3.10

Hi,
I'm using python 3.10 and the library raised this issue due to an incompatibility:

  File "/usr/local/lib/python3.10/dist-packages/django/forms/boundfield.py", line 34, in __str__
    return self.as_widget()
  File "/usr/local/lib/python3.10/dist-packages/django/forms/boundfield.py", line 93, in as_widget
    return widget.render(
  File "/usr/local/lib/python3.10/dist-packages/django_admin_json_editor/admin.py", line 24, in render
    self.schema_updater(schema)
  File "/usr/local/lib/python3.10/dist-packages/django_admin_json_editor/admin.py", line 41, in schema_updater
    if isinstance(value, collections.Mapping):
AttributeError: module 'collections' has no attribute 'Mapping'

This way of importing the module has been deprecated since python 3.3:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' has been deprecated since Python 3.3, and in 3.10 it will stop working

It should be enough to change the import statement from import collection to from collections.abc import Mapping

UI is resized when using this package

I experienced a visual bug as soon as I started using this package, this is what my UI look like without it:

And now, after using the JSONEditorWidget in my admin.py

Basically, the UI looks resized, smaller, as if I had zoomed out. Probably a bad CSS rule applying undesired styles on the whole page instead of a sub element or something.

Using Python 3.6, Django 2.1.7