abruzzi / bookish-react-2nd

second edition of bookish

This project was bootstrapped with Create React App.

Available Scripts

In the project directory, you can run:

npm start

Runs the app in the development mode.
Open http://localhost:3000 to view it in the browser.

The page will reload if you make edits.
You will also see any lint errors in the console.

npm test

Launches the test runner in the interactive watch mode.
See the section about running tests for more information.

npm run build

Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.
Your app is ready to be deployed!

See the section about deployment for more information.

npm run eject

Note: this is a one-way operation. Once you eject, you can’t go back!

If you aren’t satisfied with the build tool and configuration choices, you can eject at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except eject will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.

You don’t have to ever use eject. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.

Learn More

You can learn more in the Create React App documentation.

To learn React, check out the React documentation.

Code Splitting

This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting

Analyzing the Bundle Size

This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size

Making a Progressive Web App

This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app

Advanced Configuration

This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration

Deployment

This section has moved here: https://facebook.github.io/create-react-app/docs/deployment

npm run build fails to minify

This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify

bookish-react-2nd's Issues

Found an issue early on in the book, chapter 5, with the order of books being inverted when running Cypress tests.

So I thought I would mention it here and maybe you or someone else could provide some insight. I was working through the code in your book and when I came to the part where you start to use Axios to delete and rebuild the JSON server database (page 72) I noticed that it would always invert the order and the tests would fail. The code in question is this:

  beforeEach(() => {
    const books = [
      {
        id: 1,
        title: 'Refactoring',
      },
      {
        id: 2,
        title: 'Domain-driven design',
      },
    ];
    return books.map(item =>
      axios.post('http://localhost:8080/books', item, {
        headers: {
          'Content-Type': 'application/json',
        },
      }),
    );
  });

Whenever I ran the code the test would fail with the following message:

Shows a book list:

Timed out retrying after 4000ms
    + expected - actual

    -[ 'Domain-driven design', 'Refactoring' ]
    +[ 'Refactoring', 'Domain-driven design' ]

So I started to watch db.json as the tests ran, and it would start out empty (as it would be cleared at the end of each test) then it would be populated by the books array in the right order, and then straight away it would invert the list. Then of course the test would fail.

This was driving me mad as I tried everything under the sun to try and understand what might be flipping the order and causing the tests to fail. I have even completely copy and pasted your spec.js code in (from the same stage in the book) and that is behaving the same way. The only way to make the test pass is to enter the books in reverse order:

    const books = [
      {
        id: 2,
        title: 'Domain-driven design',
      },
      {
        id: 1,
        title: 'Refactoring',
      }
    ];

I have noticed that if I try and run it with 3 books, it starts out right (1 - 2 - 3), then book 2 goes to the top (2 - 1 - 3) and then finally 3 goes to the top (3 - 2 - 1). I feel it is something to do with the map function that posts the books but I can be sure.

Is this something you have encountered before and are you able to point out to me what is going on? I don't want to get too much further into the book if its failing at this early stage...

Thanks....