GithubHelp home page GithubHelp logo

Compilation fail with 2.067-rc1 about dauth HOT 9 CLOSED

NCrashed avatar NCrashed commented on August 15, 2024
Compilation fail with 2.067-rc1

from dauth.

Comments (9)

Abscissa avatar Abscissa commented on August 15, 2024

Engh, that's one reason I really wish dub wouldn't try to blindly build every file in the source. That module only gets imported on older DMDs that don't have SHA-2 in Phobos (it's a copy of an older std.digest.sha modified to include SHA-2), on other DMDs it shouldn't even be getting compiled at all.

Well anyway, SHA-2 has been in Phobos for awhile now (about a year I think), so it may finally be time to just rip that module out entirely.

from dauth.

Abscissa avatar Abscissa commented on August 15, 2024

Hmm, just checked, Phobos gained SHA-2 in v2.066. Ok, I'll see about fixing this.

FWIW there is another bug involved here: Last I checked, dub had a bug where it was using "warnings as errors" even though "informational warnings" is supposed to be dub's default. So really this issue shouldn't have caused the build to fail. But of course, even then, this issue would still need fixed anyway, so it's kinda moot.

from dauth.

NCrashed avatar NCrashed commented on August 15, 2024

2.067 is released but the issue still persists

from dauth.

NCrashed avatar NCrashed commented on August 15, 2024

I've made PR with simple fixes to be able use library with 2.067. I know that isn't the way you want to fix it (as I understand, you would like to throw away custom sha module and use phobos one, but problem in dub makes semantic checks in deprecated module), but it could be simple and fast solution until major solution isn't implemented.

from dauth.

Abscissa avatar Abscissa commented on August 15, 2024

Merged, thanks!

from dauth.

NCrashed avatar NCrashed commented on August 15, 2024

Thanks! Could you add new version tag for dub registry?

from dauth.

Abscissa avatar Abscissa commented on August 15, 2024

Already on it...

from dauth.

Abscissa avatar Abscissa commented on August 15, 2024

Done. Tagged v0.6.2.

from dauth.

NCrashed avatar NCrashed commented on August 15, 2024

Thank you!

from dauth.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.