abscissa / dauth Goto Github PK

Upcoming release of 2.067 is breaking compilation:

Building dauth 0.6.1 configuration "library", build type debug.
Running dmd...
../../../.dub/packages/dauth-0.6.1/src/dauth/sha.d(748): Warning: instead of C-style syntax, use D-style syntax 'ubyte[8] bits'
../../../.dub/packages/dauth-0.6.1/src/dauth/sha.d(772): Warning: instead of C-style syntax, use D-style syntax 'ubyte[16] bits'

Like the title says.

"Salted Hased Password Library for D" should be "Salted Hashed Password Library for D"

1. crypt does not use Base64, hence providing a crypt hash to parseHash fails with a Base64 exception
   Crypt uses it's own keymap (see e.g. here).

2. crypt transposes the hash bytes before encoding them (see sha512-crypt.c, sha256-crypt.c, and md5-crypt.c).

3. parseHash does not handle $round=10000$ parameters as 2nd component

You might want to add the following test case

$6$rounds=10000$tGiXIng0KHBPBHhk$84T63BF34OMoG4TeoGV7ReJ/U/OAtfa9iFOXQ/Wsd4s3N2wBcdUCPllpkzgYbFfagBcIZxyjqcfvL.KjdiBFJ1

which encrypts the password mypass.
Also passlib might be a useful inspiration for a correct implementation.

In my windows pc, I cannot compiled the library without replacing import std.c.windows.windows;
with import core.sys.windows.windows;.

Please note that the same problem exist for instauser too.

It appears that

makeHash("password".dup.toPassword).toString

returns different values with the same execution of the program,
but returns the same values in the same order in separate executions.

This would mean you are seeding rand with a know value right?