acanas / swad-core

Main core for SWAD platform (Social Workspace At a Distance)

swad-core

Main core for SWAD platform (Shared Workspace At a Distance)

• https://openswad.org/ (Main site)
• https://openswad.org/install/ (Installing SWAD on your server)
• http://en.wikipedia.org/wiki/SWAD_%28software%29 (Wikipedia, English)
• http://es.wikipedia.org/wiki/SWAD (Wikipedia, Spanish)
• https://twitter.com/OpenSWAD (Twitter)

swad-core's Issues

Plantilla material design

Si se consiguiera extraer de alguna forma el diseño tal y como indico en el issue #11 se podría desarrollar de forma sencilla una interfaz alternativa para SWAD utilizando por ejemplo el estilo material design, para hacernos una idea: https://getmdl.io/templates/dashboard/index.html

A teacher should be able to remove a student's work?

Check if a teacher can remove a student's work. He/she should be able to do it and now he/she can not. Check it for out-of-date activities.

Trouble

Excuse me? I'm trying to install SWAD but I got trouble, the instruction of installation step.14 edit the file 'swad_config.h' making necessary modifications. What are the necessary modifications?

Deletion of notices

Javier Fdez. wrote:

No puedo eliminar un aviso post-it.

Check for deletion of notices.

getTests webservice returns empty response

The getTests service always returns an empty response.

The curse has got the tests data download option enabled:

getTestConfig call to check if there are tests available in the course:

<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:urn="urn:swad">
   <soapenv:Header/>
   <soapenv:Body>
      <urn:getTestConfig>
         <!--Optional:-->
         <wsKey>[REDACTED]</wsKey>
         <courseCode>4270</courseCode>
      </urn:getTestConfig>
   </soapenv:Body>
</soapenv:Envelope>

getTestConfig response showing test data is available:

<?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" xmlns:SOAP-ENC="http://schemas.xmlsoap.org/soap/encoding/" xmlns:swad="urn:swad" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
   <SOAP-ENV:Header />
   <SOAP-ENV:Body>
      <swad:getTestConfigOutput>
         <pluggable>1</pluggable>
         <numQuestions>55</numQuestions>
         <minQuestions>1</minQuestions>
         <defQuestions>4</defQuestions>
         <maxQuestions>20</maxQuestions>
         <feedback>fullFeedback</feedback>
         <visibility>31</visibility>
      </swad:getTestConfigOutput>
   </SOAP-ENV:Body>
</SOAP-ENV:Envelope>

getTests call:

<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:urn="urn:swad">
   <soapenv:Header/>
   <soapenv:Body>
      <urn:getTests>
         <!--Optional:-->
         <wsKey>[REDACTED]</wsKey>
         <courseCode>4270</courseCode>
         <beginTime>0</beginTime>
      </urn:getTests>
   </soapenv:Body>
</soapenv:Envelope>

getTests response:

<?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" xmlns:SOAP-ENC="http://schemas.xmlsoap.org/soap/encoding/" xmlns:swad="urn:swad" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
   <SOAP-ENV:Header />
   <SOAP-ENV:Body>
      <swad:getTestsOutput>
         <tagsArray />
         <questionsArray />
         <answersArray />
         <questionTagsArray />
      </swad:getTestsOutput>
   </SOAP-ENV:Body>
</SOAP-ENV:Envelope>

Problema al desplegar pestañas en iPhone con Safari

Cuando despliegas pestañas para navegar dentro de los documentos de la asignatura, el navegador se va a una pagina en blanco, teniendo que volver hacia atras para acceder al contenido. No pasa cuando accedes a un archivo, solo al desplegar pestañas.

modularizar swad_layout.c

Hola, veo que el grueso del código html está "hardcodeado" en el fichero swad_layout.c, quizá estaría bien poder cargar dicho código desde un fichero externo para poder hacer modificaciones a la plantilla de forma más sencilla.

Bug in STATS > Report

In the history of courses hundreds of clicks appear in 2016 for a user who has not clicked in that year.

make fails due to missing swad_cookie.[c,h] files from repository

$ git clone https://github.com/acanas/swad-core.git
$ cd swad-core
$ make
gcc -Wall -Wextra -mtune=native -Os -s -c -o swad_action.o swad_action.c
swad_action.c:40:10: fatal error: swad_cookie.h: No such file or directory
#include "swad_cookie.h"
^~~~~~~~~~~~~~~
compilation terminated.
<builtin>: recipe for target 'swad_action.o' failed
make: *** [swad_action.o] Error 1

Both swad_cookie.h and swad_cookie.c appear to be missing from the github repo.

Volver a elegir la asignatura cuando se pulsa sobre enlace externo

Encima de la lista de usuarios conectados aparecen ciertos enlaces externos. Cuando estas en una asignatura actual y pulsas sobre uno de esos enlaces, en la siguiente navegación se debe elegir de nuevo la asignatura.

Pasos para reproducir:

• Navega en Swad inscrito en una asignatura
• Pulsa en uno de los enlaces mencionados en la parte derecha
• Pulsa en cualquier botón de la navegación superior

Abrir en nueva pestaña obliga a reintroducir la identificación

Al pulsar cualquier enlace para abrirlo en una nueva pestaña, ya sea para abrir documentos o acceder a otras secciones del servicio, la nueva pestaña abre con la pantalla de login.

Esto hace que el trabajo en swad esté reducido a una sola pestaña y lo hace mucho menos versátil.

Compilation fails due to missing files

Running a make clean && make all throws a compilation error due to missing files swad_file_extension.h and swad_file_extension.c in repository.

Error message:

make: *** No rule to make target 'swad_file_extension.o', needed by 'swad_ca'.  Stop.

make: *** Waiting for unfinished jobs....

swad_file_browser.c:45:10: fatal error: swad_file_extension.h: No such file or directory
 #include "swad_file_extension.h"
          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

make: *** [swad_file_browser.o] Error 1

How can I fix this?

I did all the steps of installation and showed up this page.

Can't build: "soap/soapH.h" is unavailable

Hi!

I'm trying to build SWAD and am getting this output when running make:

make
gcc -Wall -Wextra -mtune=native -O2 -s   -c -o swad_account.o swad_account.c
gcc -Wall -Wextra -mtune=native -O2 -s   -c -o swad_action.o swad_action.c
gcc -Wall -Wextra -mtune=native -O2 -s   -c -o swad_agenda.o swad_agenda.c
gcc -Wall -Wextra -mtune=native -O2 -s   -c -o swad_alert.o swad_alert.c
gcc -Wall -Wextra -mtune=native -O2 -s   -c -o swad_announcement.o swad_announcement.c
gcc -Wall -Wextra -mtune=native -O2 -s   -c -o swad_API.o swad_API.c
swad_API.c:101:10: fatal error: soap/soapH.h: No such file or directory
  101 | #include "soap/soapH.h"  // gSOAP header
      |          ^~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: swad_API.o] Error 1

There are no other files named *soap* in the project:

swad-core on  master [?] 
➜ find . -name "*soap*"
./soap

Am I doing something wrong or is this a missing header file that needs to be added? Thank you!

Utilizar menús html desplegables en lugar de recargar las páginas completas.

Por ejemplo en la página de archivos cuando quieres abrir una carpeta la página se recarga completa en lugar de simplemente expandirse.

Initial zoom when accessing mobile version in portrait orientation

The initial zoom to access the web from a mobile device in portrait orientation does not fit the device width. The user is forced to change the zoom to browse the web. If you switch to landscape orientation, zoom fits correctly in Firefox but not in Chrome.

If you access the web in landscape orientation the initial zoom is correct. If you switch to portrait orientation, zoom remains correct in Firefox but not in Chrome.

Browsers: Chrome, Firefox
Device: Google Nexus 6P, Android 7.0

Inexistencia de archivo robots.txt

El dominio swad.ugr.es no tiene archivo robots por lo que los motores de busqueda pueden inyectar enlaces de alto nivel

Stack overwrite in swad_group.c

The function bool Grp_CheckIfGroupBelongsToCourse (long, long) contains an array of char of size 128, the minimum size of the query is 141 (if both longs are replaced by 0), this will produce an stack overwrite.

As the size of parameters is probably limited in the input I doubt a possible shell injection or any method to gain access to the underlying system, just a DoS.

Unable to run sql script for installation

I have run into an error while running the swad.sql script

[alureon.anna] ~/code/c/swad-core/sql $ mysql -u swad -p < swad.sql
Enter password:
ERROR 1071 (42000) at line 700: Specified key was too long; max key length is 1000 bytes

I did some digging but I'm not sure why this error is happening.

Possible Errors

File: swad_mail.c:894
Problem: Variable StrAddresses is used without been initialized. This array is declared as

char StrAddresses[Mai_MAX_LENGTH_STR_ADDR + 1];

If it is not the first email a coma is appended but the first address will be appended to an array containing garbage.

The C standard ensures that at global scope or using static definition the value will be 0, but within a scope, the array must be initialized.

char StrAddresses[Mai_MAX_LENGTH_STR_ADDR + 1] = {0};

File: swad_mark.c:844
Problem: FILE* FileUsrMarks is getting closed twice.

File: swad_indicator.c:1398
Problem: Returning an uninitialized integer. The function Ind_GetNumIndicatorsCrsFromDB is returning the local variable NumIndicatorsFromDB that it may be Uninitialized if the DB_QuerySELECT fails.

File: Various.
Problem: fprintf and family are getting called with the %u string but the variable is a signed integer, this is not a big issue, but it may produce problems if the input comes from an user.

Wrong link in side banners

The right side banners are always pointing to https://openswad.org/es instead of pointing to the link related to the banner.

make fails due to missing swad_building.[c,h] files from repository

$ make
gcc -Wall -Wextra -mtune=native -O2 -s -c -o swad_account.o swad_account.c
In file included from swad_group.h:31:0,
from swad_file_browser.h:33,
from swad_assignment.h:31,
from swad_global.h:37,
from swad_account.c:42:
swad_room.h:30:10: fatal error: swad_building.h: No such file or directory
#include "swad_building.h"
^~~~~~~~~~~~~~~~~
compilation terminated.
: recipe for target 'swad_account.o' failed
make: *** [swad_account.o] Error 1

make fails due to missing swad_hidden_visible.[c,h] files from repository

Running a make clean && make all throws a compilation error due to missing files swad_hidden_visible.h and swad_hidden_visible.c in repository.

Error message:

gcc -Wall -Wextra -mtune=native -O2   -c -o swad_account.o swad_account.c
In file included from swad_user.h:39,
                 from swad_account.h:33,
                 from swad_account.c:33:
swad_icon.h:30:10: fatal error: swad_hidden_visible.h: No existe el fichero o el directorio
   30 | #include "swad_hidden_visible.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [<integrado>: swad_account.o] Error 1