acavella / gorevoke

A fully featured CDP and OCSP responder written in Golang.

I'm Tony, a senior infrastructure engineer by day. I live and breath enterprise linux, am a devops/automation enthusiast, a lifelong PKI student and homelab hacker. I am passionate about everything that is technology/open-source and am on a mission to constantly learn new things.

🗨️ Social Media

💻 Technology Stack

gorevoke's Issues

[Issue] Dockerfile copies to app to incorrect location

Operating system

any

Script Version

1.0.0-rc.3

Bug description

Dockerfile runner copies app to incorrect location.

Steps to reproduce

No response

Relevant log output

No response

[Issue] Relative paths broken

Operating system

any

Script Version

v.1.0.0-rc9

Bug description

Using relative paths leads to program using user's current working directory as the base path. Need to add a variable that fills in application's execution directory.

Steps to reproduce

No response

Relevant log output

No response

[Issue] App not starting at startup

Operating system

Docker

Script Version

v1.0.0-rc.5

Bug description

GoRevoke isn't starting automatically when container runs.

Steps to reproduce

No response

Relevant log output

No response

[Feature] Download Function

Feature description

A function to download CRL from destinations defined in config.

Suggested implementation

No response

Relevant code

No response

[Feature] Serve CRL via HTTP

Feature description

Respond to HTTP request and serve appropriate CRL based on CA ID.

Suggested implementation

No response

Relevant code

No response

[Feature] Disable built-in webserver

Feature description

Add config variable to enable/disable buit-in webserver.

Suggested implementation

No response

Relevant code

if server {
   go webserver(webport)
}

[Issue] File doesn't detect empty file properly

Build Type

Docker/Podman (Container)

Operating system

RHEL8-UBI

GoRevoke Version

1.1.2

Bug description

When the CA (source) is down, integrity checks continue to run on a non-existent file. The hash on the "new" file returns a 0 because no file exists. The next step proceeds and compares the 0 with an actual hash of the old file. It considers this a mismatch, meaning that a new CRL is present, even though there is no file.

Steps to reproduce

1. Ensure GoRevoke is running and has valid CRL files
2. Turn off / block the CRL source

Relevant log output

No response

[Feature] Upgrade Go version

Feature description

Upgrade Go from 1.20.12 to latest stable, 1.21.5

Suggested implementation

No response

Relevant code

No response

[Issue] Logger not returning CRL serial number

Operating system

Docker

Script Version

1.1.0

Bug description

Info logger isn't returning the CRL's serial number on validation.

Steps to reproduce

No response

Relevant log output

No response

[Issue] Path construction fails if binary is running in the root directory

Build Type

Docker/Podman (Container)

Operating system

RHEL 9

GoRevoke Version

v1.1.3

Bug description

If the gorevoke binary is located in / (e.g. when using a distroless container), the path construction for the CRL directory appends an extra / which results in an invalid path, ex //crl/tmp/x1.crl

The problem lines of code appear to be:

// When running in root, this causes "directory" to be set to "/"
directory, err := filepath.Abs(filepath.Dir(os.Args[0])) 

// Later, this will cause tmpfile to be set to "//crl/tmp"
var tmpfile string = workpath + "/crl/tmp/" + caid[i] + ".crl"

Steps to reproduce

Run gorevoke from /

Relevant log output

GoRevoke ver. 1.1.3
Build Type: Docker
Build Date: 20240712-0214
time="2024-07-12T15:39:32Z" level=info msg="CRLs in list: 5"
time="2024-07-12T15:39:32Z" level=info msg="Refresh interval: 15m0s"
time="2024-07-12T15:39:32Z" level=error msg="Problem opening downloaded file: open //crl/tmp/x1.crl: no such file or directory"
time="2024-07-12T15:39:32Z" level=info msg="Moving to next CRL entry."
time="2024-07-12T15:39:32Z" level=error msg="Problem opening downloaded file: open //crl/tmp/x11.crl: no such file or directory"
time="2024-07-12T15:39:32Z" level=info msg="Moving to next CRL entry."
time="2024-07-12T15:39:32Z" level=error msg="Problem opening downloaded file: open //crl/tmp/x12.crl: no such file or directory"
time="2024-07-12T15:39:32Z" level=info msg="Moving to next CRL entry."
time="2024-07-12T15:39:32Z" level=error msg="Problem opening downloaded file: open //crl/tmp/x2.crl: no such file or directory"
time="2024-07-12T15:39:32Z" level=info msg="Moving to next CRL entry."
time="2024-07-12T15:39:33Z" level=error msg="Problem opening downloaded file: open //crl/tmp/x21.crl: no such file or directory"
time="2024-07-12T15:39:33Z" level=info msg="Moving to next CRL entry."

[Feature] Add OCI Image Description

Feature description

Add Image description to Dockerfile

Suggested implementation

No response

Relevant code

LABEL org.opencontainers.image.description DESCRIPTION

[Issue] Dockerfile doesn't create appropriate directory on runner

Operating system

any

Script Version

v1.0.0-rc.4

Bug description

Dockerfile copies contents of gorevoke folder to /usr/local/bin/ without creating app directory.

Steps to reproduce

No response

Relevant log output

COPY --from=builder /usr/local/bin/gorevoke/ /usr/local/bin/

Should be:

COPY --from=builder /usr/local/bin/gorevoke/ /usr/local/bin/gorevoke/

[Feature] Docker Image

Feature description

Develop a Docker Image to deploy GoRevoke.

Suggested implementation

Dockerfile

1. Builder to pull from Github and build app (Golang / Alpine)
2. Runner (Red Hat UBI)

Relevant code

No response

[Feature] Parse YAML Config

Feature description

Ability to parse a YAML based configuration file to read user defined variables.

Suggested implementation

Go Module: github.com/spf13/viper

Should be able to loop through an undefined number of CLR download locations.
YAML configuration should include CA ID and associated download location for each CRL at minimum.

Relevant code

No response

[Issue] Logger returning \n instead of new line

Operating system

Docker

Script Version

1.1.0

Bug description

Info log is return \n instead of actual new line on validating CRL.

Steps to reproduce

No response

Relevant log output

No response

[Feature] Build Script

Feature description

Develop a shell script to perform build and deployment tasks on "builder".
Related #6

Suggested implementation

No response

Relevant code

No response

[Feature] Validate CRL

Feature description

CRL must be validated prior to replacing previous file; can be included in #2

Suggested implementation

No response

Relevant code

No response

[Issue] Remove "v" from version string on build

Operating system

any

Script Version

1.0.0-rc.3

Bug description

Dockerfile helper script pulls environmental variable (release tag) to assign version on build. Currently the tag includes "v" prepended to the semantic version number, e.g. v1.0.0

The leading "v" should be stripped from variable when used in build.

Steps to reproduce

No response

Relevant log output

# ./gorevoke
GoRevoke ver. v1.0.0-rc.2
Build Type: Docker
Build Date: 20240105-3622
INFO[2024-01-05T23:34:34Z] CRLs in list: 2
INFO[2024-01-05T23:34:34Z] Refresh interval: 15m0s
INFO[2024-01-05T23:34:34Z] Checking for new CRL(s)
...

[Issue] Failed download causes app to exit

Operating system

Docker

Script Version

v1.0.0

Bug description

A download failure causes the application to exit. This might be isolated to HTTPS trust issues. Need to test all failure scenarios to root cause.

Steps to reproduce

No response

Relevant log output

No response