GithubHelp home page GithubHelp logo

Comments (8)

jeromesimeon avatar jeromesimeon commented on August 28, 2024

I'm not sure I understand this issue. What's a monospace link?

from markdown-transform.

jeromesimeon avatar jeromesimeon commented on August 28, 2024

I'm not sure I understand this issue. What's a monospace link?

The commonmark spec has a notion of link, but nothing font-specific. https://spec.commonmark.org/0.29/#links

from markdown-transform.

irmerk avatar irmerk commented on August 28, 2024

Now that I think about it, maybe this is more of an issue for the markdown-editor. This is what I mean by monospace link:

Screen Shot 2020-02-10 at 8 55 47 AM

from markdown-transform.

jeromesimeon avatar jeromesimeon commented on August 28, 2024

This seems to be parsed and round-trip properly.

bash-3.2$ cat codeinlink.md 
this is a [`monospace link`](https://google.com)
bash-3.2$ markus normalize --sample codeinlink.md --output test.md
11:18:44 AM - info: Creating file: test.md
11:18:44 AM - info: 
this is a [`monospace link`](https://google.com "")

@jolene, what is the error you are getting?

from markdown-transform.

jeromesimeon avatar jeromesimeon commented on August 28, 2024

Some more investigation, the Slate transform does lose the inline code:

bash-3.2$ markus normalize --sample codeinlink.md --output test.md --slate 
11:29:28 AM - info: Creating file: test.md
11:29:28 AM - info: 
this is a [monospace link](https://google.com "")

from markdown-transform.

jeromesimeon avatar jeromesimeon commented on August 28, 2024

This issue isn't specific to code inlines inside links, but to anything other than a text node inside a link.

For instance, with emphasis:

bash-3.2$ cat test/data/linkem.md 
this is a [*code link*](https://google.com)
bash-3.2$ ../markdown-cli/index.js normalize --sample test/data/linkem.md --slate 
12:20:29 PM - info: 
this is a [](https://google.com "")

from markdown-transform.

jeromesimeon avatar jeromesimeon commented on August 28, 2024

This should be fixed with #171

bash-3.2$ cat test/data/linkem.md 
this is a [*code link*](https://google.com)
bash-3.2$ ../markdown-cli/index.js normalize --sample test/data/linkem.md --slate 
12:21:23 PM - info: 
this is a [*code link*](https://google.com "")
bash-3.2$ more test/data/linkcode.md 
more test/data/linkcode.md 
this is a [`code link`](https://google.com)

this is a `code snippet`
bash-3.2$ ../markdown-cli/index.js normalize --sample test/data/linkcode.md --slate 
12:22:25 PM - info: 
this is a [`code link`](https://google.com "")

this is a `code snippet`

from markdown-transform.

jeromesimeon avatar jeromesimeon commented on August 28, 2024

A more fancy test:

bash-3.2$ more test/data/linkmixed.md 
[This is a *link* with `code` and **bold**](http://google.com)
bash-3.2$ ../markdown-cli/index.js normalize --sample test/data/linkmixed.md --slate 
12:30:04 PM - info: 
[This is a *link* with `code` and **bold**](http://google.com "")

from markdown-transform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.