Method for retrieving full non-variable clause text from a clause node about markdown-transform

[DianaLease]

@DianaLease Can we consider this issue resolved?

Yes, works for me!

[jeromesimeon]

@DianaLease I don't think I was thinking straight last night, and after going down a rabbit's hole for a bit, I realised there is an easy way to get the clause text already:

Instead of going directly from CiceroMark DOM to CommonMark text with:

ciceroMarkTransformer.toMarkdown(clauseNode)

Instead generate the CommonMark DOM then get the text:

ciceroMarkTransformer.toCommonMark(clauseNode).text;

You should be able to test that. Let me know if it works, and I will then remove the clauseText field from the Clause node.

[jeromesimeon]

@DianaLease I don't think I was thinking straight last night, and after going down a rabbit's hole for a bit, I realised there is an easy way to get the clause text already:

Instead of going directly from CiceroMark DOM to CommonMark text with:

ciceroMarkTransformer.toMarkdown(clauseNode)

Instead generate the CommonMark DOM then get the text:

ciceroMarkTransformer.toCommonMark(clauseNode).text;

You should be able to test that. Let me know if it works, and I will then remove the clauseText field from the Clause node.

[DianaLease]

Recapping an outside convo here -
The above proposed solution produces the text but with the variable syntax still present. It would be useful to have a way to pass { wrapVariables: false } as an argument to the toCommonMark method, similar to how it can currently be passed to the toMarkdown method.
Scratch that. I was passing it as the second argument, but it works when passed as the third argument.

[jeromesimeon]

@DianaLease I don't think I was thinking straight last night, and after going down a rabbit's hole for a bit, I realised there is an easy way to get the clause text already:

Instead of going directly from CiceroMark DOM to CommonMark text with:

ciceroMarkTransformer.toMarkdown(clauseNode)

Instead generate the CommonMark DOM then get the text:

ciceroMarkTransformer.toCommonMark(clauseNode).text;

You should be able to test that. Let me know if it works, and I will then remove the clauseText field from the Clause node.

Adding the call to clarify what to do to get the text without variable tags:

ciceroMarkTransformer.toCommonMark(clauseNode, 'json', { wrapVariables: false }).text;

[jeromesimeon]

I have added a method to encapsulate the clause text extraction:

ciceroMarkTransformer.getClauseText(clauseNode, { wrapVariables: BOOLEAN })

This will:

1. regenerate the clause text (with or without wrapped variables)
2. remove single trailing new line due to code blocks encodings in CommonMark
3. raise an exception for non-Clause nodes

[jeromesimeon]

clauseText field from CiceroMark has been removed. Will ship with release 0.6.0

@DianaLease Can we consider this issue resolved?