acisops / acisfp_check

ACIS Focal Plane temperature prediction model

DEPRECATED!

acisfp_check has been merged into the acis_thermal_check repository. This repository is no longer functional and is only of historical interest.

Acis FP model as of MARch 25, 2016. Now adding this to the new ACIS repo:

acisops/acisfp_check

acisfp_check's Issues

Incorporate setpoint changes into the thermal model

The ACIS FP temperature setpoint is nominally set to -121 C, which results in a minimum temperature of approximately -119 C. This is changed by the issuing of WSFTNEG*** commands, e.g. WSFTNEG121. This happens during FP cooling tests and ECS measurements where we want specific temperatures, but it may be used more often in the future for other reasons.

In theory this could be tracked and incorporated in the ACIS FP thermal model to model these changes. However, we would prefer a way to store historical data about the setpoint changes instead of having to check all of the commands in a given time interval for WSFTNEG*** and then constructing the setpoint changes every time.

Places where we could store this for historical data:

• Commanded states database, with a new key like `fp_setpt
• A new (derived) MSID for the setpoint temperature
• A kadi event for when the setpoint changes?

This would take care of validation and model fitting, but we would always need a way to parse this command in the load when running load reviews.

@taldcroft @jeanconn any thoughts on the most straightforward but also least disruptive way to do this?

Unit tests fail on installed package

This is currently failing for the installed package, though it succeeds from the git repo:

import acisfp_check
acisfp_check.test()

...  many errors like this:

____________________ ERROR at setup of test_DEC0919A_viols _____________________
file /Users/aldcroft/miniconda3/envs/ska3/lib/python3.8/site-packages/acisfp_check/tests/test_acisfp_viols.py, line 7
  def test_DEC0919A_viols(answer_store, test_root):
E       fixture 'answer_store' not found
>       available fixtures: capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.

I think this is because the conftest.py module at the git repo root level is not getting packaged. Same applies for all the checkers.