aclonegeek / rummikub Goto Github PK

Adding R1 to {R2, R3, J} produces {R2,R3} rather than {R1,R2,R3,J}.

Melds and hands are printed separated by , when it should be a space.

Why? We decided to make the playBehaviour an observer, and it changes between Strategy1 and Strategy2. Bad idea.

To be done for the final submission.

• Ability to have 2 to 4 players
• Ability to have any player be a human or an AI (to which one of the 3 strategies of Iteration 1 can be assigned)

We're missing full test case coverage.

Game

• pretty much all of it, don't think this can be fixed though since it's reliant on user input

Meld

• removeTile (2/4 branches missed)
• removeTileObject (1/2 branches missed)

PlayBehaviour

• createPotentialMeldsFromHand (1/4 branches missed)
• playUsingHandAndTable (1/2 branches missed)

PlayerHuman

• play (all branches missed)

StrategyHuman

• determineInitialMove, determineRegularMove, handleInput (all branches missed)
• parseInput (like half of the branches missed)

Table

• isValidState (1/2 branches missed) - this is the only new one introduced by my last PR

                for (int j = 0; j < greatestMeld.getSize(); j++) {
                    hand.remove(greatestMeld.getTile(j));
}

and later:

        if (totalTileValue >= 30) {
            return this.workspace;
}

So if totalTileValue <= 30, the tiles are removed from the hand without being played.

Will fix in #61.

This is because the melds parameter that is passed in is a reference to the table's melds, so whenever you change the table melds then the player's workspace will change too. To avoid this, you need to make a copy of the incoming ArrayList. Here's an example:

this.workspace = new ArrayList<>(melds);

public void removeObserver(TableObserver player) {
    int i = players.indexOf(player);
    if (i >= 0) {
        players.remove(i);
    }
}

All possible branches of the if statement are not covered.

We should leave this until we have a working game.

if (largestMeldOver30 != null) {
    this.workspace.add(largestMeldOver30);
    return this.workspace;
}

The tiles should be deleted before returning the workspace. I have a fix cooked up.