acromedia / ansible-role-devops-utils Goto Github PK

aws --version | grep -qw 'aws-cli'

fails on (old) versions of awscli, which send the version string to stderr instead of stdout.

Is it possible to make this future proof, so any new version of PHP will "just work"?

The 'ls' test that the s3 uploader tries is lame. Even if permissions are good, and it would be able to write, the script stops.

A better test would be to actually try writing a file to the requested destination.

The acme challenges conf should be included from all nginx/apache configs, so that a non-ssl site has the option to register a cert and switch to SSL after the initial setup.

LetsEncrypt's certbot is now a snap binary; certbot-auto is no longer available if the server is up to date.

Functions are called before they're defined. See line 103, for example.

For example,

ll /home/webacct/www/project
/home/webacct/www/project -> /var/www/project 

acro-add-user.sh foo 
# Skipping /home/webacct because WEB_FILE_COUNT was zero: 0"

Result: User foo is added, but foo's key was not added to webacct's authorized keys, because the find command doesn't follow symlinks by default, and doesn't think webacct is used for websites.