acrosman / simple-project-estimates Goto Github PK

Not looking for anything fancy here. Probably as simple as some CSS to provide a passable print layout that could be saved to PDF.

Currently the graphs are rendered as SVG with D3 which browsers see as many small elements not an image and so the images cannot be directly saved. The tool should have elements to allow saving of images.

Obvious Options:

1. Switch to Canvas for rendering.
2. Add a mechanism to export the generated SVG to a file.

While not super meaningful, the tool should never fail under simple conditions. Right now if you put in a task list of length 1 you get fairly useless responses:

Task was 36-73 hours, price of $200

Result:
Median Time: 0
Likely Range: NaN - NaN
Max Time: 146
Min Time: 0
Standard Deviation: NaN

Median cost: $0.00
Likely Range: $NaN - $NaN
Max cost: $29,200.00
Min cost: $0.00
Standard Deviation: NaN

With no graphs.

Lots of console messages that read:
Error: <circle> attribute cy: Expected length, "NaN".

Expected all numbers in the chart to be positive.

When navigating by keyboard it would be good if after activating the new Task button the focus was shifted to the new task name control. Currently it requires using shift-tab several times to get to that field which is nearly always where you want to go next.

Babel Rewire is included in the project but not working properly during Jest testing (may be related to current ESM support setup). So to test internal functions of the simulation module they are being exported to the test class can reach them. Fixing the setup of Babel and Jest to allow these features to work would be better.

If you attempt a __get__() call in simulation.test.js you will get an error.

Replacing rewire with some alternate solution would be fine.

When you click "Run Simulation" if the number of iterations is very large it takes awhile, but there is nothing to indicate that it has responded. Some degree of greying out the button and showing a spinner of some kind would be helpful.

The graphs currently change modes with there is too much data to display in a bar chart. While this is necessary for many use cases the switch is driven by the graph's range not total number of data points. This can lead to some hard to read cost charts for simple projects. More experimentation is needed, but attempting to drive it by data points would be good, or adding a line in when there is a wide range but limited points would be an improvement.

The ReadMe file here is a little thin, it provides nothing about getting it setup and running (it's a simple HTML/JS setup so loading in a web browser is all that's really needed).

The code contains an old reference to jQuery 1.12. The project should be moved to jQuery 3 and retested.

While empty lines are not fed into the situation they can be distracting to users. It would be good to remove them entirely.

Jest is struggling to import D3 as ESModules, and throws errors. Currently D3 as been mocked out of the testing since we don't really need the graphs for testing, but it would be better to remove the mock and let D3 be imported properly.