Comments (20)
If you fork this repo, you have just one upstream.
If you're writing complex pull request, you do it in one place.
If you find bug which requires both loading and saving in specific order to reproduce, you report it in one place instead of guessing which one fits best or writing in both.
If you want to use older version for any reason, you set one sha instead of two. And if you want to move to newer, but still not-so-fresh version, you just update that sha instead of tracking which changes in repository A will work with repository B.
That's what we have now, with one repo.
I like the idea of controlling when exactly cache should be loaded/saved. But splitting repo for this is overkill. If that's what's needed to have more control (no idea honestly - not an actions writer yet, i stick to workflows for now), split load and save into two actions in separate folders which sounds like best of two worlds to me.
- uses: actions/cache/load
# ...
- uses: actions/cache/save
from cache.
Why not add argument instead?
- uses: actions/cache
with:
mode: load
# ...
- uses: actions/cache
with:
mode: save
from cache.
Dear bot, please keep this open.
Once this issue is solved, you will have plenty more cpu hours at your disposal to mark other issues as stale.
from cache.
Is there any update on this issue? I have a use case for it which would save me good 20 minutes of build time.
from cache.
If we were to implement this capability we would probably do it with an input as @wipe2238 suggests. Given the majority of cases don't need to deal with the complexity of two actions we don't want to force that on users and having three actions in the marketplace cache
, save-cache
, restore-cache
would be very confusing.
While not completely aligning with other verb-noun naming of actions I do think this would be the best compromise.
from cache.
In the end of the day it's just a slightly different syntax. The most important thing is to get the functionality itself, so we can better manage when caches are saved and restored. I'd appreciate an option to fine-tune it as well!
from cache.
from cache.
Not sure what that accomplishes. Also, AFAICT the official actions all start with verbs, because they're, well, actions.
from cache.
I'm not sure I like this idea either. It goes against the discussion in #94.
from cache.
@mrmckeb Actually, not splitting this action into two will introduce more config options, so splitting into two is better for #94, as the "cache" action will become explicit save-cache
/ restore-cache
actions (and no post
magic with an awkward step name).
from cache.
Hey everyone ๐๐ฝ
Two new actions actions/cache/restore and actions/cache/save are now available with tag v3
to everyone for use. These can now be used to achieve granular control on the restore and save steps in the cache action.
Do try them and give your feedback. We hope these new actions will take care of your use cases. ๐๐ฝ
Closing this issue now as we believe the new actions will take care of the same, feel free to reopen it if need be. ๐
from cache.
Given the majority of cases don't need to deal with the complexity of two actions we don't want to force that on users and having three actions in the marketplace cache, save-cache, restore-cache would be very confusing.
What's the actual use-case of this action when there are no separate save and restore steps? This can't be used to cache dependencies, for example, since you'd want to run the action before installing dependencies...but that would then create an empty cache hit for subsequent runs since the dependencies weren't yet installed.
from cache.
Doesn't keeping them as one action complicate things? As it is now, there's an implicit save-cache
happening on post
(if: success()
). It's best to make this explicit, i.e. requiring separate restore-cache
and save-cache
actions, and deprecate the cache
action.
from cache.
but that would then create an empty cache hit for subsequent runs since the dependencies weren't yet installed.
No:
As it is now, there's an implicit
save-cache
happening onpost
(if: success()
).
Lines 20 to 21 in 4b0709a
from cache.
Ah, gotcha, thanks. Having a mechanism for finer grained control (a la circleci) would definitely be nice though :)
from cache.
For anyone interested, I have an action built on top of action/cache
that allows you to run restore-cache
and save-cache
separately:
https://github.com/ktmud/cached-dependencies#speficy-when-to-restore-and-save
from cache.
This would definitely help for the use-case where you need to share some files between multiple jobs and you don't wan't to update the cache in some of them. The are also a lot of feature requests regarding the read-only mode and force update the cache. This will answer all these requests.
from cache.
This issue is stale because it has been open for 200 days with no activity. Leave a comment to avoid closing this issue in 5 days.
from cache.
This is too important to go stale. Commenting to help avoid staleness.
from cache.
Hey all, ๐๐ฝ
We have created a discussion with a proposal that we feel will solve this problem, do let us know your feedback, thanks ๐
from cache.
Related Issues (20)
- Shared from Copilot: Private Wealth
- `$HOME` in cache path doesn't work HOT 1
- How can I debug slow caches?
- `cache-hit` undefined on cache miss?
- `retention-days` key
- Document how cache scoping works with tags
- Master HOT 4
- โยฐยข
- Mobproductions
- https://github.com/guardianproject/proofmode-android.git
- Actions_task_jobsduties_
- Master
- ๏ปฟ2024-03-01T17:38:57.4236128Z ##[debug]Starting: Set up job Current runner version: '2.313.0' Operating System Runner Image Runner Image Provisioner GITHUB_TOKEN Permissions Secret source: Actions ##[debug]Primary repository: actions/cache Prepare workflow directory ##[debug]Creating pipeline directory: '/home/runner/work/cache' ##[debug]Creating workspace directory: '/home/runner/work/cache/cache' ##[debug]Update context data ##[debug]Evaluating job-level environment variables ##[debug]Evaluating job container ##[debug]Evaluating job service containers ##[debug]Evaluating job defaults Prepare all required actions ##[debug]Set step 'oncall' display name to: 'Get current oncall' ##[debug]Set step '__run' display name to: 'Request Review' ##[debug]Set step '__run_2' display name to: 'Add Assignee' Complete job name: run-action ##[debug]Collect running processes for tracking orphan processes. ##[debug]Finishing: Set up job
- Debug cache
- Find NIP#
- Find nip
- 15297251534 HOT 1
- ddm HOT 2
- Exclusions do not work HOT 2
- Cache Hit / Miss Rate Information
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cache.