prescale/frequency locked with Library reuse/wrapping of Adafruit 16-channel PWM/Servo about adafruit-pwm-servo-driver-library

[Bolukan]

I got your code working, including reading prescale value 105=>106*4096 (instead of 255) with the following three changes:

1. Add ESC:: to all wrapper functions in cpp:

uint8_t ESC::readPrescale(void)
{
	return myESC.readPrescale();
}

2. Only have default values for parameters in the definitions (.h) and not implementation (.cpp):
   void setPin(uint8_t num, uint16_t val, bool invert = false);
void ESC::setPin(uint8_t num, uint16_t val, bool invert)

3. Move the initiation of the myESC object to the initalisation of the ESC class:
   Adafruit_PWMServoDriver myESC = Adafruit_PWMServoDriver(oBoard); ->
   Adafruit_PWMServoDriver myESC;
   to the class initalisation:

	oBoard = I2C_Address;	// The I2C address on the TwoWire interface
	myESC = Adafruit_PWMServoDriver(oBoard);

And after these changes the code compiled and reported:

I2C Controller Test with ESC
255 Current Prescale value
 read Current Prescale value cleared
105 Current Prescale value

which is ok, because the first read was before myESC.begin();

ps: myESC.begin(>0) sets the external oscillator, which standard is not available.

[Bolukan]

I went through your code, but could not find the obvious fault. Please add 'return's in your wrapper

return myESC.getPWM(num);
return myESC.readPrescale();

and use myESC.readPrescale right after myESC.setPWMFreq(60) and myESC.speed(1064); and what do you get?

[photodude]

@Bolukan I made the requested changes (oops forgot those returns the first time ::facepalm:: )

I get a prescale of 255

I tried setting the frequency via serial parsing from the serial monitor, I still get a prescale of 255 every time

Expected frequency:: 60
Actual prescale:: 255
Expected frequency:: 55
Actual prescale:: 255
Expected frequency:: 2
Actual prescale:: 255
Expected frequency:: 1000
Actual prescale:: 255

I2C_control_Test.zip

[photodude]

@Bolukan I also tried setting the prescale in the begin(), in the sketch with myESC.begin(105);
still got 255 for the prescale.

My best guess is something is happening when the private library object is created in header and that something is what's locking the prescale/frequency valuse to 255.

[photodude]

Wholely smokes, I didn't even think to separate the library object Adafruit_PWMServoDriver myESC; in the header from the object initialization and put that in the CPP myESC = Adafruit_PWMServoDriver(oBoard);

I had previously tried moving the whole thing, but not separated. Absolutely brilliant.

It's working as expected with that one minor change (the other changes I had already done, but I guess I had uploaded an old version of the library from earlier attempt).

I can now change the frequency on the fly and it's working as expected. Thank you.
(probably should include this solution in some kind of guide)

[photodude]

I've updated the Forum discussion with the solution from here. Between this and the Forum (and following correct OOP design) anyone else who tries to wrap this library should be able to figure out what to do.

Closing as solution provided