adafruit / adafruit_tmp006 Goto Github PK

Product is discontinued:
https://www.adafruit.com/product/1296

The Wire.requestFrom() is a complete I2C transmission on its own. The Wire.beginTransmission() and Wire.endTransmission() should not be used there, they are used when writing data, not when requesting data.

Hi,

Looking through the code, I noticed something:

line 65: in Adafruit_TMP006.h
boolean begin(uint8_t samplerate = TMP006_CFG_16SAMPLE); // by default go highres
where TMP006_CFG_16SAMPLE is defined on line 51 as:
#define TMP006_CFG_16SAMPLE 0x0800

I believe this is problematic because of the large integer truncation that is happening. samplerate is defined as an 8bit unsigned integer: uint8_t samplerate but TMP006_CFG_16SAMPLE cannot fit into that size. The truncation will cause the default value in the begin function to be 0x00, ie, the same as TMP006_CFG_1SAMPLE which isn't problematic, but isn't the intended function.

The fix is simple: change the samplerate variable to be of type uint16_t
Can anyone confirm if this is a bug?

Thanks,
Robert

Hello Adafruit,

Don't have another way to contact you so doing it this way. I would love to include this library in Energia (http://energia.nu). I know it is open source and all but do want to ask your permission to keep things nice. I'll leave it as is so that the product page is in the Sketch and that it is named Adafruit_TMP006.

Thanks,
Robert@Energia

Would it be possible to support the power down mode?

Bits [14:12] MOD[2:0]: Mode of operation
000 = Power-down
111 = Sensor and ambient continuous conversion (MOD)

Initiating power-down has an immediate effect; it aborts the current conversion and puts the device into a low-power shutdown mode.