adamedgett / hubot-groupme Goto Github PK

You've got it truncating at 450 characters. The docs say the limit is 1000.

Also, currently, when splitting into multiple posts (for example 7 posts) the come a) out of order and b) some dont get sent/are missing.

Hey Adam,

Huge thanks to you for making this apapter! It's been a great help for me and I've loved working with it for my groupme @all project.

I've been away from hubot for a while, so this may not be an issue with your project at all, but that's as far as I was able to go. I've set environment variables correctly and modified your code to ensure that, so the token, bot ID, and room ID are all accessible to the groupme adapter.

For context, I'm trying to rewrite the project I mentioned earlier in vanilla ES2015 instead of coffee script, as well as update dependencies where needed. Before updating versions, I ran into some issues where the program had null messages and users, and was unable to function properly as the timer errored due to checking property of a null object, so I updated the major versions of everything. This is the new issue presented with latest groupme adapter and hubot.

Now, when running hubot with the groupme adapter, I run into this error immediately on startup. Any clue what's going on, or how I can further debug this?

Error: "value" required in setHeader("X-Access-Token", value)
  at validateHeader (_http_outgoing.js:502:11)
  at ClientRequest.setHeader (_http_outgoing.js:511:3)
  at new ClientRequest (_http_client.js:171:14)
  at Object.request (http.js:39:10)
  at Object.request (https.js:233:15)
  at GroupMeBot.get (/Users/hawkins/git/groupme-at-all/node_modules/hubot-groupme/src/groupme.coffee:133:39, <js>:186:23)
  at Adapter.get (/Users/hawkins/git/groupme-at-all/node_modules/hubot-groupme/src/groupme.coffee:1:1, <js>:3:61)
  at Adapter.GroupMeBot.getUsers (/Users/hawkins/git/groupme-at-all/node_modules/hubot-groupme/src/groupme.coffee:112:5, <js>:162:19)
  at Adapter.GroupMeBot.run (/Users/hawkins/git/groupme-at-all/node_modules/hubot-groupme/src/groupme.coffee:73:26, <js>:102:12)
  at Robot.run (/Users/hawkins/git/groupme-at-all/node_modules/hubot/src/robot.js:644:18)
  at Object.<anonymous> (/Users/hawkins/git/groupme-at-all/node_modules/hubot/bin/hubot.js:112:7)
  at Module._compile (module.js:569:30)
  at Object.Module._extensions..js (module.js:580:10)
  at Module.load (/Users/hawkins/git/groupme-at-all/node_modules/coffee-script/lib/coffee-script/coffee-script.js:211:36)
  at tryModuleLoad (module.js:466:12)
  at Function.Module._load (module.js:458:3)
  at Module.require (module.js:513:17)
  at require (internal/module.js:11:18)
  at Object.<anonymous> (/Users/hawkins/git/groupme-at-all/node_modules/hubot/bin/hubot:9:1, <js>:2:3)
  at Object.<anonymous> (/Users/hawkins/git/groupme-at-all/node_modules/hubot/bin/hubot:9:1, <js>:4:4)
  at Module._compile (module.js:569:30)
  at Object.exports.run (/Users/hawkins/git/groupme-at-all/node_modules/coffee-script/lib/coffee-script/coffee-script.js:103:25)
  at compileScript (/Users/hawkins/git/groupme-at-all/node_modules/coffee-script/lib/coffee-script/command.js:171:29)
  at /Users/hawkins/git/groupme-at-all/node_modules/coffee-script/lib/coffee-script/command.js:143:18
  at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:503:3)

Due to changes in how Groupme's bot API works, bots can only be assigned to a single room

The solution here may be to use a mapping of rooms to bot API keys

Hubot will continually respond to itself since it doesn't know it's Groupme bot name

Can you take a look at my code? I am not really good at debugging node yet. We need to modify the adapter so that it saves users into the "brain". Several external scripts aren't working because they need user awareness.

master...nitrag:master

I'm running my hubot instance on Heroku. It's coming up with a memory leak after 45 minutes of being started. No messages were posted in the group me room so hubot wasn't running anything. The only thing is the groupme adapter could have a memory leak? I'm not familiar with memory management in node. Can you take a look and see if the timer could be optimized and the messages nulled out after query? And maybe limit api query to last 5 messages? No way that there are going to be more than 5 posts to groupme room in 2 seconds.

Thanks!

There doesn't seem to be any options for doing user mentions, removing/adding users to groups, and adding images as attachments. Is there any way to put those in?