GithubHelp home page GithubHelp logo

calendar's People

Contributors

adamhoff avatar

Watchers

 avatar  avatar

calendar's Issues

Feedback

Project 2 Evaluation

Technical Requirements 2

  1. 0 Models, or partial CRUD on at least 1 model.
  2. At least 1 model incorporates GET, POST, PUT, and DELETE routes, but no associations.
  3. The app contains 2 models, with at least 1 association. At least 1 model is full CRUD.
  4. Includes many well-structured models, and advanced functionality such as authorization, 3rd-party API integration, or other technology not covered in class

Models, Migrations, & Associations

  • 2 models, day and month with Create, Read, Update, Delete for day

Routes

  • Uses resourceful routes and limits appropriately. Index and Show for Months, all routes for days.
  • The root: key here is out of place (you want root to: 'months#index') and causing an error

Controllers & Actions

Views

  • Good use of partials and only including necessary views (no utility of a day show page)

Misc

  • You had mentioned considering supporting arbitrary numbers of events per day rather than the four. Do you have a sense of how you'd go about implementing an event entity?

Creativity and Interface 2.5

  1. Zero or Minimal custom styles or interface. Evidence of scaffolded code
  2. The app is styled and has an interface of value to the end user: it is not just a nav bar and an index page
  3. The app displays a personal spin or creative element through its written language, functionality, purpose, and/or CSS.
  4. The app is fully responsive, incorporates outside technologies such as Flexbox. App incorporates modern UI themes, and adds unique flair.
  • Clearly a ton of time went into getting everything styled properly and creating an app like experience across page refreshes. Good use of flexbox and psuedo selectors.

Code Quality 2

  1. Minimal functional code is present
  2. Code lacks proper formatting, includes commented out, non-functional code, or otherwise contains major issues of quality (DRY, naming, etc)
  3. Code is well-formatted, well-named, and contains few style / quality issues
  4. No major code quality issues, makes use of Ruby best practices appropriately, and follows techniques such as separation of concerns, abstraction, and encapsulation
  • Everything seems tidy and conforming to best practices.
    Good use of partials for the day form.

Deployment and Functionality 1.5

  1. Application contains minimal functionality
  2. Application contains minimal functionality and contains major errors when used
  3. Application contains no major errors and is deployed
  4. App has advanced functionality that works with minimal errors, and may make use of advanced tools such as APIs, plugins, etc
  • App contains expected functionality but the deployed app doesn't seem to be up on heroku (link goes to a page saying the app doesn't exits).
    Think you demonstrated the deployed app so might be that it was deleted.
    You'll want that up to include in your portfolio.

Planning / Process / Submission 2

  1. No submission received, or submission does not contain basic documentation of planning (ERD, wireframes, commit history, etc)
  2. App is submitted, with basic evidence of planning. Documentation exists, but lacks common areas such as setup instructions, description of application functionality
  3. Submission contains clear evidence of planning, adequate documentation, include all from previous category, as well as additional information such as unsolved issues.
  4. Submission includes everything in previous category, as well as evidence of planning tools, such as Trello, and, incorporates workflows such as feature branching, code review, github issue / user story tracking, and justification of technical decisions.

Planning materials are present. The commit history is clean and reasonable navigable.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.