GithubHelp home page GithubHelp logo

Set color via single quotes about log HOT 4 CLOSED

adamschwartz avatar adamschwartz commented on September 21, 2024
Set color via single quotes

from log.

Comments (4)

craniumslows avatar craniumslows commented on September 21, 2024

I got to use back references :) 👍 c=(["'])(._)\1[c] the \1 matches the opening " or ' so it is still just 1 function

from log.

adamschwartz avatar adamschwartz commented on September 21, 2024

@craniumslows Thanks for the PR. But I'm starting to think perhaps we should forgo quotes altogether?

log "this is [c=color: red]#{someVariable}[c]"

Anyone forsee any issues with this? I think actually it's probably better since it simplifies the issue of allowing quotes in a url() delcaration:

log 'this is a [c=background-image: url("house.png"); text-indent: -999px]house[c]'

If it's possible to support ", ', and no quotes with a regex which does not degrade performance, I think we should support all three. Otherwise, I think we should support no quotes only and deprecate the old syntax. @artemeff @craniumslows Thoughts?

from log.

craniumslows avatar craniumslows commented on September 21, 2024

I think it wouldn't be too hard to summon appropriate regex. Good idea about the URLs.

from log.

craniumslows avatar craniumslows commented on September 21, 2024

Alrighty accepts no quotes or quotes. My PR if accepted should close out issues 10,11 and 12

from log.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.