adessoturkey / android-sample-app Goto Github PK

when opened the app first time, empty state doesn't shown to user. when user cancel search, empty state has to dissapear

Popular and now-playing movies&series should be stored locally first and synced remotely second.
The repository should be the single source of truth.

[CLONE] Create pipeline using Github actions

When we go to movie or tv show detail page vote average shown double form like vote average = 6.7965

We should implement view binding and replace it with data binding.

In a couple of recent projects, we have implemented Auth 2.0 solution for authorization. In all of these implementations, we had to implement a token refresh mechanism from scratch. So a sample refresh token mechanism for Auth 2.0 will be good for the boilerplate application.

We can migrate to StateFlow since it uses coroutines underhood and can offload read/write or mapping operations to threads.

We may implement it.

We can put shared preferences data into database if it is structural. Genres can be stored in database.

A NumberFormatException occurs when app tries to map an empty String into a List of Long values; since genreIds String can be an empty one.

Responsible Line: com.adesso.movee.internal.util.typeconverter.GenreConverter.fromString(GenreConverter.kt:10)

• Unit testing research for coroutines, viewmodel and livedata

We can rewrite sample-app with Jetpack Compose in a parallel branch.

In a recent project, we've required a drawer. So a drawer sample will be good to be implemented in the boilerplate application for future uses.

Pagination would be great for supported apis.

• Prevent multiple clicks on ui elements
• Build flow & application signing procedure
• Add a new feature to existing project
• EditText search-on-type (debounce) with coroutines
• Common extensions
• App-wide style settings (font family, button styles etc.)

enable user to add movies or tv shows to favourites list

We should implement dark theme.

Must

• Static code analyzer
• Formatter

Nice to have

• Code coverage support
• Analysis results in XML and/or HTML

• detekt, ktlint, spotless, and lint should be supported.

• All the tasks can be triggered separately via CLI

• The plugin can be written in Kotlin DSL or Groovy.

• The plugin should be published to Gradle Plugin Portal.

sample tutorial [medium.com]

custom plugin userguide [docs.gradle.org]

sample plugin [github.com]

We can implement instant apps.

We can add cast in movie detail page. It have already in tv show detail page.

[CLONE] Pull Request Template

We should use the most recent stable version of the dependencies.

[CLONE] Branching Strategy

CircleCI metadata badge seems broken. We can fix it and also add more badges & screenshots of the app to README like android-boilerplate project

why viewModelScope should be preferred