GithubHelp home page GithubHelp logo

pe's People

Contributors

adhy-p avatar

Watchers

 avatar

pe's Issues

[DG] UML violates standard

Sequence diagram

There should be a colon : before each class name on the sequence diagram.

Screenshot

image.png

[DG] Outdated DG

Outdated DG

Under manual testing, it shows that can delete the user by its index. Not mentioned in UG nor the actual program itself.

Screenshot

image.png

[Bug] List command does not show patient's appointment

List command does not show patient's appointment

The behavior of list command is different from the User Guide. It says that list is used to view patient's appointment while the app shows the list of patients instead.

Steps to recreate

  1. Invoke list command

Expected

(According to UG) view patient's appointment

Actual

Prints the list of patients

Screenshot

image.png

[DG] User stories

User stories

It says that the admin wants to retrieve the patient's details to schedule the appointment. But, both retrieve and book requires the admin to know the NRIC (and only NRIC is required) beforehand. Thus, the retrieve serves nothing to help the admin to schedule an appointment.

image.png

[Bug] Program crashes when user modify the save data externally

Program crashes when user modify the save data externally

The program does not handle the case where the save data saved by the user is in the wrong format. The user may accidentally type 2020-13-10 when trying to change the month to 12 (December), causing the app to crash.

Steps to recreate the bug

  1. Add a patient
  2. Exit the program
  3. Edit the data file such that the date is in the wrong format
  4. Restart the app

Expected

The program will skip the faulty data when parsing

Actual

image.png

[DG] Overly-complicated diagram

Complete class diagram

The class diagram is too complicated, the size is too small to be seen without magnification.

Screenshot

image.png

[UG] No expected output for all commands

No expected output for all commands

There is no screenshot on the expected output of the commands, making it impossible to tell whether the application is working correctly or not

Screenshot

image.png

[Feature flaw] Appointment does not specify the doctor

List command does not show patient's appointment

In real life scenario, it is hard to see how this app can benefit the user if they can only see the date of their appointments but not the doctors.

Steps to recreate

  1. invoke appointments

Expected

Prints both the date and the doctor (similar to editappt)

Actual

Only prints the date

Screenshot

image.png

[Bug] Faulty NRIC data is accepted if the save data is edited manually

Faulty NRIC data is accepted if the save data is edited manually

An expert user may want to edit the data directly from the save file instead of using the program. In this case, if the user made a typo, they will not be able to access that particular user again because when the user tries to edit/assign/anything, as the program does not accept invalid NRIC.

Steps to recreate

  1. Add a user to the database
  2. Exit the program
  3. Edit the save file manually
  4. Reopen the application
  5. Try to edit/book an appointment

Expected

The faulty data should be skipped during parsing and the user should be notified that there is a faulty data

Actual

image.png

[Bug] Duplicate appointment dates accepted

Duplicate appointment dates accepted

Theapplication shows a duplicate in the dates when 2 same dates are created

Steps to recreate

  1. create 2020-01-01
  2. create 2020-01-01
  3. editappt NRIC

Expected

Duplicate dates should not be listed as this application does not specify the time

Actual

Duplicate dates are listed

Screenshot

image.png

[Bug] Appointment numbering

Appointment numbering

The list should start form 1 instead of 2

Steps to recreate

  1. Edit appointment
  2. Change the date
  3. List the appointment

Expected

List starts from 1

Actual

List starts from 2

Screenshot

image.png

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.