adn-rb / adn Goto Github PK

Have done some more refactoring to extract the API URLs into constants.

Should we only run tests when a commit is made to master? Sometimes I am mid-branch and would like someone to have a look at a certain approach and sometimes that means all tests are not passing. Thoughts?

@kishyr You can follow the instructions on http://about.travis-ci.org/docs/user/getting-started/ to activate Travis CI for this repo (Very nice to get close to instant feedback on build failures)

I’ve already added an initial .travis.yml

1. We should take care not to introduce any more coupling between the classes.

The API classes have a clear separation of abstractions.

I want something like this:

require 'adn'

ADN.token = '…'

# Retrieving a user
kishyr = ADN::User.find(3089)
peter = ADN::User.find_by_username('peterhellberg')

# Retrieving a post
ADN::Post.find(313203)
peter.latest_post

2. Examples on where we need to improve the code:

• ADN.has_error? is just plain wrong in an OO design, the response object should take care of that.
• ADN.create_collection is another example, it doesn’t always return a collection and it has a strange second argument instead of being implemented as two separate methods.
• The methods (except the token, for now) in the ADN module should be moved into the API classes. We need to keep the top level clean from implementation details like HTTP request handling.

I have an organization here on GitHub: https://github.com/c7/

I’m thinking it would be pretty neat to have a ADN team which would have admin access to all the different project repos (adn, rack-adn, adn-rails, adn-cli).

Do you think it would be worth the effort to move the current repo?

By looking at the code of the gem, I don't see any code that supports authentication via user token (especially helpful when you are implementing a web app that wants to give users access to their adn account)

Are there any plans to implement this feature? otherwise I will try to wrap my head around it and would just implement it.