GithubHelp home page GithubHelp logo

adopted-ember-addons / ember-burger-menu Goto Github PK

View Code? Open in Web Editor NEW
280.0 9.0 47.0 5.91 MB

An off-canvas sidebar component with a collection of animations and styles using CSS transitions

Home Page: https://adopted-ember-addons.github.io/ember-burger-menu/

License: MIT License

JavaScript 60.86% HTML 2.62% Handlebars 13.82% SCSS 22.70%
ember ember-addon menu animations menu-animation burger-menu

ember-burger-menu's Introduction

ember-burger-menu

CI npm version

An off-canvas sidebar component with a collection of animations and styles using CSS transitions

Features

  • Easy to use & setup off-canvas menu
  • Mix and match from many menu & menu item animations
  • Swipe gesture support with changeable thresholds
  • Easily create your own animations

Compatibility

  • Ember.js v3.24 or above
  • Ember CLI v3.24 or above
  • Node.js v12 or above

Installation

ember install ember-burger-menu

Sass

Installing ember-burger-menu should also install ember-cli-sass and automatically create a scss file under app/styles/app.scss with

// app/styles/app.scss

@import 'ember-burger-menu';

Overriding Variables

Using sass, you can override default variables and easily change the default behavior of ember-burger-menu. See variables.scss for a list of variables you can change.

// app/styles/app.scss

// Burger Menu Overrides
$bm-transition-duration: 0.3s;
$bm-overlay-background: rgba(0, 0, 0, 0.7);

// Import all the styles!
@import 'ember-burger-menu';

Import Only What You Need

Using sass, you can import only the styles you need for the animations you use.

// Core Styles
@import 'ember-burger-menu/variables';
@import 'ember-burger-menu/structure';

// Animations
@import 'ember-burger-menu/animations/push';
@import 'ember-burger-menu/animations/menu-item/stack';

Helpful Links

Looking for help?

If it is a bug please open an issue on GitHub.

Animations

Menu Animations

  • slide
  • reveal
  • push
  • fall-down
  • open-door
  • push-rotate
  • rotate-out
  • scale-up
  • scale-down
  • scale-rotate
  • slide-reverse
  • squeeze

Menu Item Animations

  • push
  • stack

Usage

This addon utilizes contextual components to be able to correctly control and animate necessary elements.

{{#burger-menu as |burger|}}
  {{#burger.menu itemTagName="li" as |menu|}}
    <button {{on "click" burger.state.closeMenu}}>Close</button>

    <ul>
      {{#menu.item}}
        <LinkTo @route="features">
          Features
        </LinkTo>
      {{/menu.item}}

      {{#menu.item}}
        <LinkTo @route="about">
          About
        </LinkTo>
      {{/menu.item}}

      {{#menu.item}}
        <LinkTo @route="contact">
          Contact Us
        </LinkTo>
      {{/menu.item}}
    </ul>
  {{/burger.menu}}

  {{#burger.outlet}}
    <button {{on "click" burger.state.toggleMenu}}>Menu</button>
    {{outlet}}
  {{/burger.outlet}}
{{/burger-menu}}

Components

{{burger-menu}}

Options

  • open

    The current open state of the menu.

    Default: false

  • animation

    The menu animation. See Animations for the list of available animations.

    Default: slide

  • itemAnimation

    The menu item animation. See Item Animations for the list of available item animations.

    Default: null

  • position

    The menu's open position. Can either be left or right

    Default: left

  • width

    The menu's width (in px).

    Default: 300

  • locked

    Lock the menu in its current open / closed state.

    Default: false

  • customAnimation

    Override of the menu's styles with your own implementation. See Custom Animations for more details.

  • translucentOverlay

    Whether the outlet has a translucent overlay over it once the menu is opened.

    Default: true

  • dismissOnClick

    Whether the menu can be dismissed when clicking outside of it.

    Default: true

  • dismissOnEsc

    Whether the menu can be closed when pressing the ESC key.

    Default: true

  • gesturesEnabled

    Whether the menu can be open / closed using gestures. The only available gesture currently is swipe.

    Default: true

  • minSwipeDistance

    The minimum distance (in px) the user must swipe to register as valid.

    Default: 150

  • maxSwipeTime

    The maximum amount of time (in ms) it must take the user to swipe to be registered as valid .

    Default: 300

{{burger.outlet}}

This component is where all your content should be placed.

{{burger.menu}}

Everything rendered here will be inside the menu.

Options

  • itemTagName

    The default tagName that will be used by the {{menu.item}} component.

    Default: div

  • dismissOnItemClick

    Close the menu on click of a {{menu.item}}.

    Default: false

Actions

  • onOpen

    Triggered when the menu is opening

  • onClose

    Triggered when the menu is closing

{{menu.item}}

The individual menu item. This is required if you have specified an itemAnimation.

Options

  • dismissOnClick

    Close the menu on click.

    Default: false

The Menu State

The {{burger-menu}} component exposes multiple contextual components, but it also exposes a state object.

You can use the menu state object to modify pretty much any property.

  • open
  • width
  • position
  • animation
  • itemAnimation
  • customAnimation

The state object also exposes some actions:

  • open

    <button {{on "click" burger.state.openMenu}}>Open</button>
  • close

    <button {{on "click" burger.state.closeMenu}}>Close</button>
  • toggle

    <button {{on "click" burger.state.toggleMenu}}>Toggle</button>

Custom Animations

If you're not impressed with the in-house animations and want to create your own, all you have to do is pass the following class to the customAnimation property in the {{burger-menu}} component. If you think your animation would be a good addition to the existing collection, feel free to open a PR with it!

import Animation from 'ember-burger-menu/animations/base';

export default Animation.extend({
  // CSS class names to be able to target our menu
  animation: 'my-custom-animation',
  itemAnimation: 'my-custom-item-animation',

  container(open, width, right) {
    return {};
  },

  outlet(open, width, right) {
    return {
      transform: open ? right ? `translate3d(-${width}px, 0, 0)` : `translate3d(${width}px, 0, 0)` : ''
    };
  },

  menu(open, width, right) {
    return {};
  },

  menuItem(open, width, right, index) {
    return {
      transform: open ? '' : `translate3d(0, ${(index + 1) * 500}px, 0)`
    };
  }
});

Note: You don't need to worry about prefixing your CSS attributes as it will be done for you.

If you need to add some base CSS to your animation, you can target the menu as such:

.ember-burger-menu.bm--my-custom-animation {
  #{$bm-menu} {}
  > .bm-outlet {}

  &.is-open {
    #{$bm-menu} {}
    > .bm-outlet {}
  }
}

And the menu items as such:

.ember-burger-menu.bm-item--my-custom-item-animation {
  #{$bm-menu} {
    .bm-menu-item {}
  }

  &.is-open {
    #{$bm-menu} {
      .bm-menu-item {}
    }
  }
}

To use our new custom animation, all we have to do is pass the class to the customAnimation option in the {{burger-menu}} component.

import MyCustomAnimation from 'path/to/my-custom-animation';

export default Ember.Component.extend({
  MyCustomAnimation
});
{{#burger-menu customAnimation=MyCustomAnimation}}
  ...
{{/burger-menu}}

Contributing

See the Contributing guide for details.

ember-burger-menu's People

Contributors

alexdiliberto avatar dependabot[bot] avatar donaldwasserman avatar ember-tomster avatar greenkeeper[bot] avatar josemarluedke avatar knownasilya avatar mixonic avatar offirgolan avatar robbiethewagner avatar ttill avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ember-burger-menu's Issues

Support for Mobile Gestures

I would love to see some kind of support for mobile devices for gestures. There would probably need to be different options for what kind of gestures you support, if any, and the implementation would need to not get too weighty. The gestures I'd love to see are:

  1. swipe open
  2. swipe closed
  3. pan opened
  4. pan closed
  5. menu grab area threshold

An in-range update of ember-data is breaking the build 🚨

Version 2.12.2 of ember-data just got published.

Branch Build failing 🚨
Dependency ember-data
Current Version 2.12.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-data is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Release Notes Ember Data 2.12.2

Release 2.12.2 (April 12, 2017)

  • #4922 [BUGFIX release] restore internalModels GUID_KEY’s
  • #4917 [BACKPORT 4913] For release
Commits

The new version differs by 6 commits .

  • 27dbc11 Release Ember Data v2.12.2
  • 5262280 Update changelog for the 2.12.2 release
  • f96f948 [BUGFIX release] restore internalModels GUID_KEY’s
  • 111b774 Merge pull request #4917 from emberjs/for-release
  • e99b343 fix eslint
  • 971edd6 [BUGFIX canary] don't prematurely nullify props on the container-instance-cache

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

love the look and function of Ember Burger Menu!

but...I am a designer more than a developer. I know enough be dangerous tho, like dropping in css into my WP site or editing some html in spots.

but my question for offirgolan is, is there a layman's/noob guide for how a rank beginner (that would be me) would install this code on their WP site? (please)

Thanks for any help you can give.
Mark

An in-range update of ember-cli-qunit is breaking the build 🚨

Version 3.1.2 of ember-cli-qunit just got published.

Branch Build failing 🚨
Dependency ember-cli-qunit
Current Version 3.1.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-qunit is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Commits

The new version differs by 5 commits .

  • fb8127a 3.1.2
  • 1714541 Update CHANGELOG for v3.1.2.
  • 8adb7ab Merge pull request #173 from rwjblue/prevent-clobbering
  • 161ab87 Bump to node@4 in CI.
  • 893d0ff Prevent clobbering custom this.options.babel.

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of ember-cli-babel is breaking the build 🚨

Version 5.2.2 of ember-cli-babel just got published.

Branch Build failing 🚨
Dependency ember-cli-babel
Current Version 5.2.1
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-babel is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Commits

The new version differs by 5 commits .

  • 5526d86 5.2.2
  • cc9942a Merge pull request #108 from babel/add-annotation
  • 74c4723 Add more detailed annotation.
  • 10dc1cd Merge pull request #107 from twokul/patch-1
  • 54db09a Brocfile.js -> ember-cli-build.js

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

new ember sparks

so I just started learning ember and am mainly focused on front end dev...for some reason...I cant seem to set up all the files or set up the component well...could you please update the readme or maybe help me out with more instructions on how to set it up?

There is no css style included in the package

Hi Guys,
I followed the tutorial to use the code from here https://github.com/offirgolan/ember-burger-menu#usage and then replaced
<a class="icon-menu" {{action burger.state.actions.toggle}}></a>
with
<button {{action burger.state.actions.toggle}}>button</button>
since I don't have icon-menu class and without replacing it into button I can' see anything.
could someone please advise me what css classes and styles I need to add to be able to see the menu something like the one from here https://offirgolan.github.io/ember-burger-menu/
Because what I see now has absolutely no style at all and copying all the styles from think link https://github.com/offirgolan/ember-burger-menu/blob/master/tests/dummy/app/styles/app.scss totally mess up the whole application.

I really like the package, you guys did a great job but I am really straggling using it.

Problems with acceptance testing

Hi,

First of all, thanks for all the hard work on this great addon, it works great!

I'm having issues with opening the menu while writing acceptance tests. I tried pausing the test and opening the menu manually but it refuses to work on the acceptance test environment.

Maybe I'm missing something, but it seems it just doesn't work.

Documentation doesn't explain enough to get started

I'm getting an assertion error: "Assertion Failed: A helper named "burger.menu" could not be found".

This looks great, with plenty of options, but nothing that really explains how to use them. I don't know how to set options for the menu, even though your demo site has tons of options that you've already created and set up.

Is there any way to get some better documentation for the rest of it like you did for animations?

An in-range update of ember-cli is breaking the build 🚨

Version 2.12.0 of ember-cli just got published.

Branch Build failing 🚨
Dependency ember-cli
Current Version 2.11.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Release Notes le train à paris

Setup

  1. npm uninstall -g ember-cli -- Remove old global ember-cli
  2. npm cache clean -- Clear NPM cache
  3. bower cache clean -- Clear Bower cache
  4. npm install -g [email protected] -- Install new global ember-cli

Project Update

  1. rm -rf node_modules bower_components dist tmp -- Delete temporary development folders.
  2. npm install --save-dev [email protected] -- Update project's package.json to use latest version.
  3. npm install -- Reinstall NPM dependencies.
  4. bower install -- Reinstall bower dependencies.
  5. ember init -- This runs the new project blueprint on your projects directory. Please follow the prompts, and review all changes (tip: you can see a diff by pressing d). The most common source of upgrade pain is missing changes in this step.

Changelog

The following changes are required if you are upgrading from the previous
version:

Community Contributions

Thank you to all who took the time to contribute!

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Ember 2.15 Actions Not Found

I just upgraded my app to ember 2.15. The various burger.state.actions.<toggle | open | close> result in an undefined error:

Error: Assertion Failed: You specified a quoteless path, toggle, to the {{action}} helper which did not resolve to an action name (a string). Perhaps you meant to use a quoted actionName? (e.g. {{action "toggle"}}).

Reverting ember-source, ember-cli back to 2.14 seems to resolve this issue.

After trying to put together a pull request to fix this issue, i can't replicate it in the Demo app of ember-burger-menu, so now I'm not sure if this is a me problem or something else.

An in-range update of ember-cli-htmlbars is breaking the build 🚨

Version 1.2.0 of ember-cli-htmlbars just got published.

Branch Build failing 🚨
Dependency ember-cli-htmlbars
Current Version 1.1.1
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-htmlbars is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Commits

The new version differs by 5 commits .

  • fac427b 1.2.0
  • ee5bb76 Merge pull request #108 from ember-cli/pass-source-to-compilers
  • cae3b4f Allow AST plugins to access the raw template contents.
  • aa1b193 Merge pull request #106 from ember-cli/ci-deploy
  • caccae7 CI: Enable automatic NPM deployment for tags

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

JQuery warnings when swiping

Hello,
In Chromium, when I start to swipe the menu (and during the swiping), hundreds of warning are thrown in the console :

jquery.js:5445 Unable to preventDefault inside passive event listener due to target being treated as 
passive. See [https://www.chromestatus.com/features/5093566007214080](https://www.chromestatus.com/features/5093566007214080)
preventDefault	@	jquery.js:5445
touchMove	@	swipe-support.js:57
trigger	@	ember.debug.js:42833
...

As it is stated in chromestatus, preventDefault is no longer necessary and if a remove this call from the touchMove event in swipe-support.js, the warnings are gone ;-)

Error

//tempaltes/components/sidebar-c.hbs

{{#burger-menu as |burger|}}
  {{#burger.menu itemTagName="li" as |menu|}}
    <button {{action burger.state.actions.close}}>Close</button>

    <ul>
      {{#menu.item}}
        Новый ТИкет
        {{link-to 'Новый тикет' 'ticket.new' }}
      {{/menu.item}}

      {{#menu.item}}
        {{link-to 'Новый тикет' 'ticket.new' }}
      {{/menu.item}}

    </ul>
  {{/burger.menu}}

  {{#burger.outlet}}
    <button {{action burger.state.actions.toggle}}>Menu</button>
    {{outlet}}
  {{/burger.outlet}}
{{/burger-menu}}

//components/sidebar-c.js

import Ember from 'ember';

export default Ember.Component.extend({
  burgerMenu: Ember.inject.service(),

}
);

when i close menu i have error in console:

TypeError: this.removeEventListener is not a function
    at Class._teardownEvents (burger-menu.js:62)
    at invokeWithOnError (ember.debug.js:346)
    at Queue.flush (ember.debug.js:405)
    at DeferredActionQueues.flush (ember.debug.js:529)
    at Backburner.end (ember.debug.js:599)
    at Backburner.run (ember.debug.js:713)
    at Object.run (ember.debug.js:22690)
    at ActionState.handler (ember.debug.js:11928)
    at HTMLButtonElement.<anonymous> (ember.debug.js:42362)
    at HTMLBodyElement.dispatch (jquery.js:5206)

//package.json

`{
  "name": "test-app",
  "version": "0.0.0",
  "description": "Small description for test-app goes here",
  "license": "MIT",
  "author": "",
  "directories": {
    "doc": "doc",
    "test": "tests"
  },
  "repository": "",
  "scripts": {
    "build": "ember build",
    "start": "ember server",
    "test": "ember test"
  },
  "devDependencies": {
    "babel-cli": "^6.24.0",
    "broccoli-asset-rev": "^2.4.5",
    "ember-ajax": "^2.5.6",
    "ember-async-button": "1.0.2",
    "ember-burger-menu": "^1.1.1",
    "ember-cli": "^2.12.1",
    "ember-cli-app-version": "^2.0.0",
    "ember-cli-babel": "^5.2.4",
    "ember-cli-bootstrap-sassy": "^0.5.5",
    "ember-cli-dependency-checker": "^1.3.0",
    "ember-cli-eslint": "^3.0.3",
    "ember-cli-htmlbars": "^1.2.0",
    "ember-cli-htmlbars-inline-precompile": "^0.3.6",
    "ember-cli-inject-live-reload": "1.6.1",
    "ember-cli-moment-shim": "3.0.1",
    "ember-cli-qunit": "^3.0.1",
    "ember-cli-release": "^0.2.9",
    "ember-cli-sass": "^6.1.2",
    "ember-cli-shims": "1.0.2",
    "ember-cli-sri": "^2.1.0",
    "ember-cli-test-loader": "^1.1.0",
    "ember-cli-uglify": "^1.2.0",
    "ember-concurrency": "0.7.19",
    "ember-data": "^2.12.1",
    "ember-dialog": "3.0.0",
    "ember-export-application-global": "^1.0.5",
    "ember-font-awesome": "2.2.0",
    "ember-form-for": "2.0.0-alpha.15",
    "ember-i18n": "5.0.0",
    "ember-light-table": "^1.8.4",
    "ember-load-initializers": "^0.5.1",
    "ember-moment": "7.3.0",
    "ember-one-way-controls": "2.0.0",
    "ember-resolver": "2.1.1",
    "ember-responsive": "2.0.1",
    "ember-route-action-helper": "2.0.2",
    "ember-scrollable": "^0.3.5",
    "ember-side-menu": "0.0.13",
    "ember-simple-auth": "^1.2.1",
    "ember-source": "2.12.0",
    "ember-truth-helpers": "1.3.0",
    "ember-welcome-page": "^1.0.4",
    "emberx-select": "3.0.0",
    "loader.js": "^4.0.10",
    "phantomjs-prebuilt": "^2.1.14",
    "route-action": "1.0.0"
  },
  "engines": {
    "node": ">= 0.12.0"
  },
  "private": true
}
`

An in-range update of ember-data is breaking the build 🚨

Version 2.11.3 of ember-data just got published.

Branch Build failing 🚨
Dependency ember-data
Current Version 2.11.2
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-data is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Release Notes Ember Data 2.11.3

Release 2.11.3 (February 24, 2017)

  • 0ab7698 Do not assign modelName to the factory. Fixes error with ember-getowner-polyfill
Commits

The new version differs by 2 commits .

  • 170cec2 Release Ember Data 2.11.3
  • 0ab7698 Do not assign modelName to the factory. Fixes error with ember-getowner-polyfill

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

DEPRECATION: project.nodeModulesPath

Deprectaion warning
An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from: new NPMDependencyVersionChecker (/home/richipargo/Projects/Eucledian/eucledian-web/node_modules/ember-burger-menu/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:33)

Closure action not working with toggle

The following doesn't work:

<button type='button' onclick={{action onToggleMenu}}>
  Toggle
</button>

This does:

<button type='button' {{action onToggleMenu}}>
  Toggle
</button>

onToggleMenu is burger.state.actions.toggle

Add link from demo to Github

Awesome component! ⛵️

For simplicity you could add a link from the demo page to the Github page. I'm sure 95% can find it through a Google-search, but anyway :)

3D Transforms Break scrollTop and position: fixed

I stumbled across a really weird problem - when using e-b-m, I can't get scrollTop for my app - it always returns 0!!

I don't know how that's related to e-b-m, but I do know that when I tried to remove the "height:100%" I was using on my html/body elements, I could get scrollTop - but then my navbar ("position: fixed" - bootstrap) was suddenly not "fixed!"

(NOTE: I tried EVERYTHING to get scrollTop - document, html, body, even a container - nothing worked. NOTHING. All returned 0.)

This SO [https://stackoverflow.com/questions/14732403/position-fixed-not-working-for-header] indicates that 3D transforms were the problem. So, I implemented a custom animation for e-b-m that returned nothing for everything. The visuals indicated it worked - no transforms happened, but still, position: fixed was broken. I also tried resetting "transform: initial !important" on every element in the chain from the navbar up to html, but that didn't work either.

So, bottom line, the only way to get scrollTop and position: fixed BOTH working - remove e-b-m from my project. Which breaks my heart, because I love e-b-m!! Any ideas, anyone? How to "have it all"? position: fixed and a working $(window).scrollTop() value?

Problems with setup

Hey guys,

Was having trouble making this work in my project, so I decided to create a brand new 2.14 project to see if I can get it to work... and I still cannot.

What step am I missing?

I basically did:
ember new dummy
cd dummy
ember install ember-burger-menu
ember g template index

then I went into application template and pasted the code from the documentations (just changed the links to index):

{{#burger-menu as |burger|}}
  {{#burger.menu itemTagName="li" as |menu|}}
    <a {{action burger.state.actions.close}} class="icon-close"></a>

    <ul>
      {{#menu.item}}
        {{link-to 'index' 'index'}}
      {{/menu.item}}

      {{#menu.item}}
        {{link-to 'index' 'index'}}
      {{/menu.item}}

      {{#menu.item}}
        {{link-to 'index' 'index'}}
      {{/menu.item}}
    </ul>
  {{/burger.menu}}

  {{#burger.outlet}}
    <a class="icon-menu" {{action burger.state.actions.toggle}}></a>
    {{outlet}}
  {{/burger.outlet}}
{{/burger-menu}}

and went into index and pasted

Please show up hi from index

when I navigate to localhost:4200 I see a blank page with my sentence;
Bit confused on what am I doing wrong... I really would love to get this to work.

No error on console when I inspect

Thank you

An in-range update of ember-cli is breaking the build 🚨

Version 2.12.2 of ember-cli just got published.

Branch Build failing 🚨
Dependency ember-cli
Current Version 2.12.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/offirgolan/ember-burger-menu/builds/224671792)

Release Notes Kema Kosassa

Setup

  1. npm uninstall -g ember-cli -- Remove old global ember-cli
  2. npm cache clean -- Clear NPM cache
  3. bower cache clean -- Clear Bower cache
  4. npm install -g [email protected] -- Install new global ember-cli

Project Update

  1. rm -rf node_modules bower_components dist tmp -- Delete temporary development folders.
  2. npm install --save-dev [email protected] -- Update project's package.json to use latest version.
  3. npm install -- Reinstall NPM dependencies.
  4. bower install -- Reinstall bower dependencies.
  5. ember init -- This runs the new project blueprint on your projects directory. Please follow the prompts, and review all changes (tip: you can see a diff by pressing d). The most common source of upgrade pain is missing changes in this step.

Changelog

The following changes are required if you are upgrading from the previous
version:

Community Contributions

Thank you to all who took the time to contribute!

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of loader.js is breaking the build 🚨

Version 4.2.0 of loader.js just got published.

Branch Build failing 🚨
Dependency loader.js
Current Version 4.1.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As loader.js is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build failed Details
Commits

The new version differs by 14 commits .

  • cc53069 release v4.2.0
  • 1a453d3 Merge pull request #104 from trentmwillis/redefine
  • 93478ef Improve redefinition scenarios
  • e289916 Fix test:dev command
  • 287a487 Merge pull request #105 from trentmwillis/clarify
  • cda1c29 Clarify prime comment
  • 562ecf1 Merge pull request #100 from jrowlingson/master
  • 6a9b916 remove petal references
  • b609262 Merge pull request #95 from chadhietala/heimdall-instrumentation
  • c49296d Instrument with heimdall
  • 453fe8c Merge pull request #97 from Turbo87/ci-deploy
  • 37fef79 CI: Enable automatic NPM deployment for tags
  • c4f0755 Merge pull request #96 from chadhietala/dict-registry
  • 8a34296 Use dict for registery and seen to avoid filling IC cache

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Remove usage of jQuery

HI there! Thanks for this project. It is awesome.

I would like to use this in one app that we don't want to ship jQuery and with the movement in the Ember itself to allow jQuery to be optional, it seems to be a great moment to think about that.

I would like to understand that ware the required changes needed to allow us to not use jQuery within this project.

I would be interesting to layout the required changes so someone could pick this up and do the work.

Thanks again for your work in this amazing project.

  • Remove usage of jquery in addon component [#109]
  • Remove usage of jquery event in triggerSwipeEvent test helper [#111]
  • Remove usage of jquery in tests [#111]

Help with setup

Hey guys,

Was having trouble making this work in my project, so I decided to create a brand new 2.10 project to see if I can get it to work... and I still cannot.

What step am I missing?

I basically did:

ember new dummy
cd dummy
ember install ember-burger-menu
ember g template application
ember g template index

then I went into application template and pasted the code from the documentations (just changed the links to index):

{{#burger.menu as |burger|}}
  {{#burger.menu itemTagName="li" as |menu|}}
    <a {{action burger.state.actions.close}} class="icon-close"></a>

    <ul>
      {{#menu.item}}
        {{link-to 'index' 'index'}}
      {{/menu.item}}

      {{#menu.item}}
        {{link-to 'index' 'index'}}
      {{/menu.item}}

      {{#menu.item}}
        {{link-to 'index' 'index'}}
      {{/menu.item}}
    </ul>
  {{/burger.menu}}

  {{#burger.outlet}}
    <a class="icon-menu" {{action burger.state.actions.toggle}}></a>
    {{outlet}}
  {{/burger.outlet}}
{{/burger.menu}}

and went into index and pasted

hi from index

when I navigate to localhost:4200 I see a blank page; but when I scroll down then I see my hi from index

Bit confused on what am I doing wrong... I really would love to get this to work.

Thank you
Alex

FastBoot compat

Starting a new app and using the template provided in the docs throws an error in FastBoot:

There was an error running your app in fastboot. More info about the error:
 ReferenceError: Element is not defined
    at eval (webpack://__ember_auto_import__/../ember-burger-menu/node_modules/matches-selector/index.js?:6:13)
    at Object.../ember-burger-menu/node_modules/matches-selector/index.js (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor.js:90226:1)
    at __webpack_require__ (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor.js:90139:30)
    at eval (webpack://__ember_auto_import__/../ember-burger-menu/node_modules/closest/index.js?:1:15)
    at Object.../ember-burger-menu/node_modules/closest/index.js (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor.js:90215:1)
    at __webpack_require__ (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor.js:90139:30)
    at Module.eval [as callback] (webpack://__ember_auto_import__/./tmp/ember_auto_import_webpack-staging_dir-9qB0145l.tmp/app.js?:16:42)
    at Module.exports (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor/loader/loader.js:106:1)
    at Module._reify (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor/loader/loader.js:143:1)
    at Module.reify (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor/loader/loader.js:130:1)
    at Module.exports (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor/loader/loader.js:104:1)
    at Module._reify (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor/loader/loader.js:143:1)
    at Module.reify (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor/loader/loader.js:130:1)
    at Module.exports (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor/loader/loader.js:104:1)
    at requireModule (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/vendor/loader/loader.js:27:1)
    at Class._extractDefaultExport (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/addon-tree-output/ember-resolver/resolvers/classic/index.js:408:1)
    at Class.resolveOther (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/addon-tree-output/ember-resolver/resolvers/classic/index.js:110:1)
    at Class.superWrapper (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-utils.js:428:1)
    at Class.resolve (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-application/system/resolver.js:133:1)
    at _resolve (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/container.js:885:1)
    at Registry.resolve (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/container.js:588:1)
    at Registry.resolve (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/container.js:592:1)
    at Container.factoryFor (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/container.js:144:1)
    at Class.factoryFor (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-runtime/mixins/container_proxy.js:45:1)
    at Class.componentFor (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-views/component_lookup.js:9:1)
    at lookupComponentPair (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-views/utils/lookup-component.js:34:1)
    at lookupComponent (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-views/utils/lookup-component.js:53:1)
    at RuntimeResolver._lookupComponentDefinition (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:7227:1)
    at RuntimeResolver.lookupComponentDefinition (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:7138:1)
    at CompileTimeLookup.lookupComponentDefinition (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:5049:1)
    at refineBlockSyntax (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:6990:1)
    at Blocks.compile (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/opcode-compiler.js:355:1)
    at /Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/opcode-compiler.js:203:1
    at Compilers.compile (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/opcode-compiler.js:40:1)
    at CompilableTemplateImpl.compile (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/opcode-compiler.js:810:1)
    at OutletComponentManager.getLayout (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:3641:1)
    at Object.evaluate (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/runtime.js:1287:1)
    at AppendOpcodes.evaluate (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/runtime.js:44:1)
    at LowLevelVM.evaluateSyscall (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/runtime.js:2755:1)
    at LowLevelVM.evaluateInner (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/runtime.js:2731:1)
    at LowLevelVM.evaluateOuter (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/runtime.js:2723:1)
    at VM.next (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/runtime.js:4802:1)
    at TemplateIteratorImpl.next (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/@glimmer/runtime.js:4883:1)
    at RootState.render (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:4556:1)
    at TransactionRunner.runInTransaction (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-metal.js:1231:1)
    at InertRenderer._renderRoots (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:4822:1)
    at InertRenderer._renderRootsTransaction (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:4854:1)
    at InertRenderer._renderRoot (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:4787:1)
    at InertRenderer._appendDefinition (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:4712:1)
    at InertRenderer.appendOutletView (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/ember-glimmer.js:4700:1)
    at invokeWithOnError (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/backburner.js:216:1)
    at Queue.flush (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/backburner.js:125:1)
    at DeferredActionQueues.flush (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/backburner.js:278:1)
    at Backburner.end (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/backburner.js:410:1)
    at Timeout.Backburner._boundAutorunEnd [as _onTimeout] (/Users/bwhitton/src/foo/tmp/broccoli_merge_trees-output_path-Ff6W8yJR.tmp/assets/backburner.js:372:1)
    at ontimeout (timers.js:482:11)
    at tryOnTimeout (timers.js:317:5)
    at Timer.listOnTimeout (timers.js:277:5)

Specifically this line from the matches-selector package, which is a required by closest:

var proto = typeof Element !== 'undefined' ? Element.prototype : {};

Which is intended to run in a browser environment only. I'm not exactly sure how, but can you wrap that closest import so that it only runs in fastboot land? This is a problem with the import, not the run-time code in this project. But I think it can be solved with a build-time adjustment.

An in-range update of ember-data is breaking the build 🚨

Version 2.12.0 of ember-data just got published.

Branch Build failing 🚨
Dependency ember-data
Current Version 2.11.3
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-data is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Release Notes Ember Data 2.12.0

Release 2.12.0 (March 13, 2017)

  • #4805 Don’t redefine findPossibleInverses for each _findInverseFor
  • #4808 Avoid mutating model factory in _modelForMixin.
  • #4810 [Fixes #4807] realize class + factory seperation
  • #4743 [BUGFIX canary] Fix _lookupFactory deprecation for Ember canary
  • #4765 [DOC] Make model.unloadRecord public (#4765)
  • #4792 [BUGFIX beta] revert deletion of filter that removed deleted model…
  • #4789 Do not access container if Ember.getOwner exists.
  • #4760 Update deprecate arguments (#4760)
  • #4698 [FIX backburner] Avoids spinning up unnecessary run loops via run.join
  • #4638 Update the API docs for snapshots
  • #4705 Underscores the already private store.reloadRecord method
  • #4663 Silence warnings and deprecations in the console during tests
  • #4642 Add API docs for the HasManyReference
  • #4706 Improved performance for findHasMany finder
  • #4684 Modernizes relationship containers
  • #4664 Upgraded IdentityMap and RecordMap
  • #4668 [PERF] use micro-queue
  • #4699 include related record on the complex test
  • #4688 Fixed a typo
  • #4685 [FEATURE ds-rollback-attribute] rename ds-reset-attribute
  • #4686 [FEATURE ds-improved-ajax] Disable feature
  • #4704 Factory cache
  • #4696 fix(benchmarks): benchmarks for store.query no longer included record…
  • #4691 [BUGFIX beta] Add blueprints for "ember-cli-mocha >= 0.12.0"
  • #4697 chore(benchmarks): benchmarks needed to time a few lookups for us to …
  • #4701 [PERF] flatten DS.Model to avoid multi-extend, expensive reopens, and extra mixin detection
  • #4702 Enable the ds-check-should-serialize-relationships feature flag
  • #4703 Removes store._adapterRun
  • #4716 [DOC canary] Updating CONTRIBUTING.md to use ember-twiddle as examples
  • #4718 [BUGFIX beta] Inverse null relationships should throw if model doesn't exist 3
  • #4734 [DOC] fix a couple of typos in model class docs
  • #4739 Removed id in urlForFindAll signature
Commits

The new version differs by 92 commits (ahead by 92, behind by 22).

  • fd06e1f Pull in loader.js from the dist directory instead of the lib directory (#4824)
  • 0f73468 Release Ember Data 2.12.0
  • 6395eb7 Update the changelog for the Ember Data 2.12.0 release
  • 04cbbb5 Release Ember Data 2.12.0-beta.4
  • 8511886 Update changelog for the 2.12.0-beta.4 release
  • 3637db8 [Fixes #4807] realize class + factory seperation
  • d7fbbad Don’t redefine findPossibleInverses for each _findInverseFor
  • ce95bb2 Avoid mutating model factory in _modelForMixin.
  • 14a75bc Release Ember Data 2.12.0-beta.3
  • b96685f Update changelog for Ember Data 2.12.0-beta.3
  • 83ca6e2 Merge pull request #4792 from runspired/2.12-beta-hotfix
  • d94a299 don't remove unpersisted deletes
  • 52028db Add a test for #4770
  • 4a71fea [BUGFIX beta] revert deletion of filter that removed deleted models when flushCanonical of hasMany was called
  • 315b31c Do not access container if Ember.getOwner exists.

There are 92 commits in total. See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Multiple menus with push animation

Is this possible?

I mean I can wrap two burger-menus. But is this a good idea? And is there a nicer solution?

{{#burger-menu
  animation='push'
  position='left'
  as |burger1|
}}
  {{#burger1.menu itemTagName="li" dismissOnItemClick=true as |menu|}}
      Left
  {{/burger1.menu}}

  {{#burger1.outlet}}
    {{#burger-menu
      animation='push'
      position='right'
      as |burger2|
    }}
      {{#burger2.menu itemTagName="li" dismissOnItemClick=true as |menu|}}
          Right
      {{/burger2.menu}}

      {{#burger2.outlet}}
        <a {{action burger1.state.actions.toggle}}>
          OPEN Left
        </a>
        <a {{action burger2.state.actions.toggle}}>
          OPEN Right
        </a>
      {{/burger2.outlet}}
    {{/burger-menu}}
  {{/burger1.outlet}}
{{/burger-menu}}

How could I use this with ember-elsewhere?

I'm wondering how hard it would be to set this component up inside an ember-elsewhere container that is rendered in place as opposed to the way the docs currently state to set it up?

I would like to be able to have this button to toggle a menu:

    <button
      class="global-navigation__button global-navigation__main-menu"
      data-test-main-menu-button=true
      {{action (toggle 'showMainMenu' this)}}
    >
      {{font-icon 'bars'}}
    </button>

{{#if showMainMenu}}
  {{to-elsewhere
    named='slideout-menu'
    send=(hash
      component=(component 'to-elsewhere/mobile-nav')
      isOpen=showMainMenu
      onClose=(toggle 'showMainMenu' this)
  )}}
{{/if}}

Using my elsewhere container:

{{#from-elsewhere name="slideout-menu" as |elsewhere|}}
  {{#if elsewhere}}
    {{#burger-menu as |burger|}}
      {{#burger.menu itemTagName="li" as |menu|}}
        <button {{action burger.state.actions.close}}>Close</button>
        {{elsewhere.component}}
      {{/burger.menu}}
    {{/burger-menu}}
  {{/if}}
{{/from-elsewhere}}

This is much more ideal because I can render a menu in-place from different parts of the app (I have different menu use-cases for certain things)

Does anyone know if this is possible w/current set up?

Thanks

Scrolling is janky on iOS

When using this on an iOS device, the scrolling seems a bit janky for the main content area. The hardware-accelerated scrolling is no longer there. I also notice that the typical iOS trick by tapping the iOS status bar to scroll all the way up to the top does not currently work.

Tested with iOS 10 in Safari and Chrome

I've done a bit of inspection myself and it seems like the problem originates from the height: 100vh; overflow: hidden; property on one of the components.

Animation type that doesn't cover or push contents off screen

It appears that each of the animation types either cover up the screen contents (slide) or push the contents off the screen (reveal). It would be great to have the ability for the content area to use up 100% of available space when the menu is opened and closed.

Win-IE11: console errors breaking application

Ran into a problem after I updated my application from v3.1.0 to v3.3.1 and then testing on IE11. When I did this, I first noticed there were certain parts of the app that didn't fully load and click event handlers were not working.

Digging into the console errors - Found that this is the PR causing the issue #109 - It's triggering console errors now Invalid Calling Object

❤️ removing jQuery but would still love the continued IE11 support here as it worked previously.

Some screenshots just running the demo page in a VM:

2018-08-22_18-13-01

2018-08-22_17-59-46

2018-08-22_18-01-58

Narrowed the issue down to here when it's executing matchesFn(selector)

An in-range update of ember-cli-app-version is breaking the build 🚨

Version 2.0.2 of ember-cli-app-version just got published.

Branch Build failing 🚨
Dependency ember-cli-app-version
Current Version 2.0.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-app-version is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Commits

The new version differs by 2 commits .

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

this.removeEventListener is not a function

First off, really appreciate the addon.

I'm intermittently receiving the error in the title (and picture below). It can be duplicated 100% of the time if ember-scrollable is installed (haven't looked into the relation there). The addons don't have to be in the same route for the issue to occur.

As a temp fix I changed lines 69-77 in burger-menu.js as I don't require dismissOnClick or dismissOnEsc.

_teardownEvents() {
    if (this.get('dismissOnClick')) {
      this.removeEventListener(this.$(), 'click', this.onClick);
      this.removeEventListener(this.$(), 'touchstart', this.onClick);
    }

    if (this.get('dismissOnEsc')) {
      this.removeEventListener(document, 'keyup', this.onKeyup);
    }
  },

image

My project (burger menu in the index route, ember-scrollable in the scrollable route.
https://github.com/dephora/ember-burger-menu-test

I've only tested this with 2.13

Access burger menu context from ember route?

I have a use case where I want to conditionally trigger opening and closing the menu during route transitions. Additionally, it would be nice to be able to send actions from components in nested routes up to the application to trigger opening and closing the burger menu.

From what I can tell, this seems like it is out of the scope of this add-on. Is this a correct assumption?

An in-range update of ember-cli is breaking the build 🚨

Version 2.12.1 of ember-cli just got published.

Branch Build failing 🚨
Dependency ember-cli
Current Version 2.12.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Release Notes Package managers all the way down

Setup

  1. npm uninstall -g ember-cli -- Remove old global ember-cli
  2. npm cache clean -- Clear NPM cache
  3. bower cache clean -- Clear Bower cache
  4. npm install -g [email protected] -- Install new global ember-cli

Project Update

  1. rm -rf node_modules bower_components dist tmp -- Delete temporary development folders.
  2. npm install --save-dev [email protected] -- Update project's package.json to use latest version.
  3. npm install -- Reinstall NPM dependencies.
  4. bower install -- Reinstall bower dependencies.
  5. ember init -- This runs the new project blueprint on your projects directory. Please follow the prompts, and review all changes (tip: you can see a diff by pressing d). The most common source of upgrade pain is missing changes in this step.

Changelog

The following changes are required if you are upgrading from the previous
version:

Community Contributions

Thank you to all who took the time to contribute!

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Compatibility with `ember-paper`

Hi there,

This is quite an amazing addon, currently no other one out there can match its looks and configurability.

Are you aware of any compatibility issues with ember-paper?

No matter what, I did not manage to have them play together. Tried it even with a clean configuration, i.e. only ember-paper installed and it seems like that paper stubbornly refuses to cooperate (or the other way around).

Style issue

Hi,
I've installed the plugin and go through all the setup include the @import 'ember-burger-menu' but the style is not getting applied. I'm using the latest ember version 2.14

An in-range update of ember-cli-qunit is breaking the build 🚨

Version 3.1.1 of ember-cli-qunit just got published.

Branch Build failing 🚨
Dependency ember-cli-qunit
Current Version 3.1.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-qunit is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
Commits

The new version differs by 7 commits .

  • f4cbeb9 3.1.1
  • f2f997c Merge pull request #170 from hidnasio/override-height-in-fullscreen
  • cbb2d8d Override height in full-screen mode
  • e9bd941 Merge pull request #167 from trentmwillis/rename
  • d3ea9cf Change addon name from Ember CLI QUnit to ember-cli-qunit
  • 3853663 Merge pull request #166 from Turbo87/ci-deploy
  • 5bc45cd CI: Enable automatic NPM deployment for tags

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Adding LESS files

Hi,
would it be possible to also have LESS stylesheets? I don't know (right now) how much work this would be, but I think having less available would be neat for users using Semantic UI or other LESS based frameworks.

Any thougts on this?

Burger icon not hidden when menu is opened

Unlike the demo page the burger icon isn't hidden when the menu is opened (the tag doesn't get a burger-hidden class). Is this added as a custom feature on the demo page? If so could this be added as an option?

Component not being displayed as it should

Hi, I tried using this addon in a fresh ember project and it didn't look right. I can see the some of the css being loaded.
None of the items are shown (they are in the html body, though). I'm wondering what I can do to make it work nicely like the demo. Thanks in advance!

App / addon version
Ember 2.17.0
Ember Data 2.17.0
Ember-cli 2.17.2
Ember-burger-menu 3.0.1

Steps to reproduce:

ember new  emberburger
cd emberburger
ember install ember-burger-menu
ember s

application.hbs

{{#burger-menu as |burger|}}
  {{#burger.menu itemTagName="li" as |menu|}}
    <button {{action burger.state.actions.close}}>Close</button>

    <ul>
      {{#menu.item}}
        menu1      {{/menu.item}}

      {{#menu.item}}
        menu2      {{/menu.item}}

      {{#menu.item}}
        menu3
      {{/menu.item}}
    </ul>
  {{/burger.menu}}

  {{#burger.outlet}}
    <button {{action burger.state.actions.toggle}}>Menu</button>
    {{outlet}}
  {{/burger.outlet}}
{{/burger-menu}}

Test

(I've tried adding links too and the result was the same)

Results:

  • Initial

screen shot 2017-12-27 at 12 29 39 pm

  • After click

screen shot 2017-12-27 at 12 29 48 pm

Can ember-burger-menu stays open?

Hi,
It is not an issue but just a question.

My requirements are to keep burger-menu open until the viewport hits sm (I am using bootstrap grid or flexi if that matters)

Is there any class which I can toggle to keep it open and burger-icon hidden and only close burger menu based on criteria?

Love it but I use jQuery and AngularJS. How to migrate

This is the best burger menu component I even see. But I'm working on an angular based application. It is quite easy to run jQuery inside angular app. I read a few about Ember.js. It is quite similar to angular. I dont know, whether I can load Ember.js into angular app. But it is definitively not a good idea. So do you have any suggestion, how to use this component into angular v1 app?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.