Installer job node labels should be configurable about ci-jenkins-pipelines

[hendrikebbers]

@M-Davies can you do a short review of this issue. I tried to add information to the description of this issue. I hope this can be a "good first issue" now :)

[AdamBrousseau]

The sign_build job is basically in the same boat as this except it only has 1 label (no fpm hardcode). Shall I add it to this issue or open another one?
https://github.com/AdoptOpenJDK/openjdk-build/blob/282058709909733381464dcb67b7f0d13dca4e13/pipelines/build/common/openjdk_build_pipeline.groovy#L237

Edit: Although, Mac and Win have some more things that could be parameterized. I will open another issue.

[M-Davies]

Sure. You are assigned 🙂 Let me know if you need any help at all

[Apurwa-Ghosh]

Hi, I am an Outreachy applicant. Can I work on this issue?

[andrew-m-leonard]

@AdamBrousseau is this relevant any more? thanks

[cornelia247]

@AdamBrousseau @smlambert can this be assigned to me?

[andrew-m-leonard]

@cornelia247 Currently waiting for @AdamBrousseau feedback as to whether this is actually required?

[AdamBrousseau]

I'm not sure if this is still relevant. We've worked around the hardcoded label by adding an if condition in our fork of the code. Adopt has since removed the code in question and revamped how they do linux installers.
Here is what we did to avoid the hardcode
https://github.com/ibmruntimes/ci-jenkins-pipelines/blob/ibm/pipelines/build/common/openjdk_build_pipeline.groovy#L656-L660

        def nodeFilter = "${buildConfig.TARGET_OS}&&fpm"


        if (buildConfig.VARIANT == "openj9") {
            filter = "**/*-j*_${buildConfig.ARCHITECTURE}_${buildConfig.TARGET_OS}_*.tar.gz"
            nodeFilter = "sw.os.${buildConfig.TARGET_OS}&&ci.role.packaging&&sw.tool.rpm"

[andrew-m-leonard]

Thanks @AdamBrousseau