adtools / abcsh

Amiga Bourne Compatible Shell – This project is based on pdksh, with the goal to bring a bourne (or POSIX) compatible shell to Amiga systems.

adtools

Repository for releasing compiled adtools archives

abcsh's Issues

CED crashes ABC-Shell

Sorry, I can’t submit a crashlog, AOS hangs to hard.
But it’s easily reproduced, just launch CED from inside ABC-Shell, and BOOM!

Reported by: *anonymous

Bogus internl memory error

Very occasionally but for some quirky reason almost everytime I run the perl test suit sh will emit an error stating:

freeing memory outside of block (corrupted?)

and bail out.

changhing line 315 in alloc.c:

from

    if (dp < &bp->cell[NOBJECT_FIELDS] || dp >= bp->last)

    to

     if (dp < &bp->cell[NOBJECT_FIELDS] || dp > bp->last)


     fixes this issue.

Reported by: Andy Broad [email protected]

Unresolved issues with configure scripts remain

Hello. I'm not sure if this relates to only abcsh or includes other components but the following issues remain whenever I run a configure script:

1. Cannot deal with spaces on path names. Simple test is to work from the "RAM Disk" which it cannot handle because of the spaces. This causes problems with path substitution.
2. Even without spaces in path, path substitution still breaks. Indicated buy a failed if "[" construct.
3. Fails to locate obvious files like a "Makefile.in" which exists.
4. Cannot create "dual" files. It's common for a configure script to create a "config.h:config". This will cause it to look for a "config.h:" device because of the colon.

This is a show stopper when trying to port software to OS4. Including software already ported. For example GDB patched for OS4 always breaks but I am unable to cross compile as that breaks as well so for me this is a total showstopper.

colours

various colour otions for dirs, commands and so on

Reported by: *anonymous

Parameter substitution not supported

the following doesn't work while the pdksh manual says it is supported :

${variable/pattern/string}

whatever is in pattern and string, the error message is always "bad substitution"

Reported by: pferrucci

AmiUpdate installer broken for abc-shell

abc-shell 52.10 has a borked autoinstall script, used by amiupdate.

File downloads, on install gives following error:
IF: MISSING ELSE OR ENDIF

This is on current amiupdate as of today, with OS4 final + July update.

Reported by: wegster

"CED crash" crashlog

As I can't add information to the original bug, which is:
https://sourceforge.net/tracker/?func=detail&aid=1477829&group\_id=124336&atid=699222

Attached is the crashlog when I run CED from within sh

Reported by: pferrucci

CppCheck findings

Checked the project with CppCheck and some issues were found. Results attached.

findings.txt

http://cppcheck.sourceforge.net/

Incorrect redirection to some non normalised paths

The following fails

echo "# dummy" >././.deps/somefile.Po

with an error

sh: cannot create ././.deps/somefile.Po: No such file or directory

however

echo "# dummy" >./.deps/somefile.Po

succedes
clearly abc-shell is having a problem with the non normalised "././" prefix

This often prevents correct creation of deps files in some configure scripts

Reported by: Andy Broad [email protected]

abc-shell 0.1.8 show a requester when use test command

abc-shell 0.1.8 show a requester when use test command
in a shell script:

if test /proc
echo hi
fi

shown a “Insert proc: in any drive”

this doesn’t happens with the previous versions

Reported by: afxgroup

assign-mount requester disable

an option for disabling assign-mount requesters.

[email protected]

/frak

Reported by: *anonymous

Bug in processing already quoted arguments

There is a bug which causes abc-shell to fail on the following code:
apr_bundled_major="sed -n '/#define.*APR_MAJOR_VERSION/s/^[^0-9]*\([0-9]*\).*$/\1/p' \"/Work/Programming/subversion-1.6.12/apr/include/apr_version.h\""
(this if from subversion's configure. In this form i placed it to a separate file and used for debugging).
Note that file name is already quoted. When sed is run, file name changes to"
""/Work/Programming/subversion-1.6.12/apr/include/apr_version.h""
This causes sed to receive additional pair of quotes as part of file name (since they get escaped by *). And of course it can't find the file.
I found this bug when tried to port Subversion to AROS. I fixed it by modifying contains_whitespace() function:
--- cut ---
static bool contains_whitespace(char *string)
{
int l = strlen(string);

if (!l)
return false;
/* If the string is already quoted, we should take it as it is */
if ((string[0] == '"') && (string[l-1] == '"'))
return false;
if(strchr(string,' ')) return true;
if(strchr(string,'\t')) return true;
if(strchr(string,'\n')) return true;
if(strchr(string,0xA0)) return true;
if(strchr(string,'"')) return true;
return false;
}
--- cut ---
May i get a developer access to this repository in order to sync up with AROS port?
P.S. Probably more fixes are to come because original configure file supplied with Subversion doesn't work at all. It says 'unterminated case'. I have to recreate it with autoconf. I've tested the file with bash under MinGW, it works.

Reported by: pfedin