aduth / dones Goto Github PK

When loaded but no tags found, show warning "No dones found"

To avoid cases where a tag is misspelled and causing it to always be offered as a suggestion, we might consider sorting tag suggestions to those which have been most recently used. The downside here is that alphabetical sorting can help for easier scanning of options. Alternatively, we could consider better patterns for resolving typo'd tags.

On the date screen, users with dones reported should always be shown before users who have not yet reported any dones for the day.

May already be working as intended, but following cases should be disallowed:

• Unique tags by capitalization
• Tags with invalid characters

Hello! Thank you for sharing this theme, it's great.

I have translated the theme into Russian, you'll find it here.

Doing this I realized that there is no localization string for DELETE button. Will you add it?

May want to style as flex with shrink property.

Likely regressed when base font size was increased.

Tested in iPhone SE.

When hovering dones of another user, a dashed underline appears indicating an effect as though the done is editable, when it is in-fact not. The underline should only be shown when hovering dones of the current user.

It's common to keep a Dones tab open in the background all day, or open multiple tabs of Dones. To keep up to date with dones added in other tabs (either by the current user or other users), it would be nice if updates were reflected automatically.

Options:

• Naive polling on an interval (one minute?)
• Live updates by websockets (difficult to support for all hosts?)
• Cross-tab communication using techniques like localStorage monitoring (e.g. crosstab, only works for updating current user dones)

Autofocus is a nice convenience for desktop navigation (navigate to Dones, start typing). However, for mobile devices where keyboard flyup occurs on focus, it can be very disruptive to navigation flow, particularly when navigating between Dones screens in the same tab.

Options:

• Only apply autoFocus on initial load of Dones (navigating to Tags and back to a date shouldn't necessary re-apply auto-focus)
• Detect software keyboard, touch support, viewport size to disable auto-focus
  • Not always 100% reliable

Slack has a nice behavior where adding a message, then proceeding to press the "Up" arrow, gives you the opportunity to edit this message. This is useful in situations where one wants to make revisions after having already submitted the message, without needing to leave the keyboard flow.

Dones should support this behavior: Pressing the "Up" arrow from the dones input should start editing the most recently added done.

Optionally, pressing Up from the beginning of the input of a done being edited should transition editing to the prior done.

If a POST, PUT, or DELETE request is in-flight while a user attempts to close the tab or navigate off-site, a prompt should be shown to inform the user that data loss may occur if they do not allow the request to complete.

Prior art:

• https://github.com/WordPress/gutenberg/blob/master/editor/unsaved-changes-warning/index.js

Possible implementation:

• Track request-in-progress state in store
• Provide selector isRequestInProgress (optional request type by method?)
• Add and remove beforeunload listener with prompt respectively by request in and not in progress

Track tags unapplied and dones removed to ensure existing tags match dones that exist.

For usability: In case user assigns tag with typo, then changes.

Currently when typing a tag, letter case is strictly applied in filtering available options. Filtering of tags should be case-insensitive.

While loading, show placeholder on /tags/:tag route.

Currently default to site time, but users may want to set to their own local time instead for today's date.

Currently the calendar date picker is a bit of a black box so far as inferring whether dones have been reported on a specific date. Would be nice to add some indicator for each date reflecting whether (and how many?) dones are reported for that day.

Since each page of a tag detail listing can vary in height, it is very difficult to navigate quickly between multiple pages of tags using a cursor, since the user would need to relocate their cursor to the readjusted button position after each click. Moving the pagination to above the listing would allow the button to remain in a predictable position.

Related: #4

Be more permissive in allowing tags to include emoji characters.

Steps to reproduce:

1. Start typing a tag which has more than one suggestion
2. Key down to the second suggested tag
3. Continue typing the first suggested tag

Expected result:

When tag suggestions reduce to a subset, the selected offset should either reset to the first item, or at least to the new maximum number in the set.

Actual result:

The selected suggestion gets cut off, and it is no longer possible to select a suggestion via keyboard (without backspacing and manually moving suggested index back up to first).