GithubHelp home page GithubHelp logo

bootlaces's People

Contributors

alandipert avatar allentiak avatar danielsz avatar daveyarwood avatar gfzeng avatar malabarba avatar martinklepsch avatar micha avatar pleasetrythisathome avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bootlaces's Issues

Path overlap error thrown on push-snapshot

boot build-jar push-snapshot
clojure.lang.ExceptionInfo: Assert failed: The :source-paths, :resource-paths, and :asset-paths must not overlap.
                            (empty? (set/intersection paths parents))
    data: {:file
           "/var/folders/fq/_rst8fw93jl0dqjsc3vhqzrh0000gn/T/boot.user4186625119410084883.clj",
           :line 11}
  java.lang.AssertionError: Assert failed: The :source-paths, :resource-paths, and :asset-paths must not overlap.
                            (empty? (set/intersection paths parents))
  boot.core/assert-disjoint                          core.clj:  619
               boot.core/fn                          core.clj:  625
                        ...
    clojure.core/partial/fn                          core.clj: 2495
                        ...
         clojure.core/apply                          core.clj:  632
     clojure.core/update-in                          core.clj: 5923
                        ...
         clojure.core/swap!                          core.clj: 2241
                        ...
         boot.core/set-env!                          core.clj:  661
                        ...
         clojure.core/apply                          core.clj:  630
       boot.core/merge-env!                          core.clj:  669
                        ...
adzerk.bootlaces/bootlaces!                     bootlaces.clj:   24
                        ...
          boot.user/eval961  boot.user4186625119410084883.clj:   11
                        ...
         boot.main/-main/fn                          main.clj:  192
            boot.main/-main                          main.clj:  192
                        ...
           boot.App.runBoot                          App.java:  390
              boot.App.main                          App.java:  467
                        ...
                  Boot.main                         Boot.java:  258

build.boot: https://github.com/talexand/hallo-color/blob/master/build.boot

Hardcoded "src" path added to :resource-paths

Hi,
It seems that in function bootlaces! hardcoded value "src" is always merged with resource-paths with no respect to actual env set for sources. e.g.
If we have for example following configuration:
:source-paths #{ "src/main/clj" "src/main/cljs" }
Then after 'build-jar' all jar entries will be as follows : "main/clj/namespace/file.clj or main/cljs/namespace/file.cljs but should be /namespace/file.clj /namespace/file.cljs

GPG signing fails but NullPointerException is thrown.

Please consider detailing the type of error that occurred.

Writing pom.xml and pom.properties...
Writing boot-environ-0.0.5.jar...
Installing boot-environ-0.0.5.jar...
Signing boot-environ-0.0.5.jar...
Daniel Szmulewicz (No comment) <[email protected]>
GPG passphrase: 
             clojure.lang.ExceptionInfo: java.lang.NullPointerException
    data: {:file "/tmp/boot.user5823046921378345498.clj", :line 35}
java.util.concurrent.ExecutionException: java.lang.NullPointerException
         java.lang.NullPointerException: 
                                ...                        
   mvxcvi.crypto.pgp.signature/sign     signature.clj:   23
                      boot.pgp/sign           pgp.clj:   45

I don't know why the signing fails. I am using a public key with multiple signing subkeys, could that be the problem?

GPG signing should be a configurable param? (breaks on Win)

Seems like it isn't. Now I tried making a GPG private key but it won't work from my Git Bash on Windows due to no tty.

Also, Clojars doesn't check GPG (anymore) - probably has something to do with lack of awareness amongst developers I would guess.

Anyway, should I want to use bootlaces on Windows, due to access modifiers / scoping, I am forced to implement my own push-release since I won't be able to simply override and change namespace references. boot.git last-commit is clean enough (one-liner), get-creds another one/two-liner. Finally collect-clojars-credentials also needs to be copied to the local build.boot file in order to simply be able to use :gpg-sign false. This is somewhat inconvenient.

Addition of a task parameter to push-release to flag to enable (or disable if true is to be the default) gpg-sign would make it much cleaner imho.

This is how I worked around the problem: https://github.com/robjens/boot-reframe-10x/blob/dc8466ddf36f53e29df0319a37eec9002b60e9dc/build.boot#L36

Bootlaces! adds non-existant src dir to :resource-paths

Maybe bootlaces! should check if directory exists?

This problem might be Linux specific:

~/Source/cljsjs/packages/react master*  
❯ boot build-jar
       clojure.lang.ExceptionInfo: src
    data: {:file "../tmp/boot.user2665707750335607618.clj", :line 21}
java.nio.file.NoSuchFileException: src
    file: "src"
 sun.nio.fs.UnixException.translateToIOException      UnixException.java:  86
          sun.nio.fs.UnixException.asIOException      UnixException.java: 111
sun.nio.fs.LinuxWatchService$Poller.implRegister  LinuxWatchService.java: 246
       sun.nio.fs.AbstractPoller.processRequests     AbstractPoller.java: 260
         sun.nio.fs.LinuxWatchService$Poller.run  LinuxWatchService.java: 329
                                             ...                             

GPG signing fails but NullPointerException is thrown.

Please consider detailing the type of error that occurred.

Writing pom.xml and pom.properties...
Writing boot-environ-0.0.5.jar...
Installing boot-environ-0.0.5.jar...
Signing boot-environ-0.0.5.jar...
Daniel Szmulewicz (No comment) <[email protected]>
GPG passphrase: 
             clojure.lang.ExceptionInfo: java.lang.NullPointerException
    data: {:file "/tmp/boot.user5823046921378345498.clj", :line 35}
java.util.concurrent.ExecutionException: java.lang.NullPointerException
         java.lang.NullPointerException: 
                                ...                        
   mvxcvi.crypto.pgp.signature/sign     signature.clj:   23
                      boot.pgp/sign           pgp.clj:   45

I don't know why the signing fails.

Creates tag before successful deploy

Bootlaces already creates the git tag before the deploy to clojars is successful. Should it fail, subsequent tries will fail due to the already-existing tag.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.