AElf - A Decentralized Cloud Computing Blockchain Network

BRANCH	AZURE PIPELINES	TESTS	CODE COVERAGE
MASTER
DEV

Welcome to AElf's official GitHub repo !

AElf is a blockchain system aiming to achieve scalability and extensibility through the use of side-chains and a flexible design. To support multiple use cases AElf makes it as easy as possible to extend/customize the system by providing easy to use tools and frameworks in order to customize the chains and write smart contracts. AElf will eventually support various languages that will let developers choose the one they are the most comfortable with.

For more information you can follow these links:

This repository contains the code that runs an AElf node, you'll find bellow other important repositories in the AElf ecosystem:

TOOL/LIBRARY	description
aelf-sdk.js	Javascript development kit for interacting with an AElf node, useful for dApp developers.
aelf-command	CLI tool for interacting with an AElf node and wallet.
aelf-boilerplate	framework for smart contract and dApp development.

Getting Started

This repository

This repo is where you will find the code that can use to run an AElf node. It also contains a tests folder that centralizes all the unit tests.

Documentation

We strongly recommend you follow official documentation that will guide you through installing dependencies and running the node, these two guides will get you started:

Contributing

If you have a reasonable understanding of blockchain technology and at least some notions of C# you can of course contribute. We also appreciate other types of contributions such as documentation improvements or even correcting typos in the code if you spot any.

We expect every contributor to be respectful and constructive so that everyone has a positive experience, you can find out more in our code of conduct.

Reporting an issue

We currently only use GitHub for tracking issues, feature request and pull requests. If you're not familiar with these tools have a look at the GitHub documentation.

Bug report

If you think you have found a bug in our system feel free to open a GitHub issue, but first:

check with GitHub's search engine that the bug doesn't already exist.
in the request give as much information as possible such as: the OS, the version of AElf, how to reproduce...

Missing feature

We also use the GitHub issue tracker for features. If you think that some piece of functionality is missing in AElf, you can open an issue with the following in mind:

check for similare feature requests already open.
provide as much detail and context as possible.
be as convincing as possible as to why we need this feature and how everybody can benefit from it.

Pull request

For any non trivial modification of the code, the pull requests should be associated with an issue that was previously discussed. During the time you implement and are not yet ready for review, prefix the PR's title with [WIP] and also don't forget to do the following:

add a description in the pull request saying which issue you are fixing/implementing.
be as explicit as possible about the changes in the description.
add the tests corresponding to your modifications.
pull requests should be made against the dev branch.

When you are ready for a review by the core team, just remove [WIP] from your PR's title and others will review. This will either lead to a discussion or to a refactor of the code. The Azure Pipelines CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit tests are run automatically. The CI passing is a pre-condition for the PR to be merged as well as the approval from the core team.

Versioning

We use Semantic Versioning (SemVer) for versioning, if you're intereted in closely following AElf's developement please check out the SemVer docs.

License

AElf is licenced under MIT

[bug] protocol message parser failed when running in multiple threads

An exception (sometimes) threw when we run the test case TxMemPool.IntergrationTest.StartMultiThread:

Google.Protobuf.InvalidProtocolBufferException : Protocol message contained an invalid tag (zero).

Later we found the position causing this failure is a method of ChangesStore:

        public async Task<Change> GetChangeAsync(Hash pathHash)
        {
            var value = await _keyValueDatabase.GetAsync(pathHash.Value.ToBase64(), typeof(Change));
            return value == null ? null : Change.Parser.ParseFrom(value);
        }

It seems like something went wrong with the Parser of Change (deep research shows Protobuf failed to ReadTag of input data). But before long we found a interesting/weird/upset solution: by slightly modifying the implementation of AccountContextService.SetAccountContext:

From

await adp.GetDataProvider().SetAsync(GetKeyForIncrementId(), accountDataContext.IncrementId.ToBytes());

await adp.GetDataProvider().SetAsync(GetKeyForIncrementId(), new UInt64Value
            {
                Value = accountDataContext.IncrementId
            }.ToByteArray());

Basically we put a ulong type to a protobuf type UInt64Value, so at first we thought the reason cased aforementioned failure is the stuff we tried to set to database ain't a protobuf type. But during the attempt to confirm our conjecture, we found that the code actually does not reach the interaction of database, also the logic of Change is none of its business.

That's why I have to record this situation as an issue as well as seeking for help.

aelfproject / aelf Goto Github PK

aelf's Introduction

AElf - A Decentralized Cloud Computing Blockchain Network

Getting Started

This repository

Documentation

Contributing

Reporting an issue

Bug report

Missing feature

Pull request

Versioning

License

aelf's People

Contributors

Stargazers

Watchers

Forkers

aelf's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs