afruitpie / convertify Goto Github PK

Users must uninstall and reinstall the app to log in to a different Spotify account to convert playlists

Hello,

I just tried to use your app to move my Spotify Playlist to Apple Music and I noticed that some Playlists were cut off somewhere in the middle. So I came here to see what the issue is. I noticed that the playlists are always cut after 100 songs and that Spotify's response JSON literally a parameter called limit. So I went to the Spotify Dev Documentation and it said that all requests are limited to 100 items max. If we want more, we should use the offset parameter. I already fixed it, however I don't have a Apple Developer Enrolment and thus can't sign into my Apple Music Account :(
So instead of just keeping the fix to myself, I thought I would notify you about it.
Here is everything that needs to be adjusted:
In SpotifyPlaylistSercher.getTrackPlaylist:

AF.request("https://api.spotify.com/v1/playlists/\(playlistID)/tracks", headers: headers)

to

AF.request("https://api.spotify.com/v1/playlists/\(playlistID)/tracks?offset=100", headers: headers)

The offset is correct like this. Songs start at 0, so if you set the offset to 100, It will send with the 101st song.

The application will continue to say it is converting even if the user denies access to their library.