agap / picassos3 Goto Github PK

Your disk cache has a bug.

public InputStream get(@nonnull final Uri uri)

Closes the input stream before Picasso can decode the bitmap.

You need to remove snapshot.close() in the finally clause for this to work.

after adding your library to my project i use below code snippet

new Picasso.Builder(MainActivity.this).downloader(new S3Downloader(MainActivity.this, s3Client, bucket))
.build()
.load("https://s3-eu-east-5.amazonaws.com/music/Music_3.jpg")
.noFade()
.placeholder(R.drawable.img_placeholder)
.memoryPolicy(MemoryPolicy.NO_CACHE)
.networkPolicy(NetworkPolicy.NO_CACHE)
.into(imageView);

with above code snippet image is loading in imageview but it works only first time after installing app and after that it's not loading the url image.

Unfortunately you are handling the removal of the latch incorrectly by placing this line:

if (bytesCurrent == bytesTotal)

in onProgressChanged. This won't work correctly because sometimes the initial call by the Transfer manager gives the total as 0 out of 0 bytes which in turn means you are removing the latch and returning a file of 0 bytes in size, even though the download has not completed, which in turn causes Picasso to either retry the download or fail, depending on how fast the retry is.

You need to handle the latch countdown in onStateChanged(). This method reports when the download has completed or has been cancelled.