agrc / amdbutler Goto Github PK

If I have jshint overrides at the top of a file I get a parse error and no Butler functions work:

Could also listen for new file events and add those to the list.

Crawl on project start up.

http://docs.travis-ci.com/user/multi-os/

Don't forget to update readme build status table.

Grunt bump
At least a build_steps.md that shows what you need to do.

The preference in AmdButler.sublime-settings is named amd_packages_base_path but is referenced as amd_butler_packages_base_path in amdbutler.py.

OSX is speedy but windows takes more than a few seconds to crawl on a larger project.

This looks promising: https://github.com/benhoyt/scandir

But want to wait for dependency management with package control v3 first.

Remove _TemplatedMixin from this:

define([
    'agrc/modules/HelperFunctions',

    'dijit/Dialog',
    'dijit/_TemplatedMixin',
    'dijit/_WidgetBase',
    'dijit/_WidgetsInTemplateMixin',

    'dojo/_base/array',
    'dojo/_base/declare',
    'dojo/_base/lang',
    'dojo/io/script',
    'dojo/json',
    'dojo/text!app/templates/Feedback.html',

    'esri/layers/ArcGISTiledMapServiceLayer',
    'esri/map',

    'ijit/widgets/notify/ChangeRequest',

    'dijit/form/Button',
    'dijit/form/Form',
    'dijit/form/RadioButton',
    'dijit/form/Textarea',
    'dijit/form/ValidationTextBox',
    'dijit/layout/ContentPane',
    'dijit/layout/StackContainer',
    'dojox/validate/regexp'
],

function (
    helpers,

    Dialog,
    _TemplatedMixin,
    _WidgetBase,
    _WidgetsInTemplateMixin,

    array,
    declare,
    lang,
    script,
    dojoJson,
    template,

    ArcGISTiledMapServiceLayer,
    Map,

    ChangeRequest
) {});

add and sort commands

x-y-z was turned into xY. I would expected xYZ

On a new project that doesn't have a base path setting, after typing in the value in the prompt, the quick list does not show up.

Prune unused imports command to clean things up after refactoring.

Sort Command:

Add Command:

Remove Command:

Populate quick panel with existing imports.

For readability, I prefer to have my function parameters grouped per line. So this:

... would be this instead:

Seems to me this would be an excellent "user setting" option. I'm happy to help and provide a PR if this sounds good to the team.

No matter what version/build of Sublime Text 3 for Windows I try to install (x86/x64, portable/full, dev/stable/old, etc.), I can't seem to get AMD Butler to work with it (I've tried older versions of AMD Butler as well). After installing Sublime, I install Package Control, and then from Package Control I install AMD Butler and it says it installs successfully, but no AMD Butler commands ever show up in the command palette. I've tried this on multiple Windows 7 machines with the same result.

There are no errors in the console - it just shows these lines on loading:
reloading plugin AMD Butler.init
reloading plugin AMD Butler.amdbutler
reloading plugin AMD Butler.buffer_parser
reloading plugin AMD Butler.crawler
reloading plugin AMD Butler.zipper

should amd butler remove references to items in the

declare([], {

if they are removed.

Hi i have a problem
import Adafruit_CharLCD
when importing this address gives me this error

ModuleNotFoundError: No module named 'Adafruit_GPIO.I2C'

Doesn't parse the package names correctly. Gives the full path. Need to figure out how to deal with slashes.

this would be pretty awesome.

What do you think of a new setting to disable blank lines addition (purely a personal styling preference which doesn't do well with other style guides as it currently is)?

Imports and params should be sorted case-insensitively.

define([
    './config',

    'dijit/_TemplatedMixin',
    'dijit/_WidgetBase',

    'dojo/_base/array',
    'dojo/_base/declare',
    'dojo/_base/lang',
    'dojo/query',
    'dojo/request',
    'dojo/text!./templates/Identify.html',

    'proj4/dist/amd/proj4.js',
    'xstyle/css!app/resources/Identify.css'
], function(
    config,

    _TemplatedMixin,
    _WidgetBase,

    array,
    declare,
    lang,
    query,
    request,
    template
) {});

remove proj4...

define([
    './config',

    'dijit/_TemplatedMixin',
    'dijit/_WidgetBase',

    'dojo/_base/array',
    'dojo/_base/declare',
    'dojo/_base/lang',
    'dojo/query',
    'dojo/request',
    'dojo/text!./templates/Identify.html',

    'xstyle/css!app/resources/Identify.css'
], function(
    config,

    _TemplatedMixin,
    _WidgetBase,

    array,
    declare,
    lang,
    query,
    request,
    template,


) {});

Hi when I solved the issue #23

#23

When trying to add a module I am getting on the log console:

Traceback (most recent call last):
File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 268, in on_modified
v = sublime.View(view_id)
File "C:\Program Files\Sublime Text 3\sublime.py", line 549, in init
self.selection = Selection(id)
RuntimeError: maximum recursion depth exceeded
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
TypeError: () takes 0 positional arguments but 1 was given
error: plugin_host has exited unexpectedly, plugin functionality won't be available until Sublime Text has been restarted

And the plugin stops.

I though it was because I didn't set the path to the dojo api. But I set it and I am getting the same error.

I am running in the same environment as described on issue #23 .

UPDATE:

When solving issue #23 this issue disappeared.

UPDATE:

This error occurred because there where no modules loaded in memory. If we run the refresh modules once this error should not occur even if the refresh did not load any module.

UPDATE:

Turns out this error was isolated from #23... It was a recursion problem on amdbutlet.py

class AmdButlerAdd(_Enabled, sublime_plugin.TextCommand):
    def run(self, edit):
        if not hasattr(self.view, 'mods'):
            _set_mods(self.view)
            #self.view.run_command('amd_butler_add')
        else:
            self.view.window().show_quick_panel(self.view.mods, self.on_mod_selected)

def on_mod_selected(self, i):
    if i != -1:
        pair = self.view.mods[i]
        self.view.run_command('amd_butler_internal_add',{'pair': pair})

The call to _set_mods(self.view) is not synchronous! So a recursion issue will occur if self.view.run_command('amd_butler_add') was not commented.

I also changed

sublime.active_window().show_input_panel('name of folder containing AMD packages (e.g. "src")', '', on_folder_defined, lambda: None, lambda: None)

to

sublime.active_window().show_input_panel('name of folder containing AMD packages (e.g. "src")', '', on_folder_defined, None, None)

The first version was giving me some warning on the console:

TypeError: <lambda>() takes 0 positional arguments but 1 was given

UPDATE:

The previous fix would work but to make the preferences really work it was need some more tweaks. Ieave my version of the amdbutler.py hear in base64 utf8.

import sublime
import sublime_plugin
import os
from . import buffer_parser
from . import crawler
from . import zipper


PATH_SETTING_NAME = 'amd_packages_base_path'
SETTINGS_FILE_NAME = 'AmdButler.sublime-settings'


def _all_text(view):
    return view.substr(sublime.Region(0, view.size()))


def _get_sorted_pairs(view):
    try:
        imports_span = buffer_parser.get_imports_span(_all_text(view))
        params_span = buffer_parser.get_params_span(_all_text(view))
        return zipper.zip(view.substr(sublime.Region(*imports_span)),
                          view.substr(sublime.Region(*params_span)))
    except buffer_parser.ParseError as er:
        sublime.error_message(er.message)


def _update_with_pairs(view, edit, pairs):
    imports_span = buffer_parser.get_imports_span(_all_text(view))
    params_span = buffer_parser.get_params_span(_all_text(view))

    # replace params - do these first since they won't affect the
    # imports region
    params_txt = zipper.generate_params_txt(pairs, '\t')
    view.replace(edit, sublime.Region(*params_span), params_txt)

    # replace imports
    import_txt = zipper.generate_imports_txt(pairs, '\t')
    view.replace(edit, sublime.Region(*imports_span), import_txt)

def on_folder_defined(view):
    def on_folder_defined_computed(txt):
        project = _get_project_data()
        if project is None:
            # no project open use default setting
            settings = sublime.load_settings(SETTINGS_FILE_NAME)
            settings.set(PATH_SETTING_NAME, txt)
            sublime.save_settings(SETTINGS_FILE_NAME)
        else:
            project['settings'].update({PATH_SETTING_NAME: txt})
            _save_project_data(project)
        _get_available_imports(view)
    return on_folder_defined_computed
	
def _set_mods(view):
    
		
    project = _get_project_data()
	
    # create settings project prop if needed
    if project is not None and project.get('settings', False) is False:
        project.update({'settings': {PATH_SETTING_NAME: False}})
        _save_project_data(project)
    
    if project is not None and project['settings'].get(PATH_SETTING_NAME, False) is not False:
        _get_available_imports(view)
    else:
        #sublime.active_window().show_input_panel('name of folder containing AMD packages (e.g. "src")', '', on_folder_defined, lambda: None, lambda: None)
        sublime.active_window().show_input_panel('name of folder containing AMD packages (e.g. "src")', '', on_folder_defined(view), None, None)

def _get_available_imports(view):
    project = _get_project_data()
    if project is None:
        settings = sublime.load_settings(SETTINGS_FILE_NAME)
        folder_name = settings.get(PATH_SETTING_NAME)
        path = _validate_folder(view, folder_name)
        if path is None:
            settings.erase(PATH_SETTING_NAME)
            sublime.save_settings(SETTINGS_FILE_NAME)
            return
    else:
        settings = project['settings']
        folder_name = settings[PATH_SETTING_NAME]
        path = _validate_folder(view, folder_name)
        if path is None:
            del settings[PATH_SETTING_NAME]
            _save_project_data(project)

    sublime.status_message('AMD Butler: Processing modules in {} ...'.format(path))
    view.mods = crawler.crawl(path)
    sublime.status_message('AMD Butler: Processing complete. {} total modules processed.'.format(len(view.mods)))


def _validate_folder(view, folder_name):
    
    #RELATIVE PATH
    
    #if(view.file_name() is None):
    #    sublime.error_message('Cannot validate "'+folder_name+'". File name is not saved!')
    #    return None
    
    #Error #path = os.path.join(view.file_name().split(folder_name)[0],folder_name)
    #path = os.path.join(os.path.dirname(view.file_name()),folder_name)
    
    #ABSOLUTE PATH
    path = folder_name
    
    if os.path.exists(path):
        return path
    else:
        sublime.error_message('Could not find: {}!'.format(path))
        return None


def _get_project_data():
    return sublime.active_window().project_data()


def _save_project_data(data):
    return sublime.active_window().set_project_data(data)


class _Enabled(object):
    def is_enabled(self):
        return self.view.settings().get('syntax').find('JavaScript') != -1


class AmdButlerSort(_Enabled, sublime_plugin.TextCommand):
    def run(self, edit):
        _update_with_pairs(self.view, edit, _get_sorted_pairs(self.view))


class AmdButlerAdd(_Enabled, sublime_plugin.TextCommand):
    def run(self, edit):
        #if not hasattr(self.view, 'mods'):
        #    _set_mods(self.view)
        #    #self.view.run_command('amd_butler_add')
        #else:
        #    self.view.window().show_quick_panel(self.view.mods, self.on_mod_selected)
        if not hasattr(self.view, 'mods'):
            on_folder_defined(self.view)(sublime.load_settings(SETTINGS_FILE_NAME).get(PATH_SETTING_NAME))
        
        self.view.window().show_quick_panel(self.view.mods, self.on_mod_selected)
		

    def on_mod_selected(self, i):
        if i != -1:
            pair = self.view.mods[i]
            self.view.run_command('amd_butler_internal_add',{'pair': pair})


class AmdButlerRemove(_Enabled, sublime_plugin.TextCommand):
    def run(self, edit):
        self.pairs = _get_sorted_pairs(self.view)

        self.view.window().show_quick_panel(
            zipper.scrub_nones(self.pairs), self.on_mod_selected)

    def on_mod_selected(self, i):
        if i != -1:
            self.pairs.pop(i)
            self.view.run_command('amd_butler_internal_update',
                                  {'pairs': self.pairs})


class AmdButlerInternalUpdate(_Enabled, sublime_plugin.TextCommand):
    def run(self, edit, pairs):
        _update_with_pairs(self.view, edit, pairs)


class AmdButlerInternalAdd(_Enabled, sublime_plugin.TextCommand):
    def run(self, edit, pair=''):
        # add param first
        try:
            params_point = buffer_parser.get_params_span(
                _all_text(self.view))[0]
            self.view.insert(edit, params_point, pair[1] + ',')

            imports_point = buffer_parser.get_imports_span(
                _all_text(self.view))[0]
            self.view.insert(edit, imports_point, '\'{}\','.format(pair[0]))
        except buffer_parser.ParseError as er:
            sublime.error_message(er.message)

        self.view.run_command('amd_butler_sort')


class AmdButlerRefresh(_Enabled, sublime_plugin.TextCommand):
    def run(self, edit):
        _set_mods(self.view)


Change

def _validate_folder(view, folder_name):
path = os.path.join(view.file_name().split(folder_name)[0],folder_name)
if os.path.exists(path):
return path
else:
sublime.error_message('Could not find: {}!'.format(path))
return None

to

def _validate_folder(view, folder_name):
if(view.file_name() is None):
sublime.error_message('Cannot validate "'+folder_name+'". File is not saved!')
return None

path = os.path.join(view.file_name().split(folder_name)[0],folder_name)
if os.path.exists(path):
    return path
else:
    sublime.error_message('Could not find: {}!'.format(path))
    return None

UPDATE:

See issue #26

Change to

def _validate_folder(view, folder_name):
#path = os.path.join(view.file_name().split(folder_name)[0],folder_name)
path = os.path.join(os.path.dirname(view.file_name()),folder_name)
if os.path.exists(path):
return path
else:
sublime.error_message('Could not find: {}!'.format(path))
return None

Consider in using absolute path instead is more intuitive:

def _validate_folder(view, folder_name):
path = folder_name
if os.path.exists(path):
return path
else:
sublime.error_message('Could not find: {}!'.format(path))
return None

In this case issue #25 disappeared.

Imported
Importer
AmdButler - serving up modules
AmdWaiter

@steveoh I need creativity help.

i used amd butler to remove all the requires. it left me with

define([
], function (
) {

Then added a module and got

define([
    ''
    'esri/graphicsUtils',

    'graphicsUtils'
], function (
) {

Hi, thanks for this plugin!

Not sure if this is an actual issue or not but is seems inconsistent with the other plugins and Sublime settings: on Windows 7 (not tested on another OS) accessing Preferences > Package Settings > AmdButler > Settings - Default shows an empty file instead of what would rather be some JSON listing the two currently supported default settings and their associated values.

Specifically concerned with crawl performance.

Sometimes you just want to remove a lot of cruft.

Can we allow remove to accept a globbing pattern or some sort of wild card syntax for removing multiple imports.

K thanks.

Do we crawl every time?

Try to listen for new files and add them?

Hi,

I was installing your software through the sublime 3 package manager on windows 8.

and I was getting the following error:

ImportError: No module named 'data' in Sublime 

as it turns out in your crawler.py there was an error on the import:

from data.js_keywords import *

Doing the following change:

#from data.js_keywords import *
from . import data

And building the package was enough to make it load correctly.

UPDATE:

Ok I made it load correctly but I am getting an error on:

if name in JS_KEYWORDS:

It says JS_KEYWORDS does not exist :/

I think the problem is not the import but the fact sublime is looking for the module somewhere else.

Here is the stack trace:

Traceback (most recent call last):
File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 71, in reload_plugin
m = imp.reload(m)
File "./imp.py", line 276, in reload
File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 671, in load_module
exec(compile(source, source_path, 'exec'), mod.__dict__)
File "C:\Users\Rafael\AppData\Roaming\Sublime Text 3\Packages\AMD Butler\crawler.py", line 5, in <module>
from data import js_keywords

I have given up on trying to isolate the JS_KEYWORDS on a module and just copy pasted the content in to the crawler.py. That worked.

Hope it helps. And thank you for your work.

Create some sort of templating system for allowing users to configure how imports are sorted.

examples:

• esri/tasks/query, Query
• esri/map, Map
• esri/graphic, Graphic

Also, for adding modules that don't show up in the list.

Also, single word imports like stubmodule or jquery.

Also better list of reserved words like window and string.

The quick pane allows you use the right arrow key to open multiple files. I wonder if we could use this same UX to allow you to add multiple amd imports with one command invocation.

Good talk.

Not a good solution to check into source control:

Maybe just store the name of the base folder that contains AMD packages? Then crawl could search the tree from the current file looking for the base folder.