ahl / git-utils Goto Github PK

The new version of rbtools deprecated post-review; the new cool way to do things is via rbt. rbt appears to provide almost all of the functionality we currently use, plus some more (lets you make a local copy of the code under review so you can use your favorite tools to browse, rather than reviewboard's interface). git-review could almost certainly be implemented as a wrapper around rbt.

[chris dlpx-app-gate source-config]$ git checkout -b asdf
Switched to a new branch 'asdf'
[chris dlpx-app-gate asdf]$ git review
Traceback (most recent call last):
File "/home/chris/projects/git-utils/bin/git-review", line 213, in
main()
File "/home/chris/projects/git-utils/bin/git-review", line 197, in main
update_review(branch)
File "/home/chris/projects/git-utils/bin/git-review", line 64, in
update_review
"refs/heads/(.*)").match(merge).group(1)
AttributeError: 'NoneType' object has no attribute 'group'

It would be nice if instead it printed a helpful error message suggesting users
run 'git branch --set-upstream <current_branch_inserted_here>
origin/<upstream_branch>'