ahmades / chemtools Goto Github PK

Decide if setters are needed for the following CVODE functions:
CVodeSetMaxOrd
CVodeSetMaxNumSteps
CVodeSetMaxHnilWarns
CVodeSetStabLimDet
CVodeSetInitStep
CVodeSetMinStep
CVodeSetMaxStep
CVodeSetMaxErrTestFails
CVodeSetMaxNonlinIters
CVodeSetMaxConvFails
CVodeSetNonlinConvCoef

If new setters are introduced, they must work pre and post solver initialisation.

• A class X should be passed to a solver instance as via SetUserData
• X must inherit from a client base class encapsulating virtual user defined functions
• X implements the necessary functions, depending on the selected strategy
• Static wrappers are needed for these functions

static int RightHandSide( realtype const time
                          , N_Vector const state_nvec
                          , N_Vector rhs_nvec
                          , void* const user_data ) {
  ClientBase* const data = static_cast<ClientBase* const>( user_data );
  return data->RightHandSide( time
                              , N_VGetArrayPointer( state_nvec )
                              , N_VGetArrayPointer( rhs_nvec ) );
}

Currently the client should explicitly control this irrespective of the selected strategy.
Possible solution: use type traits to check the existence of these functions, depending on the strategy.

A decoder is needed to parse input data.

• Downgrade minimum required version
• Clean up and simplify all CMakeLists

Friendship is not a clean solution

reactor test creates the results file but doesn't dump them in it

Can benchmark against to Cantera and SENKIN.

Currently a simple test for SPGMR nonlinear iterative solver is available. The remaining iterative and direct solvers must be tested.

Relative paths are used to read test data. Currently works for in-source builds.