aicoe / aicoe-cd Goto Github PK

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Describe the bug
we have moved the application aicoe-ci to be deployed to ocp4 cluster via argocd.
https://github.com/AICoE/aicoe-cd/blob/master/manifests/overlays/prod/applications/thoth-station/bots/aicoe-ci.yaml

aicoe-argocd-manager rolebinding is already created in ocp4 namespace where the application is to sync.

however it is facing issue:

To Reproduce
Steps to reproduce the behavior:

1. create an application to be deployed on ocp4 cluster.
2. Click on 'argocd ui'
3. Scroll down to 'Errors' on the application
4. See error

Expected behavior
sync with ease on ocp4 cluster.

Additional context
we can remove this from kustomize, until the ocp4 sync issues are fixed.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Is your feature request related to a problem? Please describe.
Better docs coverage on ksops - a how to, step by step guide for new apps being onboarded.

Describe the solution you'd like
I want @HumairAK to go and write down all the things we chatted about and make it a nice How to guide. 😛

Describe alternatives you've considered
n/a

Additional context
n/a

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Is your feature request related to a problem? Please describe.
currently, the kaizen cluster from moc is not available in the list of clusters for deployments.
It would be very helpful for the users of the moc-kaizen clusters.

Describe the solution you'd like
enable cluster moc kaizen in the list of cluster aicoe-cd manages.

Describe alternatives you've considered
deploy it with kustomize manually

Additional context
https://k-openshift.osh.massopen.cloud:8443

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Is your feature request related to a problem? Please describe.
currently, the ocp4 cluster from psi is not available in list of clusters for deployments.
It would be very helpful for the users of the ocp4 clusters.

Describe the solution you'd like
enable cluster ocp4 in the list of cluster aicoe-cd manages.

Describe alternatives you've considered
deploy it with kustomize manually

Additional context

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Is your feature request related to a problem? Please describe.
When new image is created in cluster in the namespace, the rollout is not automatic if that image is related to DC.

Describe the solution you'd like
start rollout task after deployment in overlays-context-path is successfull, so that new image is actually deployed.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

This has resulted in us having to ignore imagestream fields for certain apps, see #229

We should figure out what is going wrong here and then revert these changes (we should avoid using ignoredifferences as much as possible).

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Yaml lint checks fail because we have jinja syntax in the yaml files. If there's a checker that supports jinja syntax in combination with yaml, we should switch to that, otherwise we should turn these checks off for now.

Example:

Pre-Commit Test failed! Click here

[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing docs/application_migration.md
Fixing docs/cluster_ns_management.md

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...............................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
yamllint.................................................................Failed
- hook id: yamllint
- exit code: 1

objects/namespace-install.yaml
  1:2       error    syntax error: found character '%' that cannot start any token (syntax)

objects/clusters.yaml
  17:1      error    syntax error: found unexpected end of stream (syntax)

objects/patches/argocd_rbac_cm_patch.yaml
  6:1       error    syntax error: could not find expected ':' (syntax)

objects/patches/admin_creds_patch.yaml
  4:56      error    syntax error: expected ',' or '}', but got '<scalar>' (syntax)

objects/patches/argocd_cm_patch.yaml
  6:1       error    syntax error: could not find expected ':' (syntax)

I have stated using a set of commonLabels with all the kustomize files:

commonLabels:
  app.kubernetes.io/name: thoth
  app.kubernetes.io/component: kebechet
  app.kubernetes.io/managed-by: aicoe-thoth-devops-argocd

ArgoCD itself is adding app.kubernetes.io/instance=test-thoth-kebechet depending on the ArgoCD application created.

I would like to standardize on the usage of managed-by: shall we make it the rover group of the team responsible for the management/operation of the app and append -argocd if managed via ArgoCD or -manual if we do it manually using kustomize...

As an Application Owner,
I want to continuously deploy my application by an OpenShift Pipeline,
so that its execution is governed by Keylime

Acceptance Criteria

• decide which application to be used for the demo, in the best case some AI related
• document prerequisites for keylime deployment on op1st
• criteria that prevent the application from being run are documents
• describe the 'hack the worker node' activity
• create op1st ADR on how to deploy Keylime
• an application is built via Tekton Pipeline and delivered as a container image
• the application's container image is deployed via a Tekton Pipeline to an Operate First namespace
• a demo is created

References

• https://github.com/keylime/keylime
• https://github.com/redhat-et/edge-security-demo

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

This issue was generated by todo based on a TODO comment in ec38548 when #40 was merged. cc @HumairAK.

Error from argocd:

unable to decode "/dev/shm/860339166": resource.metadataOnlyObject.ObjectMeta: v1.ObjectMeta.Annotations: ReadString: expects " or n, but found t, error found in #10 byte of ...|ls-acme":true},"labe|..., bigger context ...|tadata":{"annotations":{"kubernetes.io/tls-acme":true},"labels":{"app.kubernetes.io/instance":"dh-pr|...

More discussion here #225

Update the path of applications here to the path here

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Describe the bug
Lots of argocd application of thoth project are waiting on sync to start.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://argocd-server-aicoe-argocd.apps.ocp4.prod.psi.redhat.com/'
2. Click on 'project thoth out-of-sync'
3. Scroll down to apps waiting
4. checkout the wait reason.

Expected behavior
syncing to start with no halt

Additional context
with further checking, got to understand that argocd-controller is not starting the sync.
https://console-openshift-console.apps.ocp4.prod.psi.redhat.com/k8s/ns/aicoe-argocd/pods
the argocd-controller is in image-pullback issue.

please add console-openshift-console.apps.ocp.prod.psi.redhat.com

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

That project has been deleted from the cluster, I believe it is causing ArgoCD to not work anymore in general.

@AICoE/sre

Describe the bug
As thoth-station application utilizes a job which uses generateName , in present argocd v.1.6.1. we can observe a Repeated Resource Warning .

To Reproduce
Steps to reproduce the behavior:

• This warning can be noticed in any of the thoth-station application.

Expected behavior
No warning at all.

Screenshots

Additional context
This issue is already fixed upstream in version v1.6.2
argoproj/argo-cd#3858
https://github.com/argoproj/argo-cd/releases/tag/v1.6.2

we just need to update, as this is just to avoid the warning, this is not critical.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Currently for each cluster we have 1 corresponding cluster secret in the argocd namespace. For each cluster secret, we have a list of namespaces that argocd should have access to. For example for the ocp4 cluster argocd can manage these namespaces here.

But if you notice, we group namespaces for all argocd projects in there. So you have thoth/idh/aiops namespaces for ocp4 listed in the same cluster spec.

The problem with this is, suppose thoth team deletes a namespace from their cluster (and thus the argocd-manager-rolebinding in that namespace), then argocd will start reporting errors (because of how its discovery works) for every team's application using that cluster spec.

Why not use multiple cluster specs per project?
Because argocd cannot have more than 1 cluster spec per cluster, because it uses the cluster url to read the spec and requires it to be unique. Luckily there's a workaround listed here. I think we should use this to create a separate cluster spec for each team/project, and if, for example, idh team needs to onboard a new namespace, they will go edit the idh cluster spec for ocp 4.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.

Describe the bug
argo-cd is not syncing from VCS due to credential issues

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://argocd-server-aicoe-argocd.apps.ocp4.prod.psi.redhat.com/'
2. Click on any application in thoth-station.
3. Scroll down to 'errors'
4. See error

Expected behavior
sync effectively based on changes in vcs.

Revert #74 once the namespace becomes available.

Upstream Operate-First has upgraded ArgoCD to v2.0.1. We should collaborate with them to upgrade our instance of ArgoCD.

Relevant issues: operate-first/apps#498

Is your feature request related to a problem? Please describe.
no

Describe the solution you'd like
ArgoCD should ignore apiVersion: tekton.dev/v1beta1 and v1alpha1 kind: PipelineRun and TaskRun by default

see https://argoproj.github.io/argo-cd/operator-manual/declarative-setup/#resource-exclusioninclusion

Describe alternatives you've considered
n/a

Additional context
These kinds tend to clutter up the ArgoCD application and will render it 'out of sync'.

Please create requirements file for environment default

                    If this project does not use requirements.txt or Pipfile then remove thoth-advise manager from
                    your .thoth.yaml configuration.