ailin-nemui / irssi Goto Github PK

View Code? Open in Web Editor NEW

This project forked from irssi/irssi

4.0 4.0 0.0 8.63 MB

The client of the past

Home Page: https://irssi.org

License: Other

C 90.99% Shell 0.36% Perl 2.05% XS 3.40% Prolog 1.44% Meson 1.76%

irssi's People

Contributors

Stargazers

Watchers

irssi's Issues

wrong default type with protocol modules

Ticho> I found a bug with the module-autoload branch: with matrix and irc modules loaded, if I define an irc network+server and try to /connect to it, irssi considers it to be a matrix server (server->chat_type == MATRIX_PROTOCOL)
if I /save, the network is saved with correct type ("IRC"), and after irssi is restarted, connecting works fine

// notes
"load xmpp" in startup

/network add testnet
/server add -network testnet 1.2.3.4
/connect testnet

=> some crash in loudmouth resolver

Originally posted by @ailin-nemui in #42 (comment)

Invalide Key

Hello,

I am getting invalid keys:

"W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: http://download.opensuse.org/repositories/home:/ailin_nemui:/irssi-test/xUbuntu_18.04 InRelease: The following signatures were invalid: EXPKEYSIG EDB7AED941EEDB57 home:ailin_nemui OBS Project home:[email protected]
W: Failed to fetch http://download.opensuse.org/repositories/home:/ailin_nemui:/irssi-test/xUbuntu_18.04/InRelease The following signatures were invalid: EXPKEYSIG EDB7AED941EEDB57 home:ailin_nemui OBS Project home:[email protected]"

Thanks

queue disorder

/hilight -line extra space?

reported by @vague666

https://vague.se/pastes/2021-09-02_20%3A04%3A45_478x68_scrot.png

coredump in 1.3-pre

sep 02 08:07:23 irssi systemd-coredump[88505]: Process 88496 (irssi) of user 1000 dumped core.

                                           Stack trace of thread 88496:
                                           #0  0x00007f2a2572653a __strcmp_sse2_unaligned (libc.so.6)
                                           #1  0x000055ef13a0eb9c redirect_match (irssi)
                                           #2  0x000055ef13a0ef6c redirect_find (irssi)
                                           #3  0x000055ef13a0f311 server_redirect_get (irssi)
                                           #4  0x000055ef13a0f3fe server_redirect_get_signal (irssi)
                                           #5  0x000055ef13a0709a irc_server_event (irssi)
                                           #6  0x000055ef139c32d1 signal_emit_real (irssi)
                                           #7  0x000055ef139c3668 signal_emit_id (irssi)
                                           #8  0x000055ef13a0744d irc_server_event_tags (irssi)
                                           #9  0x000055ef139c32d1 signal_emit_real (irssi)
                                           #10 0x000055ef139c3668 signal_emit_id (irssi)
                                           #11 0x000055ef13a076ad irc_parse_incoming_line (irssi)
                                           #12 0x000055ef139c32d1 signal_emit_real (irssi)
                                           #13 0x000055ef139c3668 signal_emit_id (irssi)
                                           #14 0x000055ef13a07755 irc_parse_incoming (irssi)
                                           #15 0x000055ef139b43c8 irssi_io_invoke (irssi)
                                           #16 0x00007f2a267d26aa g_main_context_dispatch (libglib-2.0.so.0)
                                           #17 0x00007f2a267d2a60 n/a (libglib-2.0.so.0)
                                           #18 0x00007f2a267d2b0c g_main_context_iteration (libglib-2.0.so.0)
                                           #19 0x000055ef139959f2 main (irssi)
                                           #20 0x00007f2a256b72e1 __libc_start_main (libc.so.6)
                                           #21 0x000055ef139869fa _start (irssi)

                                           Stack trace of thread 88503:
                                           #0  0x00007f2a257768bd poll (libc.so.6)
                                           #1  0x00007f2a267d29f6 n/a (libglib-2.0.so.0)
                                           #2  0x00007f2a267d2b0c g_main_context_iteration (libglib-2.0.so.0)
                                           #3  0x00007f2a267d2b51 n/a (libglib-2.0.so.0)
                                           #4  0x00007f2a267fa4a5 n/a (libglib-2.0.so.0)
                                           #5  0x00007f2a25a3d4a4 start_thread (libpthread.so.0)
                                           #6  0x00007f2a2577fd0f __clone (libc.so.6)

I'm trying to find the core file but debian or systemd is acting up somehow, I've managed to reproduce the crash several times with my current config. It happens after connecting to libera

notls_verify is on for every server when not explicitly using -tls

Same config:
v1.3-dev-509-g5953b675-dirty (hilight branch)

(aug 31 20:41:47) Server               Port  Network    Settings
(aug 31 20:41:47) irc.quakenet.org     6667  QuakeNet   notls_verify
(aug 31 20:41:47) efnet.port80.se      6667  EFNet      autoconnect
(aug 31 20:41:47) irc.swepipe.se       6667  EFNet      autoconnect
(aug 31 20:41:47) irc.homelien.no      6667  EFNet      autoconnect
(aug 31 20:41:47) irc.underworld.no    6667  EFNet      autoconnect
(aug 31 20:41:47) irc.efnet.net        6667  EFNet      
(aug 31 20:41:47) localhost            6667  bitlbee    autoconnect, notls_verify
(aug 31 20:41:47) irc.libera.chat      6697  libera     autoconnect, tls

v1.3-dev-536-g21701a12 (ssl-flip branch)

(aug 31 20:41:24) Server               Port  Network    Settings
(aug 31 20:41:24) irc.quakenet.org     6667  QuakeNet   notls_verify
(aug 31 20:41:24) efnet.port80.se      6667  EFNet      autoconnect, notls_verify
(aug 31 20:41:24) irc.swepipe.se       6667  EFNet      autoconnect, notls_verify
(aug 31 20:41:24) irc.homelien.no      6667  EFNet      autoconnect, notls_verify
(aug 31 20:41:24) irc.underworld.no    6667  EFNet      autoconnect, notls_verify
(aug 31 20:41:24) irc.efnet.net        6667  EFNet      notls_verify
(aug 31 20:41:24) localhost            6667  bitlbee    autoconnect, notls_verify
(aug 31 20:41:24) irc.libera.chat      6697  libera     autoconnect, tls

size mismatch in PING on openbsd

[23/281] Compiling C object src/irc/core/libirc_core.a.p/irc-commands.c.o
../src/irc/core/irc-commands.c:547:49: warning: format specifies type 'long' but the argument has type 'long long' [-Wformat]
        str = g_strdup_printf("%s PING %ld %ld", data, tv / G_TIME_SPAN_SECOND, tv % G_TIME_SPAN_SECOND);
                                       ~~~             ^~~~~~~~~~~~~~~~~~~~~~~
                                       %lld
../src/irc/core/irc-commands.c:547:74: warning: format specifies type 'long' but the argument has type 'long long' [-Wformat]
        str = g_strdup_printf("%s PING %ld %ld", data, tv / G_TIME_SPAN_SECOND, tv % G_TIME_SPAN_SECOND);
                                           ~~~                                  ^~~~~~~~~~~~~~~~~~~~~~~
                                           %lld
2 warnings generated.
[52/281] Compiling C object src/fe-common/irc/libfe_common_irc.a.p/fe-ctcp.c.o
../src/fe-common/irc/fe-ctcp.c:131:30: warning: format specifies type 'long *' but the argument has type 'gint64 *' (aka 'long long *') [-Wformat]
        if (sscanf(data, "%ld %ld", &tv, &tv2) < 1) {
                          ~~~       ^~~
                          %lld
../src/fe-common/irc/fe-ctcp.c:131:35: warning: format specifies type 'long *' but the argument has type 'gint64 *' (aka 'long long *') [-Wformat]
        if (sscanf(data, "%ld %ld", &tv, &tv2) < 1) {
                              ~~~        ^~~~
                              %lld
2 warnings generated.

reported by qbit

critical error when no protocl loaded

/connect some.server

(default) critical create_addr_conn: assertion 'proto != NULL' failed

could make a nicer error if irc is missing :-)

Perl cannot use Irssi::Irc when irc is not loaded
it cannot use Irssi::Irc when only irc is loaded (e.g. during chat protocol created) because it is linked to Dcc and notifylist
it does not use Irssi::Irc automatically even if it could, when irc wasn't present before perl

this could happen if Perl is loaded eagerly through startup (as was recommended for a while for certain Irssi 1.2 versions) but irc, dcc, and notifylist are not
it also happens if /set autoload_modules perl irc
(case 3) happens if /set autoload_modules perl irc dcc flood notifylist otr

the result could be a crash like Can't locate object method "isupport" via package "Irssi::Irc::Server"

reported by @Unit193 / @krytarik

/server modify doesn't find server without freeform port

Expected behavior(imo) v1.3-dev-509-g5953b675-dirty (hilight branch)

/server add -tls -network foonet irc.foo.net 6697
irc.foo.net          6697  foonet     tls
/server modify -notls -port 6667 irc.foo.net
irc.foo.net          6667  foonet

In v1.3-dev-536-g21701a12 (ssl-flip branch)

/server add -tls -network foonet irc.foo.net 6697
irc.foo.net          6697  foonet     disallow_starttls, tls
/server modify -notls -port 6667 irc.foo.net
Server irc.foo.net not found
/server modify -notls -port 6667 irc.foo.net 6697
irc.foo.net          6697  foonet     disallow_starttls

port isn't updated when freeform port is included

ailin-nemui / irssi Goto Github PK

irssi's People

Contributors

Stargazers

Watchers

irssi's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs