LocalBroadcast Creates an NPE when sourceIntent's data Uri is null. about deeplinkdispatch

[MinceMan]

Would the following be the fix?

  private static DeepLinkResult createResultAndNotify(Context context, final boolean successful,
                                                        final Uri uri, final String error) {
    DeepLinkResult result = new DeepLinkResult(successful, uri, error);
    if (uri != null) notifyListener(context, !successful, uri, error);
    return result;
  }

Or do we want to broadcast that error no matter what?

  private static void notifyListener(Context context, boolean isError, Uri uri,
                                                         String errorMessage) {
    Intent intent = new Intent();
    intent.setAction(DeepLinkHandler.ACTION);
    intent.putExtra(DeepLinkHandler.EXTRA_URI, uri != null ? uri.toString() : "");
    intent.putExtra(DeepLinkHandler.EXTRA_SUCCESSFUL, !isError);
    if (isError) {
      intent.putExtra(DeepLinkHandler.EXTRA_ERROR_MESSAGE, errorMessage);
    }
    LocalBroadcastManager.getInstance(context).sendBroadcast(intent);
  }

[MinceMan]

I'll open a PR once I get a response on the correct fix :)

[felipecsl]

I believe that in the case of a launched deep link, theoretically the Intent data cannot be null, but I agree this is wrong. We should check if the uri is not null before calling toString() on it. Can you send a PR?

[MinceMan]

Will do.