GithubHelp home page GithubHelp logo

Comments (11)

felipecsl avatar felipecsl commented on August 15, 2024

Our initial thought was that we'd only accept valid URIs for deep links. If you need a catch-all you can still use the BroadcastReceiver.
If you can present a legit reason to allow partial URIs maybe we can consider, otherwise I'd prefer not.

from deeplinkdispatch.

felipecsl avatar felipecsl commented on August 15, 2024

I kinda see a use case for this after debating about it with @ysdong. The problem is that we'd have to skip the DeepLinkURI.parse() call in this case. I'll think about it for a bit

from deeplinkdispatch.

romainpiel avatar romainpiel commented on August 15, 2024

I don't think there is a nice way to accept this pattern without modifying DeepLinkUri. Other alternatives would be to skip the parse() for that specific case but I don't believe that it's should be the DeepLinkEntry's responsibility to support that.

from deeplinkdispatch.

lordcodes avatar lordcodes commented on August 15, 2024

We use deep links for a custom scheme without a host, just a scheme and a filepath.

E.g.

custom-scheme://basket
custom-scheme://hotel/1234
custom-scheme://item?itemId=65

In this situation, the links are never used outside of deep linking into the app and so host is unnecessary, so we decided to exclude it.

from deeplinkdispatch.

leonardo2204 avatar leonardo2204 commented on August 15, 2024

@andrewlord1990 Sorry to bring an old issue up, but I'm kinda confused here.
I've understood that is not possible to have partial schemes, but you said you excluded 'it' and I guess it solved your problem. How did you solve that ?
And is this ever going to be supported out-of-the-box ?

Thanks and nice job here guys !

from deeplinkdispatch.

felipecsl avatar felipecsl commented on August 15, 2024

you can't have a URI path and not a host. You're just misinterpreting it. In the examples @andrewlord1990 gave, basket, hotel and item would be the host, respectively.

from deeplinkdispatch.

leonardo2204 avatar leonardo2204 commented on August 15, 2024

@felipecsl Thanks for the feedback, I think I got the idea, but in my app we use just like @andrewlord1990 said. Is there any milestone for that ?

Thanks

from deeplinkdispatch.

felipecsl avatar felipecsl commented on August 15, 2024

@leonardo2204 those URLs should work fine with DeepLinkDispatch. Have you tried it and it didnt' work?

from deeplinkdispatch.

leonardo2204 avatar leonardo2204 commented on August 15, 2024

Hey @felipecsl, just to clarify, using like:
bla:///campaigns/{bla} or bla:///test/another will it work ?

Thanks again

from deeplinkdispatch.

felipecsl avatar felipecsl commented on August 15, 2024

@leonardo2204 yep, that works fine

from deeplinkdispatch.

Ghedeon avatar Ghedeon commented on August 15, 2024

Any workarounds how to handle this in DeepLinkDispatch in case the old app was already supporting app:// and it's not possible to change it at the moment?

from deeplinkdispatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.