Comments (11)
Our initial thought was that we'd only accept valid URIs for deep links. If you need a catch-all you can still use the BroadcastReceiver.
If you can present a legit reason to allow partial URIs maybe we can consider, otherwise I'd prefer not.
from deeplinkdispatch.
I kinda see a use case for this after debating about it with @ysdong. The problem is that we'd have to skip the DeepLinkURI.parse()
call in this case. I'll think about it for a bit
from deeplinkdispatch.
I don't think there is a nice way to accept this pattern without modifying DeepLinkUri
. Other alternatives would be to skip the parse()
for that specific case but I don't believe that it's should be the DeepLinkEntry
's responsibility to support that.
from deeplinkdispatch.
We use deep links for a custom scheme without a host, just a scheme and a filepath.
E.g.
custom-scheme://basket
custom-scheme://hotel/1234
custom-scheme://item?itemId=65
In this situation, the links are never used outside of deep linking into the app and so host is unnecessary, so we decided to exclude it.
from deeplinkdispatch.
@andrewlord1990 Sorry to bring an old issue up, but I'm kinda confused here.
I've understood that is not possible to have partial schemes, but you said you excluded 'it' and I guess it solved your problem. How did you solve that ?
And is this ever going to be supported out-of-the-box ?
Thanks and nice job here guys !
from deeplinkdispatch.
you can't have a URI path and not a host. You're just misinterpreting it. In the examples @andrewlord1990 gave, basket
, hotel
and item
would be the host, respectively.
from deeplinkdispatch.
@felipecsl Thanks for the feedback, I think I got the idea, but in my app we use just like @andrewlord1990 said. Is there any milestone for that ?
Thanks
from deeplinkdispatch.
@leonardo2204 those URLs should work fine with DeepLinkDispatch. Have you tried it and it didnt' work?
from deeplinkdispatch.
Hey @felipecsl, just to clarify, using like:
bla:///campaigns/{bla} or bla:///test/another will it work ?
Thanks again
from deeplinkdispatch.
@leonardo2204 yep, that works fine
from deeplinkdispatch.
Any workarounds how to handle this in DeepLinkDispatch
in case the old app was already supporting app://
and it's not possible to change it at the moment?
from deeplinkdispatch.
Related Issues (20)
- Migration to androidX HOT 2
- Not supported valid URIs for deeplinks with same path and different number of parameters HOT 4
- [Question] Get DeeplinkResult without launching activity HOT 2
- Support KSP HOT 1
- An annotation argument must be a compile-time constant HOT 3
- Deep linking integration is Fails with error
- Binary incompatible API change in 5.4.0. HOT 1
- Support for AndroidX Navigation HOT 2
- Pipe(|) separated custom annotators not recognised
- Allow Serializable/Parcelable through intents HOT 8
- Deeplink for search accommodations in a specific place
- DeepLinkHandler<T> interface is not available in latest version i.e. 5.4.3
- Add @DeepLinkModuleRegistry marker annotation to generated registries
- Performance issue in chunkOnModifiedUtf8ByteSize
- queryParameterValue must not be null HOT 4
- Help for using with Java
- DeepLinkIntentsUtil not found exception
- Can i use uri-fragment ( # ) field access directly from bundle?
- Custom Annotations not working after update to v6.1.0 HOT 2
- Not compatible with Hilt HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deeplinkdispatch.