GithubHelp home page GithubHelp logo

f0am's People

Contributors

gmwolfe avatar jhaskinsphd avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

f0am's Issues

J_BottomUp actinic flux units in description

It says here that the units should be photons/cm^2/s

% LFlux: a string specifying a text file with two tab-delimited columns of data.
% The first column should be wavelength (in nm).
% The second column should be photon flux (in photons/cm^2/s).
% Other format options are also available; see IntegrateJ.m for more info.

but IntegrateJ.m really wants it in spectral actinic flux units, photons/cm^2/s/nm

Typo in Troe formulation of K_PRPE_OH in GEOSCHEM_K.m

Hi Glenn,

Just wanted to let you know there's a typo in the Troe formulation of K_PRPE_OH in GEOSCHEM_K.m that must have been carried over from earlier versions of the CB mechanisms. It's at line 113, and the 2 here should be positive, not negative:

krx(:,i) = (LPL./(1+LPL./HPL)).*0.5.^(1./(1+(log10(LPL./HPL)).^2));

I think this is the only reaction affected in the GEOS-Chem mechanism.

Best,
Maggie

PlotRatesGroup not filtering reactions properly

User on F0AM forum noted that title function is not properly removing radical exchange reactions, e.g. using CH3O and CH3O2 as input, it retains the CH3O2 + NO -> CH3O + NO2 reaction. I think the code for identifying these reactions needs to be reworked to use S.Chem.f instead of string comparison.

my P is wrong

Noticed that some CS/QY parameterizations may still assume that P is in Torr instead of mbar. Need to comb through photolysis code and make sure all units are correct.

Met variables starting with J

The model makes some assumptions about Met variables that start with J. This needs to be documented in the code and user manual. Alternatively, those assumptions could be eradicated.

Output of running xx_Chamber.m

Hello
I have run the MCM_Chamber.m (modified according to ExampleSetup_Chamber.m) for the simulation of atmospheric photochemical reaction process with no constrains. When using different chemical mechanisms, the number of the same species concentration output are different (e.g. when using MCM, S.Conc.HNO3: 241×1 double, when using CB05, S.Conc.HNO3: 194×1 double). I was wondering whether the number of S.Conc.xx can be modified.
In F0AM paper "The Framework for 0-D Atmospheric Modeling (F0AM) v3.1", it says In the second paragraph of part “2 Model description” that “MATLAB is a higher-level language than FORTRAN and can be less computationally efficient; however, it is easier to learn for researchers with little programming experience and is used extensively by the experimental community”. But it took 24 seconds to run a 3-hours simulation by runing MCM_Chamber.m, while it takes 15 hours to run a 3-hours simulation by AtChem(FORTRAN) on HPC. Speed of F0AM is so fast! I was wondering what causes the large difference in simulation speed between F0AM and AtChem.
Thank you very much for your kind consideration. Not sure what I am doing wrong, any assistance would be appreciated, or just fyi.

releases

There have been some bug fixes since 4.0, might be nice to do a bug fix release (maybe 4.0.2?), just so anyone who comes here can quickly tell.

PlotRates input error handling

When specifying options in PlotRates (and probably other plot functions), if a user gives the name of the option but not the value, no error is returned. This could be fixed with more rigorous input checking in ParsePairs.m.

PlotRatesAvg averaging vs integration

The averaging routine is unweighted, meaning that runs with lots of points in the beginning get weighted towards those points when taking the average. It would be much better to integrate over time using trapz.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.