Implement `airshipctl phase validate schema` about airshipctl

[airshipbot]

Related Change #703864

Subject: [WIP][#19] Add validate schema command
Link: https://review.opendev.org/c/airship/airshipctl/+/703864
Status: ABANDONED
Owner: Ian Pittwood ([email protected])

Approvals

Code-Review
! None
Verified
-1 Zuul
Workflow
! None

Last Updated: 2021-03-19 12:39:19 CDT

[vetbijaya]

Can you please assign this issue to me?

[airshipbot]

Related Change #733401

Subject: [#19] Add validate schema command
Link: https://review.opendev.org/733401
Status: ABANDONED
Owner: Bijaya Sharma ([email protected])

Approvals

Code-Review
-1 Matt McEuen
Verified
+1 Zuul
Workflow
! None

Last Updated: 2020-09-17 09:15:04 CDT

[mattmceuen]

Do we have any notes on how we expect this command to be used -- e.g.

• should it integrated with phases, or run on a full site at once? Or on arbitrary functions too?
• is this expected to call kustomize (and be run on unrendered docs), or on pre-rendered YAML? I'd think the former would be best
• what's the "user story" for this in terms of when this command will be run, and why?

Airshipctl (especially the phase stuff) has progressed a lot since this issue was created, so I think it would benefit from a fresh sync up - I'll add it to tomorrow's design call.

[mattmceuen]

Notes from the design meeting today: kubeval has some restrictions on its (in)ability to validate CRs, making it of limited use in an airshipctl context. An alternate approach was proposed, which would

1. leverage (in-progress) work that will start a containerized k8s distribution for cluster bootstrap purposes
2. start the cluster^ via a containerized interface, perform doc validation against its apiserver, and then tear it down
3. phases would be validated in phase-plan order, and CRDs would progressively be loaded into the cluster. This will allow for later phases to be validated against CRDs that were loaded in earlier clusters.

This issue should be put on ice till the bootstrap functionality above is ready.

[michaelfix]

Reached out offline to @vetbijaya (Bijaya) to check status.

[vetbijaya]

@mf4716 @mattmceuen Need to abandon my earlier PS and will create new one based on new requirements. I'm working/finding on some alternative solution for validating CRs.

[michaelfix]

thank you @vetbijaya

[michaelfix]

@vetbijaya , do we have a clear(er) path forward & new PS? I see the prior PS is abandoned.

[vetbijaya]

@mattmceuen, I'm following the dry run strategy, is it good approach?
@mf4716, yes Mike, I will try to upload WIP PS by end of the day.

[airshipbot]

Related Change #754211

Subject: [WIP] Add document validate schema command
Link: https://review.opendev.org/c/airship/airshipctl/+/754211
Status: ABANDONED
Owner: Bijaya Sharma ([email protected])

This change will close this issue when merged.

Approvals

Code-Review
! None
Verified
-1 Zuul
+1 ATT Airship2.0 CI
Workflow
! None

Last Updated: 2021-03-19 07:59:08 CDT

[teoyaomiqui]

@mattmceuen maybe this should be part of airshipctl phase validate --validate-schema , i mean this heavily relies on phases, maybe it should belong to phase subcommand? Just a thought here

[mattmceuen]

All else equal I would agree with you @teoyaomiqui . However, the tricky thing for schema validation is that validating CRs in phase N depend on CRDs from phase (N-1). So that may necessitate a "global" schema validation operation, which walks through the phases in order, and loads the CRDs into the "validating entity" (e.g. a kind API Server). Ideally we would use the phase plan for the definition of "in order" in the target state.

If you can think of some good way around that wrinkle, though, I'm all ears.

[michaelfix]

@vetbijaya , what is the current status?

[vetbijaya]

@mf4716, working on refactoring my PS according to Matt's comment.

[mattmceuen]

Met with Ruslan and @vetbijaya to discuss how to replicate the tools/validate_docs functionality using an airshipctl->kind container interface. Ruslan is going to dig in a bit and propose an approach.

[michaelfix]

@vetbijaya - can you please provide status?

[vetbijaya]

@mf4716 - waiting for Ruslan's comments on this issue.

[michaelfix]

@vetbijaya - can you please provide status?

[vetbijaya]

@mf4716 - got some review comments from Ruslan, will reach out to him to clear few doubts.

[airshipbot]

A [Related Change](https://review.opendev.org/765426 was merged. This issue may be ready to close.

[michaelfix]

@vetbijaya - can you please provide status?

[raliev12]

@vetbijaya - can you please provide status?

Hey Mike,

you can assign this issue on me for a while, since I'm going to prepare some follow-up after my demo which I presented in December.

Thanks,
Ruslan

[airshipbot]

A [Related Change](https://review.opendev.org/767253 was merged. This issue may be ready to close.

[mattmceuen]

Thanks for re-enabling the script-based validation, @raliev12 -- that's really helpful

[airshipbot]

Related Change #780681

Subject: Add validation phases
Link: https://review.opendev.org/c/airship/airshipctl/+/780681
Status: MERGED
Owner: Ruslan Aliev ([email protected])

This change will close this issue when merged.

Approvals

Code-Review
+2 Matt McEuen
+2 Kostyantyn Kalynovskyi
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2021-04-27 22:39:03 CDT

[airshipbot]

Related Change #780450

Subject: Add KRM function to validate site documents
Link: https://review.opendev.org/c/airship/airshipctl/+/780450
Status: MERGED
Owner: Ruslan Aliev ([email protected])

Approvals

Code-Review
+2 Matt McEuen
+2 Drew Walters
Verified
+1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Drew Walters

Last Updated: 2021-04-27 18:19:05 CDT

[airshipbot]

Related Change #782628

Subject: Introduce plan validate command
Link: https://review.opendev.org/c/airship/airshipctl/+/782628
Status: MERGED
Owner: Ruslan Aliev ([email protected])

Approvals

Code-Review
+2 Kostyantyn Kalynovskyi
+2 Ian Howell
Verified
+1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2021-03-30 21:19:18 CDT

[airshipbot]

Related Change #779419

Subject: [WIP] Static schema validation for site documents
Link: https://review.opendev.org/c/airship/airshipctl/+/779419
Status: ABANDONED
Owner: Ruslan Aliev ([email protected])

Approvals

Code-Review
! None
Verified
-1 ATT Airship2.0 CI
-1 Zuul
Workflow
! None

Last Updated: 2021-03-25 22:37:43 CDT

[airshipbot]

A [Related Change](https://review.opendev.org/782628 was merged. This issue may be ready to close.