`airshipctl config get-cluster <PARAMS>` circumstantially ignores filters about airshipctl

[ian-howell]

I think we should come up with a more specific Expected behavior for this issue. Here's my proposal:

1. Require the usage of the --cluster-type flag. Usage of this command without it should cause an error
2. When airshipctl config get-cluster is run with no arguments, it should display all clusters of the provided type:
   a. --cluster-type target lists all target clusters
   b. --cluster-type ephemeral lists all ephemeral clusters
   c. --cluster-type all lists both target and ephemeral clusters
3. When airshipctl config get-cluster is run with one or more arguments, it should only display the requested clusters. This would use the --cluster-type flag in the same fashion as above, but it would create errors for requests for non-existent clusters.

[jgu17]

I'll take a shot at it if no one has started on it.

[ianpittwood]

It's all yours @jgu17

[jgu17]

gerrit review: https://review.opendev.org/#/c/709873/

[airshipbot]

Related Change #709873

Subject: [#24] Fix airshipctl config get-cluster filtering
Link: https://review.opendev.org/c/airship/airshipctl/+/709873
Status: ABANDONED
Owner: James Gu ([email protected])

This change will close this issue when merged.

Approvals

Code-Review
+1 John Williams
Verified
+1 Zuul
Workflow
! None

Last Updated: 2021-03-19 12:39:20 CDT

Issue reopened due to new activity on Gerrit.

[drewwalters96]

No longer relevant

[airshipbot]

The Change that closes this issue was merged.

[eak13]

Closing due to being reopened by abandoned patchset