airstruck / love-wiki-version-picker Goto Github PK

See title. Source repo has fallen behind live version.

The injectVersionTags function injects versions into the picker. It uses for .. in which doesn't iterate in a predicable order. When iterating properties of an object that was defined as an object literal, most implementations will iterate the in the same order the properties were defined, but this isn't guaranteed. Should change back to pulling the version page with XHR or store versions in an array instead of a plain object.

PrismaticJoint:setLimitsEnabled was removed, then re-added. The current code removes it from listings because it was remove, ignoring the fact that it was then re-added. I guess this means there needs to be another step to deal with this specific case, which is exciting. The simplest fix seems to remove removed functions first, then remove added functions, but check that if we're not to hide an added function, that it is re-enabled.

See https://love2d.org/wiki/love.event.push.
These boxes provide a nicer UI, and work better with longer lists, see https://love2d.org/wiki/CanvasFormat.

We can, of course, change the template to provide easier access to the available data. Unfortunately I'm not quite familiar with how the code works or I would've done it myself.

From what I can tell the result is two divs, one for the header, and one for the contents, I propose we modify the template to:

• wrap it in an extra div, containing both
• add semantic data, if possible

I see there's some custom attributes in the page already, so it should be fairly easy to add those to the wrapper div.