aj-r / riotnet Goto Github PK

Trying on this client, ran the simple example code:

            var client = new RiotClient(new RiotClientSettings
            {
                ApiKey = "RGAPI-<my api key>" // Replace this with your API key, of course.
            });
            var summoner = await client.GetSummonerBySummonerNameAsync("KirkBerkley", RiotNet.Models.PlatformId.NA1).ConfigureAwait(false);

Consistently getting 403s, even after a key regen. I also notice that the unit tests don't provide a platform id, but I can't seem to run without one.

• new game modes
• new maps
• new queues

Is there any plan to update RiotNet to the new v3 API?

https://discussion.developer.riotgames.com/articles/652/riot-games-api-v3.html
https://discussion.developer.riotgames.com/articles/1053/v1v2-90-day-deprecation-period-has-begun.html

when i access the masteries from the "GetStaticMasteries()", every mastery i get is ferocity, even doe it should be cunning or resolve.

Languages are the same for every platform. Having constants would make it easier to use static data API methods that accept a language parameter.

is it possible to edit the wrapper so it doesnt call the riot api directly? so you can have a server in the middle with your api key on it, because right now the api key is hardcoded into the app and that way its not possible to release the app.

If the server returns an error object in a 400/500 response, the client still tries to deserialize it as the type it was originally expecting. This results in either a JsonSerializationException or a RestException with no useful message. As such, the user cannot see the error that came from the server, making it difficult to determine the cause of the error.

To fix this, we should throw a RestException containing the error message from the server.

Hey,

I know I am a bit late on this, but with the removal of that static data API did you remove support for that kind of data enterily?

RiotNet.Test / RiotClientTests.cs / GetServerName_ShouldBeDefinedForAllRegions() tests for platformId. It should test for serverName.
example correct implementation (too lazy for pull request XD, and idk if u even care about this anymore):

[Test]
public void GetServerName_ShouldBeDefinedForAllRegions()
{
    foreach (string server in from Region region in Enum.GetValues(typeof(Region)) select RiotClient.GetServerName(region))
    {
        Assert.That(server, Is.Not.Null.And.Not.Empty);
    }
}

Add overloads for all API calls that accept a cancellation token.

Riot now gives us X-App-Rate-Limit and X-Method-Rate-Limit headers. Use them instead of making people hard-code their rate limits.

Dim client As New RiotClient
client.Settings.ApiKey = apikeyref
Dim r As Models.Summoner = Await client.GetSummonerBySummonerNameAsync("jaowsh")

How is this not working? (The apikey is a dim at top.) I'm getting error with "await" and "client"

The static data API doesn't return all properties of an object unless you tell it to. For the properties that aren't returned, it would be nice to set them to null so it is clear that they aren't set. (For example, it might look like a mastery is in the ferocity tree when it really isn't.)

However I'm not totally sure that we want to do this, since it will be an interface breaking change. As a potential alternative, we could add a new enum value of None = -1 for the affected enums (or just set the property value to -1 even though it's not part of the enum).

add new constants on QueueTypes enum, like CLASH = 700

Updated constants here: https://developer.riotgames.com/game-constants.html

The DatabaseId property could be confusing for a lot of people since it isn't returned by Riot's API at all. See if we can create a separate NuGet package containing database-ready models that extend the normal models.

Hi,
the following properties are not included inside MatchParticipantStats:

perkPrimaryStyle
perkSubStyle

Other missing values are playerScore0 - playerScore9, but since they are not used / always 0, those are of no importance I´d guess.

Cheers

Whenever I use the 'Release' preset with Visual Studio 2017 I get this exception:

This line of code is causing the error:
var summoner = await client.GetSummonerBySummonerNameAsync(name).ConfigureAwait(false);

The strange thing is, when I use debug mode, everything works fine. What could be causing this error?

Please add StatPerk0, StatPerk1 and StatPerk2 to wrapper.

Since today the rune static data endpoint gives me a NullPointer exception. I expect it has to do with an update Riot did:
https://discussion.developer.riotgames.com/articles/1736/updates-to-lol-static-data-v3.html

Could you fix this please?

Hey there,
first of all i want to thank you for your work. I really appreciate it.
The issue i have occurs when I am trying to get the current Game Information. like
"client.GetCurrentGameBySummonerId(_currentSummoner.Id)". I get an error 404. Did Riot change the URLs used for these request and you havent implemented it yet ? Or am I missing something ?
Thanks in advance

Hi,
I am facing a strange issue. RiotClient.GetStaticRealm is not working for some regions (I tested EUW and TR not working), while it works fine for other regions (I tried NA,BR,LAN). My developer account is on EUW so I think it is not related to the account settings.

RiotClient client = new RiotClient(Region.EUW, riotApiKey);
staticRealm = client.GetStaticRealm(); //NOT OK

RiotClient client2 = new RiotClient(Region.NA, riotApiKey);
staticRealm = client2.GetStaticRealm(); //OK

The message I receive is the following:
A REST request failed. Status code: 403
{"status": {"message": "Forbidden", "status_code": 403}}

Right now our models don't work out-of-the-box in EF Core because EF Core doesn't support the [ComplexType] attribute. EF Core 2 supports owned types, which are meant as a replacement to complex types, so we'll have to target EF Core 2.

See https://discussion.developer.riotgames.com/articles/1872/new-regional-proxies.html

Hi,

it seems like the Property for leagueId is missing inside the LeaguePosition Model.

Cheers

Hi there,

My name is David and I use RiotNet for my app. I would like to know if someone is working on the new V4 endpoints since V3 ones will be deprecated on 28th January.

Thank you so much in advance!

Hello everyone!
I observed that only Global Endpoint is used at the Tournament methods, I mean, why not use the Region Endpoint chose on RiotClient constructor?
Can I change this in some configuration?
Thanks.

Try to prevent requests from being sent if we think they will go over the rate limit.