ajsmth / earhart Goto Github PK

react native + routing

JavaScript 8.81% Starlark 4.05% Java 6.54% Ruby 5.87% Objective-C 8.83% TypeScript 65.90%

earhart's Issues

Non-animated tab stack

So I think a common use case will be to have tabs that don't animate, I started creating a whatsapp clone to test this out a few weeks ago and noticed this. Also I think explaining how deep routing into nested navigators are intended to work would be quite handy as it's the only real complex concept.

For example, I may have a couple screens that can exist in tab a and tab b, if I want to deep link either on startup or clicking a push notification etc it seems that rather than explicitly setting tab this is clever and knows how to navigate sub Navigators?

History continues to climb even when going back

This is best described through the following gif, using the history.index prop, I noticed that the number continues to increase when navigating back through a stack

Cannot pop to root unless initial route pathname is "/"

Loving this so far, found a slight gotcha with this:

Popping to the root is not possible unless the initial path is "/"

    const history = useHistory();
    history.go(-history.entries.length)

Digging through the code, I think this is due to how the memoryHistory is behaves by default. It looks like given the following router treats the initial path is always set to "/"

With the following Navigator the memoryHistory is created incorrectly

 <Navigator initialIndex={0}>
                    <Stack>
                        <Route gestureEnabled path="/1">
                            <Header titleColor="#ffffff" largeTitle titale="Test"
                              backgroundColor="transparent"/>
                            <Home />
                        </Route>
                        <Route gestureEnabled path="/2">
                            <Header titleColor="#ffffff" largeTitle title="Test2"
                              backgroundColor="transparent"/>
                            <Home />
                        </Route>
                        <Route gestureEnabled path="/3">
                            <Header titleColor="#ffffff" largeTitle title="Test3"
                              backgroundColor="transparent"/>
                            <Home />
                        </Route>
                    </Stack>
</Navigator>

However given the following markup the router behaves fine

 <Navigator initialIndex={0}>
                    <Stack>
                        <Route gestureEnabled path="/">
                            <Header titleColor="#ffffff" largeTitle titale="Test"
                              backgroundColor="transparent"/>
                            <Home />
                        </Route>
                        <Route gestureEnabled path="/2">
                            <Header titleColor="#ffffff" largeTitle title="Test2"
                              backgroundColor="transparent"/>
                            <Home />
                        </Route>
                        <Route gestureEnabled path="/3">
                            <Header titleColor="#ffffff" largeTitle title="Test3"
                              backgroundColor="transparent"/>
                            <Home />
                        </Route>
                    </Stack>
</Navigator>

ajsmth / earhart Goto Github PK

earhart's People

Contributors

Stargazers

Watchers

Forkers

earhart's Issues

Non-animated tab stack

History continues to climb even when going back

Cannot pop to root unless initial route pathname is "/"

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs