akunzai / nhibernate.extensions.logging Goto Github PK

Describe the bug
I've recently upgraded my application from .NET 3.1 to 6.0. Version of NHibernate was not changed - it was 5.2.5.0.
I've change also logging method. Previously NHibernate was logging to Common.Logging via NHibernate.Logging. After upgrade I've installed and configured NHibernate.Extensions.Logging
Simple tests confirmed that change was successfully implemented.
However after some time we've found that queries contained join work incorrectly. For JoinEntityAlias method (as in screenshot) we've got incorrect syntax - part of where statement was put into the from clause. Message was "could not execute query".
I've converted JoinEntityAlias into proper Linq query. Then we've obtained message "undefined join type".
We have other types of specyfying joins but I haven't tested it.
After removing Nuget package with NEL everything was back to normal.
I've recompiled NEL from sources referencing our local copy of NHibernate.dll and then used this instead of oryginal NEL NuGet package. Everything behaves as expected.

To Reproduce
Steps to reproduce the behavior:
Install NHibernate version 5.2.5.0 . Create a query with JoinEntityAlias.
Then install NHibernate.Extensions.Logging version 2.3.1 Nuget.
Add
var loggerFactory = app.ApplicationServices.GetRequiredService<Microsoft.Extensions.Logging.ILoggerFactory>();
NHibernateLogger.SetLoggersFactory(new MicrosoftLoggerFactory(loggerFactory));
in Configure method in Startup class.
Query will not run as before.

Expected behavior
Logging should never change application behavior. Especially it should not change generated queries.

Screenshots

Additional context
Add any other context about the problem here.

since Microsoft.Extensions.Logging 2.2.0, following code will caused compiler warnings

var loggerFactory = new LoggerFactory()
  .AddDebug()
  .UseAsNHibernateLoggerProvider();

This method is obsolete and will be removed in a future version. The recommended alternative is AddDebug(this ILoggingBuilder builder).

instead of initiates LoggerFactory directly, your should inject it by DI containers

var loggerFactory = services.GetRequiredService<ILoggerFactory>();
loggerFactory.UseAsNHibernateLoggerProvider();

This project's clone of Microsoft.Extensions.Logging.LoggerFactoryExtensions collides with the one from Microsoft's package. I have code that is reflectively looking up a method in Microsft's LoggerFactoryExtensions class, but the compiler complains:

[CS0433] The type 'LoggerFactoryExtensions' exists in both 'Microsoft.Extensions.Logging.Abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'NHibernate.Extensions.Logging, Version=1.1.0.0, Culture=neutral, PublicKeyToken=null'

I don't think there's anything requiring your extension method class to have the same name, nor same namespace as Microsoft's. All that matters is that the type of the this parameter be Microsoft's LoggerFactory.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Pending Approval

These branches will be created by Renovate only once you click their checkbox below.

• chore(deps): update dependency microsoft.extensions.logging.abstractions to v8

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update dependency nhibernate to v5.4.7

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository