ala-na / minishell

Minishell's project for 42 school

minishell's Issues

The `CDPATH` variable does not handle multiple paths.

Multiple paths separated by a : in the CDPATH variable should be handle by cd. Similar to the PATH variable.

break minishell input and execution with heredoc and pipe

if i launch heredoc, redirects nowhere and pipe it, do bad execution and break all
command: << eof | ls

Error while using echo with redirections

Quand on utilise les redirections avec echo (ou n'importe quel autre build-in), le fichier est créé mais le script plante - On it 👀
Je parie sur une histoire de dup liée aux modifications que tu as fait pour que les redirections soient faites avant, je creuse tout ça 👊

Several problems with history

• Empty commands and only-spaces commands should not be added to the history;
• If a same command is typed several times in a row, it should be added only once to the history.

fatal error when executing relative command

bad management of double piped heredoc

Is due to a bad management of redirection.
you need to execute redirection after parsing (launch heredoc, create file..) and save fd to redirect it before execution of simple command

env empty when launching with env -i

Bash :

Minishell :

Labeled as an enhancement (not specified by the subject, and doesn't crash).
To correct it, PWD and SHLVL should be initialized at launch (PWD : current pwd; SHLVL : 1).

I/O break when pipe heredoc

can probably be fixed with #117, if not check if stdin/stdout is well restored

double exit when ctrl-D

`env -i ./minishell` does not launch

Since there is no segfault or crash, it is not a serious mistake. But it does not behave the same way as bash.
NB: even executed via env -i, bash is able to run commands.

Builtin pwd not working, no modification of PWD variable and creation of OLD variable

output redirecte file created with all rights

Probably same thing with other file created with redirection

`export` does not handle concatenation.

man exportdoes not mention this feature, so is it mandatory ?.. 🤷‍♂️

`minishell`cannot be executed from another file

History does not persiste between multiple call of shell

(Click on to preview)

Erreur de parsing des commandes quand "> $var_vide echo hey"

acceptable behavior of inline mode ?

exit doesn't work as it should

(Exit value after exit -42 is due to underflow, manages itself)

Fd leak in heredocument.

Error while trying to create file containing a $ in name

Obtained :

Expected :

minishell segfault if we run a program that segfault

similar with other signal (SIGBUS/SIGABORT...)

code to test:

#include <signal.h>
#include <sys/types.h>

int	main(void)
{
	kill(0, SIGSEGV);
}

Expanding variables in heredoc mess up the last line.

fd leak when piping in an invalid command.

Makefile could be improved.

touch on a file in the libft and running make does not recompile the file nor the project. This can be solved by calling make -C libft in the project makefile instead of putting libft in the dependencies.
Also, touch on a .hfile does not recompile the project. This can be solved with the -MMD flags and the use of dependencies.

variable in heredoc not expanded when containing a $

Redirecting `/dev/zero` and `/dev/random`in minishell breaks it.

./minishell < /dev/randomand ./minishell < /dev/zeroare not handled.
./minishell < /dev/nulldoes not break though.

"exit" displayed when command exit is called inside a pipeline

No picture taken, title self-explanatory.

Bash :