albinmathew / photocrop

A Library which can be used to crop images in Android similar to Facebook and Telegram

Hi 👋, I'm Albin Mathew

Connect with me:

Languages and Tools

 

photocrop's Issues

New version 1.0.4

Thanks for this library. It should be helpful, but version 1.0.3 is failing to build because FloatMath is no longer available in the Android SDK. Can you promote your latest commits into a new version 1.0.4 so i can avoid having to manually include your JAR? Thanks!

two round shape apears.

i am using your demo. there is showing two circular shape box for croping and when i click on send button, it crops in rectangle. can i get rectangle crop box rather than circular.?

Image captured using camera intent gets rotated on some devices on Android?

Mininum SDK 14?

Was wondering why the minimum SDK is set at 14? The 2 dependant libraries use 7 and 10.
Do you use any code that requires 14? I prefer to support Android 2.3 whenever possible.

Regarding first time scroll image in bottom

Hi albinmathew

when we select image from gallery or choose image from camera .
then cropovelview always set in bottom how to set crop ovelview in the center of Photoview .

Unable to build when using proguard

The library is using sqrt() method that is deprecated in API 23, so ProGuard throws a warning:

Warning: com.albinmathew.photocrop.photoview.PhotoViewAttacher: can't find referenced method 'float sqrt(float)' in library class android.util.FloatMath
Warning: com.albinmathew.photocrop.photoview.gestures.CupcakeGestureDetector: can't find referenced method 'float sqrt(float)' in library class android.util.FloatMath 

For now we can use the dontwarn option, but it would be great to fix these

Crop Height and Width

Hi, Thank for the wonderful library.
I am trying crop in android first time. My crop area is rectangular. How can i change crop height ?

Support rotate image

I would like a rotate feature but don't know how to do.
I see PhotoView has: setRotationTo, setRotationBy, setDisplayMatrix features
but don't know how to catch onTouch event while user is rotating?
@albinmathew could you give me a hint?

How can we give rectangular shape to cropping window?

Can't install app

Here is the error message
C:\Users\world gate computer\AndroidStudioProjects\CircleImageCrop\app\src\main\res\layout\activity_image_crop.xml:14: AAPT: error: attribute cornerRadius (aka com.istiak.circleimagecrop:cornerRadius) not found.

Skipped XX frames! The application may be doing too much work on its main thread.

Hi,
first of all great thanks for your lib, I need functionality exactly like it does!

I have found that if PhotoView (and/or CropOverlayView) are displayed on screen for some time (I am talking about minutes) then I am getting message like Skipped XX frames! The application may be doing too much work on its main thread. in debug console, and application slows down significantly.
I have checked example app and was able to reproduce it there as well.
Do you have any idea how this can be fixed?

Unable to build

I get Error:(15) No resource identifier found for attribute 'cornerRadius' in package 'com.my.package'

Underflow in restore - more restores than saves

Hi How to solve the issue of Underflow in restore-more restores than saves.

java.lang.IllegalStateException: Underflow in restore - more restores than saves

Custom crop frame

Hi,

Is it possible to add the ability to set the custom crop frame or based on ratio? It looks like currently the lib supports only the square mode.

Lag on photocrop

if you just stay on photo crop page after selecting the picture, This is the log that says you're doing some heavy thing somewhere :(

02-17 16:40:04.216 2544-2544/com.albinmathew.samples.photocrop I/Choreographer: Skipped 58     frames!  The application may be doing too much work on its main thread.
02-17 16:40:05.222 2544-2544/com.albinmathew.samples.photocrop I/Choreographer: Skipped 59 frames!  The application may be doing too much work on its main thread.
02-17 16:40:06.224 2544-2544/com.albinmathew.samples.photocrop I/Choreographer: Skipped 59 frames!  The application may be doing too much work on its main thread.
02-17 16:40:07.236 2544-2544/com.albinmathew.samples.photocrop I/Choreographer: Skipped 59 frames!  The application may be doing too much work on its main thread.
02-17 16:40:08.225 2544-2544/com.albinmathew.samples.photocrop I/Choreographer: Skipped 58 frames!  The application may be doing too much work on its main thread.
02-17 16:40:09.216 2544-2544/com.albinmathew.samples.photocrop I/Choreographer: Skipped 58 frames!  The application may be doing too much work on its main thread.

and after about a minute app becomes unresponsive

PhotoView setScaleType doesn't take effect

Not working in android 10

its not working in android 10. when i select image from gallery its not going on cropping page. direct back to the activity where we started.

Conflicting attribute names

If using compile 'com.android.support:appcompat-v7:23.1.1' the overlayColor attribute is conflicting with the on in the support package...

Maybe you can prefix your attribute names...