GithubHelp home page GithubHelp logo

deezer-datasync's Introduction

HEY THERE.

deezer-datasync's People

Contributors

alecigne avatar dependabot[bot] avatar

Stargazers

 avatar

Watchers

 avatar

deezer-datasync's Issues

Creation time in playlists is actually local time

All creation times are UTC:

  • time_add in albums ✅
  • time_add in artists ✅
  • time_add in the tracks of a playlist ✅

...except in the info section of playlists;

  • creation_date is a local time

  • time_add is a local time (last time a song was added), despite being a UNIX timestamp

  • time_mod is a local time (last time the playlist was modified, either by adding a song or by changing something like the description -- I don't really understand the behaviour)

  • When backuping playlist info, I should either reflect the fact that this is a local time or convert it to UTC using the zone in the configuration file. However, I have to be sure that the local time that Deezer uses is always the same for a given user (from the "preferences" in the user profile). If they take the local time of the place from which the playlists is created instead, I can't convert to UTC since I can't guess the zone.

  • Maybe I should also add time_add and time_mod in the backup.

Automate version management

For every new release I need to:

  • Create a release version in pom.xml.
  • Create an entry in the CHANGELOG.
  • Tag the commit.
  • Push the tag and then the commit.
  • Create a commit to prepare the next development version.
  • Create a release with a JAR inside.

This needs to be automated.

Do not commit if commit is empty

Comparing the SHA of the trees should be enough (I need to test this):

if (newTree.getSha().equals(baseTreeSha)) {
    log.debug("The commit is empty. No changes to push.");
    return; // Skip the commit creation and update
}

Improve playlist filenames

The playlists directory contains files whose filename is in the [id].json format. That makes identification of a given playlist difficult. The goal of this dev would be to include the playlist title in the filename, but in downcase and cleaned from any undesired characters (whitespace, dashes, special characters, etc.).

  • Hip-Hop -> [id]_hip_hop.json -- downcase, dash transformed into underscore
  • Funk and Soul -> [id]_funk_and_soul.json -- downcase, whitespace transformed into underscore
  • Funk & Soul -> [id]_funk_soul.json -- downcase, whitespace and "&" transformed into underscore, more than 1 underscore limited to 1 underscore
  • Downtempo / Nu Jazz -> [id]_downtempo_nu_jazz -- downcase, whitespace and "/" transformed into underscore, more than 1 underscore limited to 1 underscore
  • Drone Zone [Study / Relax / Meditate] -> `[id]_drone_zone_study_relax_meditate.json -- downcase, whitespace, "[", "]" and "/" transformed into underscore, more than 1 underscore limited to 1 underscore

Use jqwik to write a property-based test for this logic.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.