GithubHelp home page GithubHelp logo

alesdo / datasetconverters Goto Github PK

View Code? Open in Web Editor NEW
3.0 3.0 1.0 524 KB

DataSet JsonConverters for JSON.Net that preserve all the state

License: MIT License

F# 90.94% C# 9.06%
dataset json serialization

datasetconverters's People

Contributors

alesdo avatar dependabot[bot] avatar dvdvorle avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

dvdvorle

datasetconverters's Issues

Serialization of proposed values differs from .NET framework xml serialization

During editing - after calling BeginEdit() but before calling EndEdit() on a DataRow - the .NET framework will serialize the dataset with the new values, while this library will serialize the dataset with the old values.

This unit test demonstrates this:

using System.Data;
using System.IO;
using System.Xml.Serialization;
using Newtonsoft.Json;
using NUnit.Framework;

namespace DataSetConvertersTests
{
    [TestFixture]
    public class DataSetConvertersTest
    {
        [Test]
        public void DataSetSerialization()
        {
            var dataSet = new DataSet();
            var dataTable = dataSet.Tables.Add("table");
            dataTable.Columns.Add("Value");
            var row = dataTable.Rows.Add("Old");
            dataSet.AcceptChanges();

            row.BeginEdit();
            row[0] = "New";

            Assert.That(row[0], Is.EqualTo("New"));
            Assert.That(row[0, DataRowVersion.Default], Is.EqualTo("New"));
            Assert.That(row[0, DataRowVersion.Original], Is.EqualTo("Old"));
            Assert.That(row[0, DataRowVersion.Current], Is.EqualTo("Old"));
            Assert.That(row[0, DataRowVersion.Proposed], Is.EqualTo("New"));

            var dataSetBeforeEndEdit = SerializeAndDeserializeXml(dataSet);

            var rowBeforeEndEdit = dataSetBeforeEndEdit.Tables[0].Rows[0];

            // These four asserts succeed for SerializeAndDeserializeXml, but fail for SerializeAndDeserializeJson
            Assert.That(rowBeforeEndEdit[0], Is.EqualTo("New"));
            Assert.That(rowBeforeEndEdit[0, DataRowVersion.Default], Is.EqualTo("New"));
            Assert.That(rowBeforeEndEdit[0, DataRowVersion.Original], Is.EqualTo("New")); // Yes, xml only serializes the new value here (loses the Original value)
            Assert.That(rowBeforeEndEdit[0, DataRowVersion.Current], Is.EqualTo("New"));

            Assert.That(() => row[0, DataRowVersion.Proposed], Throws.Exception);

            row.EndEdit();

            Assert.That(row[0], Is.EqualTo("New"));
            Assert.That(row[0, DataRowVersion.Default], Is.EqualTo("New"));
            Assert.That(row[0, DataRowVersion.Original], Is.EqualTo("Old"));
            Assert.That(row[0, DataRowVersion.Current], Is.EqualTo("New"));
            Assert.That(() => row[0, DataRowVersion.Proposed], Throws.Exception);

            var dataSetAfterEndEdit = SerializeAndDeserializeXml(dataSet);

            var rowAfterEndEdit = dataSetAfterEndEdit.Tables[0].Rows[0];
            Assert.That(rowAfterEndEdit[0], Is.EqualTo("New"));
            Assert.That(rowAfterEndEdit[0, DataRowVersion.Default], Is.EqualTo("New"));
            Assert.That(rowAfterEndEdit[0, DataRowVersion.Original], Is.EqualTo("Old"));
            Assert.That(rowAfterEndEdit[0, DataRowVersion.Current], Is.EqualTo("New"));
        }

        private DataSet SerializeAndDeserializeXml(DataSet dataSet)
        {
            XmlSerializer xmlSerializer = new(typeof(DataSet));
            using StringWriter writer = new();
            xmlSerializer.Serialize(writer, dataSet);

            var xml = writer.ToString();

            var reader = new StringReader(xml);
            return (DataSet)xmlSerializer.Deserialize(reader);
        }

        private static readonly JsonSerializerSettings SerializerSettings = new()
        {
            Converters = new JsonConverter[]
                {
                    new Json.Net.DataSetConverters.DataSetConverter(),
                    new Json.Net.DataSetConverters.DataTableConverter()
                }
        };

        private DataSet SerializeAndDeserializeJson(DataSet dataSet)
        {
            var json = JsonConvert.SerializeObject(dataSet, SerializerSettings);
            return JsonConvert.DeserializeObject<DataSet>(json, SerializerSettings);
        }
    }
}

Consider adding a strong name

In the enterprise environment I currently work in, all projects are signed, and I'm currently unable to directly use this project. Adding a strong name would be very helpful.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.