alexandre-abrioux / gulp-rev-dist-clean

Gulp package that cleans temporary files created by gulp-rev

🏠 Hi there!

... and welcome to my GitHub profile! My name is Alexandre Abrioux, I'm from France, currently living in Paris, and working as a software architect at Request, a crypto payments solution for businesses. You can also find me on

📣 Logs

May 7, 2024

Fixed a bug in axios, see more on axios/axios#6362

November 14, 2023

Contributed to axios-retry!

September 28, 2023

Just contributed to the Cross-Desktop Group project (freedesktop.org)! See this xdg-utils merge request.

October 3, 2022

My first contribution to supertest npm package got merged!

March 22, 2022

Just got my first contribution merged on the DefinitelyTyped repository! I added type definitions for the ethereum-block-by-date npm package. The PR has been accepted and types are now available at @types/ethereum-block-by-date.

February 15, 2022

Started working on adding support for the EIP-1559 to Cartesi's Noether Node. The PR has been submitted for review.

May 26, 2021

Added schema validation support to Doctrine MongoDB ODM. The new feature has been merged and will be released in version 2.3.

March 2, 2021

My contribution to Cartesi's Noether Node was featured in one of their Medium article. It is related to improving the gas price estimation when submitting new blocks.

January 14, 2021

My submission to Gitcoin's Hack New Golem bounty won one of the four prizes allocated by the Golem organization! Read more on Golem's Blog article and take a look at the project over here: alexandre-abrioux/golem-node.

🔨 Featured Projects & Contributions

Blockchain

• Maintainer of alexandre-abrioux/golem-node, a Dockerized version of New Golem Node
• Generated types for ethereum-block-by-date, an Ethereum block finder by date - #59366 - #59762
• Contributed to @rainbow-me/fee-suggestions, an EIP-1559 gas fee forecaster - #25
• Contributed to aave/aave-js, the AAVE Javascript SDK - #114 - #115 - #117
• Contributed to cartesi/noether, Cartesi's Noether Node - #1 - #3 - (WIP) #2 #6 #9 #10

Node.js

• Maintainer of alexandre-abrioux/gulp-rev-dist-clean, a gulp-rev plugin to prune temporary files
• Contributed to axios, an HTTP client for the browser and Node.js - #6362
• Contributed to axios-logger, an Axios logging middleware - #97
• Contributed to axios-retry, an Axios plugin that retries failed requests - #248
• Contributed to ioredis, a Redis client for Node.js - #1137 - #1139
• Contributed to mikro-orm, an ORM based on the Unit of Work pattern - #5158
• Contributed to nestjs-cls, an async context manager for NestJS - #118 - #119
• Contributed to pnpm-shell-completion, a completion tool for pnpm - #19
• Contributed to supertest, a testing library for Node.js - #767
• Contributed to winston, a logger for Node.js - #1961

PHP

• Contributed to amnuts/opcache-gui, a web interface for OPcache - #15
• Contributed to doctrine/mongodb-odm, Doctrine's ODM for MongoDB - #2238 - #2246
• Contributed to schmittjoh/JMSSerializerBundle, Symfony Bundle to serialize and deserialize data - #782
• Contributed to symfony/monolog-bundle, Symfony Monolog Bundle - #368
• Contributed to Troopers/MangopayBundle, the Mangopay API's implementation for Symfony - #38 - #40

Misc

• Contributed to shadowsocks/shadowsocks-libev, a lightweight secured SOCKS5 proxy - #2866
• Contributed to predatorray/shadowsocks-helm-chart, an Helm Chart for Shadowsocks - #1 - #2
• Contributed to xdg/xdg-utils, a set of scripts for Free Desktop integration - #35

🔧 My Toolbox

Language	Framework	Infra	Testing	Dev	Ci

---

⚡ Recent GitHub Activity (public repositories only)

1. 🎉 Merged PR #1404 in RequestNetwork/requestNetwork
2. 🎉 Merged PR #99 in RequestNetwork/payments-subgraph
3. 💪 Opened PR #99 in RequestNetwork/payments-subgraph
4. 🎉 Merged PR #98 in RequestNetwork/payments-subgraph
5. 💪 Opened PR #98 in RequestNetwork/payments-subgraph

⚡ GitHub Stats (public repositories only)

⚡ Most Used Languages (own public repositories only)

gulp-rev-dist-clean's Issues

Add del force option

If your files are outside the current directory where Gulp is running, this script will fail with the following error

	throw new Error('Cannot delete files/folders outside the current working directory. Can be overriden with the `force` option.');

I think it is possible to fix this by implementing the following option: https://stackoverflow.com/questions/44106774/cannot-force-deleting-files-outside-of-current-folder-typeerror-glob-pattern-s

I can push a pull request if you are okay with merging it.

Recursive cleaning does not work

Hello,
I was trying to use your package but I've encountered weird behaviour.
We have rev-manifest.json with only around ~600 files, but they are in few nested folders.
For example (js, css, img (flags, icons, avatars), fonts (fontwesome, anotherfonts)).

After adding console.log(file.path) to line https://github.com/alexandre-abrioux/gulp-rev-dist-clean/blob/master/index.js#L27 before the condition it prints out:

build\css
build\fonts
build\img
build\js
build\rev-manifest.json
build\css\base
build\css\bootstrap
build\css\bootstrap-multiselect-9fbf7bf47b.css
build\css\calendar
build\css\flot
build\css\jquery.linkselect-5f50594e27.css
build\css\pages
build\css\qtip
build\css\slickgrid
build\css\spam-dash-62c330442f.css
build\css\stats-admin-a36841a59c.css
build\css\style-c60c061139.css

It does not even try to walk through js or other folders.
I'm using version 1.0.4

It's being called from gulpfile like this:

gulp.task('rev-dist-clean', function(){
	gulp.src(['build/**/*'], {read: false})
		.pipe(revDistClean('build/rev-manifest.json'))
});

Am I doing something wrong? :)
Thanks !

After another debug I've discovered, that settings (https://github.com/rvagg/through2/blob/master/through2.js#L88) from 16 to 5000 does the trick.

So what now. :)

This does the trick. I've found it after looking at different gulp packages like (https://github.com/galkinrost/gulp-rev-css-url/blob/master/index.js#L40)

.map files

.map files are not included in the rev-manifest.json so if for example app-HASH.js exists in the manifest file and app-HASH.js.map exists in the folder too, app-HASH.js.map file be deleted.

if i exclude .map files from src glob, old map files will never be deleted

It delete all of files in assets directory